Skip to content

Commit 4f760ae

Browse files
committed
Fix tests for latest mruby
1 parent d7e9142 commit 4f760ae

5 files changed

Lines changed: 11 additions & 28 deletions

File tree

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
MRUBY_CONFIG=File.expand_path(ENV["MRUBY_CONFIG"] || "build_config.rb")
22

33
file :mruby do
4-
sh "git clone --depth=1 git://github.com/mruby/mruby.git"
4+
sh "git clone --depth=1 https://github.com/mruby/mruby.git"
55
end
66

77
desc "compile binary"

build_config.rb.lock

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,5 @@
11
---
22
mruby:
3-
version: 3.0.0
4-
release_no: 30000
5-
git_commit: 01a21085f6348b1f1b070f2c64a6ed71b6d5afce
6-
builds:
7-
host:
8-
https://github.com/iij/mruby-errno.git:
9-
url: https://github.com/iij/mruby-errno.git
10-
branch: HEAD
11-
commit: b4415207ff6ea62360619c89a1cff83259dc4db0
12-
version: 0.0.0
3+
version: 3.3.0
4+
release_no: 30300
5+
git_commit: a8694bdefb62e5a4183d5b34637591879ef5e0f2

src/mrb_msgpack.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,6 @@ mrb_msgpack_unpack(mrb_state *mrb, mrb_value data)
617617
mrb_msgpack_unpack_m_cb_data cb_data = {data, RSTRING_PTR(data), RSTRING_LEN(data), mrb_nil_value(), &result};
618618
mrb_value cb_data_cptr = mrb_cptr_value(mrb, &cb_data);
619619
mrb_value unpack_return = mrb_ensure(mrb, mrb_msgpack_unpack_m_cb, cb_data_cptr, mrb_msgpack_unpack_m_ensure, cb_data_cptr);
620-
mrb_gc_protect(mrb, unpack_return);
621620
return unpack_return;
622621
}
623622

test/msgpack.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,6 @@ mrb_mruby_simplemsgpack_gem_test(mrb_state *mrb)
2121
struct RClass *msgpack_test = mrb_define_module(mrb, "MessagePackTest");
2222
mrb_define_module_function(mrb, msgpack_test, "test_pack", mrb_msgpack_test_pack, MRB_ARGS_NONE());
2323
mrb_define_module_function(mrb, msgpack_test, "test_unpack", mrb_msgpack_test_unpack, MRB_ARGS_REQ(1));
24+
mrb_define_const(mrb, msgpack_test, "FIXNUM_MAX", mrb_int_value(mrb, MRB_INT_MAX));
25+
mrb_define_const(mrb, msgpack_test, "FIXNUM_MIN", mrb_int_value(mrb, MRB_INT_MIN));
2426
}

test/msgpack.rb

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,28 +14,18 @@
1414
end
1515

1616
assert("Integer#to_msgpack") do
17-
[Mrbtest::FIXNUM_MIN, -1, 0, 1, Mrbtest::FIXNUM_MAX].each do |int|
18-
expected = int
19-
20-
actual = MessagePack.unpack(int.to_msgpack)
21-
assert_true actual.equal?(expected), "Expected identity", assertion_diff(expected, actual)
22-
23-
actual = MessagePack.unpack(MessagePack.pack(int))
24-
assert_true actual.equal?(expected), "Expected identity", assertion_diff(expected, actual)
17+
[MessagePackTest::FIXNUM_MIN, -1, 0, 1, MessagePackTest::FIXNUM_MAX].each do |int|
18+
assert_equal(int, MessagePack.unpack(int.to_msgpack))
19+
assert_equal(int, MessagePack.unpack(MessagePack.pack(int)))
2520
end
2621
end
2722

2823
if Object.const_defined? "Float"
2924
assert("Float#to_msgpack") do
3025
floats = [2.2250738585072014e-308, -1.7976931348623157e+308, 1.192092896e-07, 3.402823466e+38, 1.175494351e-38, 1.7976931348623157e+308, -2.2250738585072014e-308]
3126
floats.each do |float|
32-
expected = float
33-
34-
actual = MessagePack.unpack(float.to_msgpack)
35-
assert_true actual.equal?(expected), "Expected identity", assertion_diff(expected, actual)
36-
37-
actual = MessagePack.unpack(MessagePack.pack(float))
38-
assert_true actual.equal?(expected), "Expected identity", assertion_diff(expected, actual)
27+
assert_equal(float, MessagePack.unpack(float.to_msgpack))
28+
assert_equal(float, MessagePack.unpack(MessagePack.pack(float)))
3929
end
4030
end
4131
end
@@ -208,4 +198,3 @@ class Cls; include Mod end
208198
assert("C Packing and unpacking") do
209199
assert_equal("hallo", MessagePackTest.test_unpack(MessagePackTest.test_pack))
210200
end
211-

0 commit comments

Comments
 (0)