Don't pass structs using locks by value

If passed by value, the locks lose all purpose.

Reported by go vet.

Author: mvdan

common/mock.go

@@ -26,7 +26,7 @@ type MockSocket struct {
 	Receiver chan string
 }
 
-func (sock MockSocket) Write(data []byte) (int, error) {
+func (sock *MockSocket) Write(data []byte) (int, error) {
 	glog.V(3).Infoln("[Debug]: Starting MockSocket.Write of:", string(data))
 	if sock.Counter != nil {
 		sock.Counter <- true
@@ -38,14 +38,14 @@ func (sock MockSocket) Write(data []byte) (int, error) {
 	return len(data), nil
 }
 
-func (sock MockSocket) Read(into []byte) (int, error) {
+func (sock *MockSocket) Read(into []byte) (int, error) {
 	sock.RLock()
 	defer sock.RUnlock()
 	time.Sleep(time.Second) // Prevent busy loop
 	return 0, nil
 }
 
-func (sock MockSocket) Close() error {
+func (sock *MockSocket) Close() error {
 	if sock.Receiver != nil {
 		close(sock.Receiver)
 	}

network/irc/irc.go

@@ -40,7 +40,7 @@ type chatBotStats struct {
 	m map[string]*expvar.Map
 }
 
-func (s chatBotStats) GetOrCreate(identifier string) (*expvar.Map, bool) {
+func (s *chatBotStats) GetOrCreate(identifier string) (*expvar.Map, bool) {
 	s.RLock()
 	chatbotStats, ok := s.m[identifier]
 	s.RUnlock()

network/irc/irc_test.go

@@ -176,7 +176,7 @@ func TestFlood(t *testing.T) {
 		pingResponse:     make(chan struct{}, 10), // HACK: This is to avoid the current deadlock
 		sendQueue:        make(chan []byte, 256),
 	}
-	chatbot.init(mockSocket)
+	chatbot.init(&mockSocket)
 
 	startTime := time.Now()
 
@@ -224,7 +224,7 @@ func TestUpdate(t *testing.T) {
 		pingResponse:     make(chan struct{}, 10), // HACK: This is to avoid the current deadlock
 		sendQueue:        make(chan []byte, 256),
 	}
-	chatbot.init(mockSocket)
+	chatbot.init(&mockSocket)
 	conf := map[string]string{
 		"nick": "test", "password": "testxyz", "server": "localhost"}
 	channels = append(channels, &NEW_CHANNEL)