Fix typos

Author: sjoubert

common/src/main/kotlin/com/cosmotech/common/metrics/MonitorServiceAspect.kt

@@ -91,7 +91,7 @@ class MonitorServiceAspect(
             value = 1.0,
             labels = licensingMetricLabels,
             qualifier = "call",
-            type = PersitentMetricType.COUNTER,
+            type = PersistentMetricType.COUNTER,
             downSampling = true,
             downSamplingAggregation = DownSamplingAggregationType.MAX,
         )

common/src/main/kotlin/com/cosmotech/common/metrics/PersistentMetric.kt

@@ -26,6 +26,6 @@ data class PersistentMetric(
     val downSamplingBucketDuration: Long = 0,
     val downSamplingAggregation: DownSamplingAggregationType = DownSamplingAggregationType.AVG,
     val downSamplingSuffix: String = DEFAULT_DOWN_SAMPLING_SUFFIX,
-    val type: PersitentMetricType = PersitentMetricType.COUNTER,
+    val type: PersistentMetricType = PersistentMetricType.COUNTER,
     val scope: String = DEFAULT_SCOPE,
 )

…ch/common/metrics/PersitentMetricType.kt …h/common/metrics/PersistentMetricType.ktcommon/src/main/kotlin/com/cosmotech/common/metrics/PersitentMetricType.kt renamed to common/src/main/kotlin/com/cosmotech/common/metrics/PersistentMetricType.kt common/src/main/kotlin/com/cosmotech/common/metrics/PersitentMetricType.kt renamed to common/src/main/kotlin/com/cosmotech/common/metrics/PersistentMetricType.kt

@@ -2,7 +2,7 @@
 // Licensed under the MIT license.
 package com.cosmotech.common.metrics
 
-enum class PersitentMetricType {
+enum class PersistentMetricType {
   COUNTER,
   GAUGE,
 }

common/src/main/kotlin/com/cosmotech/common/security/filters/ApiKeyAuthenticationFilter.kt

@@ -55,8 +55,8 @@ class ApiKeyAuthenticationFilter(val csmPlatformProperties: CsmPlatformPropertie
           val isUriMatching =
               securedUris
                   .associateWith { it.split("/.*", ignoreCase = true, limit = 2) }
-                  .filter { (securedUri, securedUriSplitted) ->
-                    filterSecuredUriWithRequestUri(securedUriSplitted, requestUri, securedUri)
+                  .filter { (securedUri, securedUriSplit) ->
+                    filterSecuredUriWithRequestUri(securedUriSplit, requestUri, securedUri)
                   }
                   .isNotEmpty()
 
@@ -87,18 +87,18 @@ class ApiKeyAuthenticationFilter(val csmPlatformProperties: CsmPlatformPropertie
   }
 
   private fun filterSecuredUriWithRequestUri(
-      securedUriSplitted: List<String>,
+      securedUriSplit: List<String>,
       requestUri: String,
       securedUri: String,
   ) =
-      if (securedUriSplitted.size == 1 && securedUriSplitted[0] == "/") {
+      if (securedUriSplit.size == 1 && securedUriSplit[0] == "/") {
         true
       } else {
-        val requestUriSplitted = requestUri.split(securedUriSplitted[0])
-        if (requestUriSplitted.size < 2) {
+        val requestUriSplit = requestUri.split(securedUriSplit[0])
+        if (requestUriSplit.size < 2) {
           false
         } else {
-          val uriSuffix = securedUriSplitted[0] + requestUriSplitted[1]
+          val uriSuffix = securedUriSplit[0] + requestUriSplit[1]
           securedUri.toRegex().matches(uriSuffix)
         }
       }

common/src/main/kotlin/com/cosmotech/common/utils/AnyExtensions.kt

@@ -40,7 +40,7 @@ fun <T> T.convertToMap(): Map<String, Any> =
  *
  * @param new the new object against which comparison is performed
  * @param mutateIfChanged whether to mutate the current object if for fields that have changed
- * @param excludedFields an array of fields to exlude from comparison. Note that fields named 'id´
+ * @param excludedFields an array of fields to exclude from comparison. Note that fields named 'id´
  *   are automatically excluded, by convention.
  * @throws UnsupportedOperationException if the object being compared are not instances of a data
  *   class
@@ -80,9 +80,9 @@ inline fun <reified T> T.compareToAndMutateIfNeeded(
             membersChanged.add(member.name)
             if (mutateIfChanged) {
               require(member is KMutableProperty) {
-                """Detected change but cannot mutate this object 
+                """Detected change but cannot mutate this object
                     because property ${member.name} (on class ${T::class}) is not mutable.
-                    Either exclude this field or call this function with mutateIfChanged=false 
+                    Either exclude this field or call this function with mutateIfChanged=false
                     to view the changes detected"""
               }
 

common/src/test/kotlin/com/cosmotech/common/containerregistry/ContainerRegistryServiceTest.kt

@@ -106,18 +106,18 @@ class ContainerRegistryServiceTest {
     val jo = JSONObject()
     jo.put("name", "my-repository")
     jo.put("tags", ja)
-    val reponseMockk = mockk<ResponseSpec>()
+    val responseMockk = mockk<ResponseSpec>()
 
     every {
       restClient
           .get()
           .uri("/v2/my-repository/tags/list")
           .header(HttpHeaders.AUTHORIZATION, any())
           .retrieve()
-    } returns reponseMockk
+    } returns responseMockk
 
-    every { reponseMockk.onStatus(any(), any()) } returns reponseMockk
-    every { reponseMockk.body(String::class.java) } returns jo.toString()
+    every { responseMockk.onStatus(any(), any()) } returns responseMockk
+    every { responseMockk.body(String::class.java) } returns jo.toString()
 
     containerRegistryService.checkSolutionImage("my-repository", "latest")
   }

openapi/example_files/ADTConnector.yaml

@@ -22,7 +22,7 @@
           valueType: string
           envVar: AZURE_CLIENT_ID
         - id: AZURE_CLIENT_SECRET
-          label: Azure CLient secret
+          label: Azure Client secret
           valueType: password
           envVar: AZURE_CLIENT_SECRET
     - id: parameters

organization/src/integrationTest/kotlin/com/cosmotech/organization/service/OrganizationServiceIntegrationTest.kt

@@ -783,7 +783,7 @@ class OrganizationServiceIntegrationTest : CsmTestBase() {
         val name = "o-connector-test-1"
         val organizationRegistered =
             organizationApiService.createOrganization(makeSimpleOrganizationCreateRequest(name))
-        organizationApiService.getOrganizationAccessControl(organizationRegistered.id, "UNKOWN")
+        organizationApiService.getOrganizationAccessControl(organizationRegistered.id, "UNKNOWN")
       }
     }
 
@@ -2000,7 +2000,7 @@ class OrganizationServiceIntegrationTest : CsmTestBase() {
       val name = "o-connector-test-1"
       val organizationRegistered =
           organizationApiService.createOrganization(makeSimpleOrganizationCreateRequest(name))
-      organizationApiService.getOrganizationAccessControl(organizationRegistered.id, "UNKOWN")
+      organizationApiService.getOrganizationAccessControl(organizationRegistered.id, "UNKNOWN")
     }
   }
 

run/src/main/kotlin/com/cosmotech/run/metrics/RunMetrics.kt

@@ -8,7 +8,7 @@ import com.cosmotech.common.events.PersistentMetricEvent
 import com.cosmotech.common.events.RunStart
 import com.cosmotech.common.metrics.DownSamplingAggregationType
 import com.cosmotech.common.metrics.PersistentMetric
-import com.cosmotech.common.metrics.PersitentMetricType
+import com.cosmotech.common.metrics.PersistentMetricType
 import com.cosmotech.runner.domain.Runner
 import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty
 import org.springframework.context.event.EventListener
@@ -73,7 +73,7 @@ internal class RunMetrics(
             incrementBy = 1,
             qualifier = TOTAL_QUALIFIER,
             labels = labels,
-            type = PersitentMetricType.COUNTER,
+            type = PersistentMetricType.COUNTER,
             downSampling = true,
             downSamplingAggregation = DownSamplingAggregationType.MAX,
         )

runner/src/integrationTest/kotlin/com/cosmotech/runner/service/RunnerServiceIntegrationTest.kt

@@ -802,7 +802,7 @@ class RunnerServiceIntegrationTest : CsmTestBase() {
   }
 
   @Test
-  fun `test AccessControls management on Runner as ressource Admin`() {
+  fun `test AccessControls management on Runner as resource Admin`() {
     logger.info("should add an Access Control and assert it has been added")
     val runnerAccessControl = RunnerAccessControl(TEST_USER_MAIL, ROLE_VIEWER)
     var runnerAccessControlRegistered =
@@ -2295,7 +2295,7 @@ class RunnerServiceIntegrationTest : CsmTestBase() {
   }
 
   @Test
-  fun `test runner creation based on solution without dataset's type parameters with overrided parameter value on workspace`() {
+  fun `test runner creation based on solution without dataset's type parameters with overridden parameter value on workspace`() {
 
     // 1 - Create a solution with simple solution parameter
     val simpleParameterId = "my_property_name"
@@ -2336,15 +2336,15 @@ class RunnerServiceIntegrationTest : CsmTestBase() {
             solutionCreateRequestWithDatasetParameters,
         )
 
-    val simpleParameterOverridedValue = "my_override_value"
+    val simpleParameterOverriddenValue = "my_override_value"
     workspace =
         makeWorkspaceCreateRequest(
             name = "Workspace",
             workspaceSolution =
                 WorkspaceSolution(
                     solutionId = solutionSaved.id,
                     defaultParameterValues =
-                        mutableMapOf(simpleParameterId to simpleParameterOverridedValue),
+                        mutableMapOf(simpleParameterId to simpleParameterOverriddenValue),
                 ),
         )
     workspaceSaved = workspaceApiService.createWorkspace(organizationSaved.id, workspace)
@@ -2381,7 +2381,7 @@ class RunnerServiceIntegrationTest : CsmTestBase() {
     assertEquals(1, runnerParametersValues.size)
     val runnerParameterValue = runnerParametersValues[0]
     assertEquals(simpleParameterId, runnerParameterValue.parameterId)
-    assertEquals(simpleParameterOverridedValue, runnerParameterValue.value)
+    assertEquals(simpleParameterOverriddenValue, runnerParameterValue.value)
     assertEquals(simpleParameterVarType, runnerParameterValue.varType)
   }