Validate API and APP key for monitor deployment (#675)

* Validate API and APP key for monitor deployment

When packaging then deploying as two separate steps, validating that the API and APP
keys were present didn't happen before we tried to deploy.  This caused the monitors
deployment to fail silently without logging anything.  Add the same validation that
is done already to the beforeDeploy step as well.

Github Issue: #494

JIRA: https://datadoghq.atlassian.net/browse/SVLS-5045

* fix lint

Author: avangelillo

src/index.spec.ts

@@ -971,6 +971,84 @@ describe("ServerlessPlugin", () => {
     expect(threwError).toBe(false);
   });
 
+  describe("beforeDeploy", () => {
+    afterEach(() => {
+      mock.restore();
+    });
+
+    it("logs and does not throw when validateConfiguration fails and failOnError is false", async () => {
+      mock({});
+      let logs = "";
+      const serverless = {
+        cli: { log: (m: string) => (logs += m) },
+        getProvider: (_name: string) => awsMock(),
+        service: {
+          getServiceName: () => "dev",
+          provider: { region: "us-east-1" },
+          functions: {},
+          custom: {
+            datadog: {
+              site: "datadogehq.com", // invalid to trigger validateConfiguration error
+              failOnError: false,
+            },
+          },
+        },
+      };
+      const plugin = new ServerlessPlugin(serverless, {});
+      await expect(plugin.hooks["before:deploy:deploy"]()).resolves.not.toThrow();
+      expect(logs).toContain("Warning: Invalid site URL. Must be one of");
+    });
+
+    it("throws when validateConfiguration fails and failOnError is true", async () => {
+      mock({});
+      const serverless = {
+        cli: { log: () => {} },
+        getProvider: (_name: string) => awsMock(),
+        service: {
+          getServiceName: () => "dev",
+          provider: { region: "us-east-1" },
+          functions: {},
+          custom: {
+            datadog: {
+              site: "datadogehq.com", // invalid to trigger validateConfiguration error
+              failOnError: true,
+            },
+          },
+        },
+      };
+      const plugin = new ServerlessPlugin(serverless, {});
+      await expect(plugin.hooks["before:deploy:deploy"]()).rejects.toThrow("Warning: Invalid site URL. Must be one of");
+    });
+
+    it("logs and does not throw when monitors are enabled but API or APP key is missing and failOnError is false", async () => {
+      process.env = {};
+      mock({});
+      let logs = "";
+      const serverless = {
+        cli: { log: (m: string) => (logs += m) },
+        getProvider: (_name: string) => awsMock(),
+        service: {
+          getServiceName: () => "dev",
+          provider: { region: "us-east-1" },
+          functions: {},
+          custom: {
+            datadog: {
+              monitors: true,
+              testingMode: false,
+              integrationTesting: false,
+              failOnError: false,
+              addExtension: false,
+            },
+          },
+        },
+      };
+      const plugin = new ServerlessPlugin(serverless, {});
+      await expect(plugin.hooks["before:deploy:deploy"]()).resolves.not.toThrow();
+      expect(logs).toContain(
+        "When `monitors` is enabled, `DATADOG_API_KEY` and `DATADOG_APP_KEY` environment variables must be set.",
+      );
+    });
+  });
   it("throws an error if not all keys required by monitors are defined", async () => {
     process.env = {};
     mock({});

src/index.ts

@@ -78,6 +78,7 @@ module.exports = class ServerlessPlugin {
     "before:deploy:function:packageFunction": this.beforePackageFunction.bind(this),
     "before:offline:start:init": this.beforePackageFunction.bind(this),
     "before:step-functions-offline:start": this.beforePackageFunction.bind(this),
+    "before:deploy:deploy": this.beforeDeploy.bind(this),
     "after:deploy:deploy": this.afterDeploy.bind(this),
     "before:package:finalize": this.afterPackageFunction.bind(this),
   };
@@ -364,6 +365,19 @@ This is expected if you only deploy part of the stack.`);
     }
   }
 
+  private async beforeDeploy(): Promise<void> {
+    const config = getConfig(this.serverless.service);
+    if (config.enabled === false) return;
+    try {
+      validateConfiguration(config);
+    } catch (error) {
+      this.serverless.cli.log(`Error occurred when validating configuration: ${error}`);
+      if (config.failOnError) {
+        throw error;
+      }
+    }
+  }
+
   private async afterDeploy(): Promise<void> {
     const config = getConfig(this.serverless.service);
     const custom = this.serverless.service.custom ?? {};