Merge pull request #48 from EncoreTechnologies/bugfix/bash-errors

Fixing bug in update_rh.sh where yum errors were being ignored

Author: nmaludy

CHANGELOG.md

@@ -25,7 +25,12 @@ All notable changes to this project will be documented in this file.
   config value wasn't being honored. (Bug Fix)
 
   Contributed by Nick Maludy (@nmaludy)
-  
+
+* Fixed a bug in `patching::update` task on RHEL where errors in the `yum` command we're
+  being reported due to the use of a `|`. Now we check `$PIPESTATUS[0]` instead of `$?`. (Bug Fix)
+
+  Contributed by Nick Maludy (@nmaludy)
+
 * Added new configuration options:
   * `patching_reboot_wait`: Parameter controls the `reboot_wait` option for the number of seconds
     to wait between reboots. Default = 300

files/bash/update_rh.sh

@@ -67,7 +67,15 @@ EOF
 STATUS=0
 
 ## Yum package manager
-YUM_UPDATE=$(yum -y update $PACKAGES | tee -a "$LOG_FILE")
+#
+# Because we're using '| tee' inside a $(), we can't just check $? after the command
+# as it will return the exit code of the LAST thing in the pipe,
+# instead we really want to return code of the `yum` command (first thing in the pipe).
+# For this to work, we need to exit the command in the $() with a value
+# from the $PIPESTATUS array to get access to the `yum` command's return value.
+# Now, the exit status for the $() will be whatever the exit status is for `yum` instead
+# of the exit status of `tee`.
+YUM_UPDATE=$(yum -y update $PACKAGES | tee -a "$LOG_FILE"; exit ${PIPESTATUS[0]})
 STATUS=$?
 
 # check if packages were updated or not