Merge pull request #54 from corporate-gadfly/useless-use-of-cat

avoid cat when used with single file

Author: nmaludy

.gitignore

@@ -33,3 +33,4 @@
 bolt.log
 Puppetfile.lock
 modules
+site-modules

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 ## Development
 
+* Fixed trivial bug with useless use of cat
+
+  Contributed by Haroon Rafique
+
 ## Release 1.1.0 (2020-04-15)
 
 * Added new plans `patching::get_facts` to retrieve a set of facts from a list of targets

DEVELOPMENT.md

@@ -3,7 +3,7 @@
 ## Quick start
 
 ```shell
-ln -s ../ site-modules/patching
+mkdir site-modules && ln -s ../ site-modules/patching
 vagrant up centos
 bolt task run facts --targets vagrant_centos
 ```

files/bash/os_test.sh

@@ -1,11 +1,11 @@
 #!/bin/bash
 
 if [ -e /etc/os-release ]; then
-  export OS_RELEASE=$(cat /etc/os-release  | sed -n -e "/^ID=/p" | sed -e 's~\(.*\)=\(.*\)~\U\2~g' -e 's~"~~g')
+  export OS_RELEASE=$(sed -n -e "/^ID=/p" /etc/os-release | sed -e 's~\(.*\)=\(.*\)~\U\2~g' -e 's~"~~g')
 else
 # fall back to older methods for OS that do not use systemd
   export OS_TEST_DEB=$(lsb_release -a 2> /dev/null | grep Distributor | awk '{print $3}')
-  export OS_TEST_RH=$(cat /etc/redhat-release 2> /dev/null | sed -e "s~\(.*\)release.*~\1~g")
+  export OS_TEST_RH=$(sed -e "s~\(.*\)release.*~\1~g" /etc/redhat-release 2> /dev/null)
 
   if [[ -n "$OS_TEST_RH" ]]; then
     export OS_RELEASE='RHEL'