Merge pull request #36 from EncoreTechnologies/hotfix/size-checks

Fix bug where .size was on a potentially undef value in patching::update_history

Author: nmaludy

CHANGELOG.md

@@ -8,6 +8,12 @@ All notable changes to this project will be documented in this file.
 
   Contributed by Vadym Chepkov (@vchepkov)
 
+* Fixed a bug where if `patching::update_history` task was called and no results were returned
+  the `patching::update_history` plan would fail. Now, we default to an empty array so a 0
+  is displayed.
+
+  Contributed by Nick Maludy (@nmaludy)
+
 ## Release 1.0.0 (2020-02-28)
 
 * **BREAKING CHANGE** 

plans/update_history.pp

@@ -54,8 +54,11 @@
       $header = sprintf($row_format, 'host', 'upgraded', 'installed')
       $divider = '-----------------------------------------------------'
       $output = $_history.map|$hist| {
-        $num_upgraded = $hist['upgraded'].size
-        $num_installed = $hist['installed'].size
+        # in case history doesn't contain any updates
+        $upgraded = pick($hist['upgraded'], [])
+        $installed = pick($hist['installed'], [])
+        $num_upgraded = $upgraded.size
+        $num_installed = $installed.size
         $row_format = '%-30s | %-8s | %-8s'
         $message = sprintf($row_format, $hist.target.name, $num_upgraded, $num_installed)
         $message
@@ -68,8 +71,10 @@
       $csv_header = "host,action,name,version,kb (windows only)\n"
       $report = $_history.reduce($csv_header) |$res_memo, $res| {
         $hostname = $res.target.name
-        $num_updates = $res['upgraded'].length
-        $host_updates = $res['upgraded'].reduce('') |$up_memo, $up| {
+        # in case history doesn't contain any updates
+        $upgraded = pick($res['upgraded'], [])
+        $num_updates = $upgraded.length
+        $host_updates = $upgraded.reduce('') |$up_memo, $up| {
           $name = $up['name']
           $version = ('version' in $up) ? {
             true    => $up['version'],