Fixing build

Author: nmaludy

CHANGELOG.md

@@ -13,14 +13,19 @@ All notable changes to this project will be documented in this file.
 
 * Fixed a bug with a hard coded wait for reboot. (Bug Fix)
 
-Contributed by Michael Surato (@msurato)
+  Contributed by Michael Surato (@msurato)
 
 * Add `hostname` as a choice for patching::snapshot_vmware::target_name_property
   It can be used in cases where target discovery uses fully qualified domain names
   and VM names don't have domain name component
 
   Contributed by Vadym Chepkov (@vchepkov)
 
+* Fixed a bug in `patching::monitoring_solarwinds` plan where `patching_monitoring_name_property`
+  config value wasn't being honored. (Bug Fix)
+
+  Contributed by Nick Maludy (@nmaludy)
+
 ## Release 1.0.1 (2020-03-04)
 
 * Ensure the `patching.json` file exists on Windows by creating a blank file if it was previously missing.
@@ -39,7 +44,7 @@ Contributed by Michael Surato (@msurato)
 
 ## Release 1.0.0 (2020-02-28)
 
-* **BREAKING CHANGE** 
+* **BREAKING CHANGE**
   Converted from `nodes` to `targets` for all plans and tasks. This is in support of Bolt `2.0`.
   Any calling plans or CLI will need to use the `targets` parameter to pass in the hosts
   to be patched. (Feature)
@@ -53,7 +58,7 @@ Contributed by Michael Surato (@msurato)
 * Added documentation for patching with PE and `pcp` timeouts. (Documentation) #28
 
   Contributed by Nick Maludy (@nmaludy)
-  
+
 * PDK sync to 1.17.0 template (Enhancement)
 
   Contributed by Nick Maludy (@nmaludy)
@@ -65,11 +70,11 @@ Contributed by Michael Surato (@msurato)
   Contributed by Michael Surato (@msurato)
 
 * Fixed bug in `patching::snapshot_vmware` where the wrong snapshot name was printed to the user. (Bug Fix)
-  
+
   Contributed by Nick Maludy (@nmaludy)
-  
+
 * Fixed bug in `patching::available_updates_windows` where using `provider=windows` threw an error. (Bug Fix)
-  
+
   Contributed by Nick Maludy (@nmaludy)
 
 * Add support for Fedora Linux. (Enhancement)
@@ -78,15 +83,15 @@ Contributed by Michael Surato (@msurato)
 
 * Modified location of the puppet executable on Linux to use the supported wrapper. This sets
   library paths to solve consistency issues. (Bug Fix)
-  
+
   Contributed by Michael Surato (@msurato)
 
 ## Release 0.4.0 (2020-01-06)
 
 * Add support for SUSE Linux Enterprise. (Enhancement)
 
   Contributed by Michael Surato (@msurato)
-  
+
 * Modify the scripts to use /etc/os-release. This will fallback to older methods in the absense of /etc/os-release. (Enhancement)
 
   Contributed by Michael Surato (@msurato)
@@ -95,16 +100,16 @@ Contributed by Michael Surato (@msurato)
 
   Contributed by Vadym Chepkov (@vchepkov)
 
-* Fixed a bug in `patching::puppet_facts` where the sub command would fail to run on 
+* Fixed a bug in `patching::puppet_facts` where the sub command would fail to run on
   installations with custom `GEM_PATH` settings. (Bug Fix)
-  
+
   Contributed by Nick Maludy (@nmaludy)
-  
+
 * Changed the property we use to look up SolarWinds nodes from `'Caption'` to `'DNS'` by
   default. Also made the property configurable using the `patching_monitoring_name_property`.
   There are now new parameters on the `patching::monitoring_solarwinds` task and plans
   to allow specifying what property we are matching for on the SolarWinds side. (Enhancement)
-  
+
   Contributed by Nick Maludy (@nmaludy)
 
 
@@ -115,22 +120,22 @@ Contributed by Michael Surato (@msurato)
   Contributed by Vadym Chepkov (@vchepkov)
 
 * Added shields/badges to the README. (Enhancement)
-  
+
   Contributed by Nick Maludy (@nmaludy)
 
 * Added the ability to enable/disable monitoring during patching. The first implementation
   is to do this in the SolarWinds monitoring tool:
-  * Task - `patching::monitoring_solarwinds` : This task enables/disbles monitoring for a list 
+  * Task - `patching::monitoring_solarwinds` : This task enables/disbles monitoring for a list
     of node names.
   * Plan - `patching::monitoring_solarwinds` : Wraps the `patching::monitoring_solarwinds` task in an
     easier to consume fashion, along with configuration option parsing and pretty printing.
   (Enhancement)
-  
+
   Contributed by Nick Maludy (@nmaludy)
-  
+
 * Changed the name of the configuration option `patching_vm_name_property` to `patching_snapshot_target_name_property`.
   This correlates to the new property that was just added (below). (Enhancement)
-  
+
   Contributed by Nick Maludy (@nmaludy)
 
 * Added a new configs:
@@ -142,15 +147,15 @@ Contributed by Michael Surato (@msurato)
       maps to the node's name in the monitoring tool (SolarWinds).
       This was intentionally made discinct from `patching_snapshot_target_name_property` in case
       the tools used different names for the same node/target.
-  
+
   Contributed by Nick Maludy (@nmaludy)
-  
+
 * Empty strings `''` for plan names no longer disable the execution of plans (the
   `pick()` function removes these, so it gets ignored). Instead pass in the string
   `'disabled'` to disable the use of a pluggable plan. (Bug fix)
-  
+
   Contributed by Nick Maludy (@nmaludy)
-  
+
 
 ## Release 0.2.0
 
@@ -159,7 +164,7 @@ Contributed by Michael Surato (@msurato)
   Due to this i also had to create matching task metadata for `_linux` and `_windows`
   and mark them as `"private": true` so that they are not visible in `bolt task show`.
   (Enhancement)
-  
+
   Contributed by Nick Maludy (@nmaludy)
 
 ## Release 0.1.0

plans/set_facts.pp

@@ -50,13 +50,13 @@
   # the explicitly defined facts always win
   $_facts = $custom_facts + {'patching_group' => $patching_group}
   $_facts_yaml = to_yaml($_facts)
-  out::message("============= writing facts.d/patching.yaml =============")
+  out::message('============= writing facts.d/patching.yaml =============')
   out::message($_facts_yaml)
 
   if !$targets_linux.empty() {
     write_file($_facts_yaml,
-               '/etc/facter/facts.d/patching.yaml',
-               $targets_linux)
+                '/etc/facter/facts.d/patching.yaml',
+                $targets_linux)
     $results_linux = run_command('/opt/puppetlabs/bin/puppet facts upload', $targets_linux)
   }
   else {
@@ -65,8 +65,8 @@
 
   if !$targets_windows.empty() {
     write_file($_facts_yaml,
-               'C:/ProgramData/PuppetLabs/facter/facts.d/patching.yaml',
-               $targets_windows)
+                'C:/ProgramData/PuppetLabs/facter/facts.d/patching.yaml',
+                $targets_windows)
     $results_windows =  run_command("& 'C:/Program Files/Puppet Labs/Puppet/bin/puppet' facts upload", $targets_windows)
   }
   else {