Skip to content

Commit 7c31148

Browse files
author
Yoshito Umaoka
committed
Fixed some issues based on Steven's review
1 parent 93f7882 commit 7c31148

2 files changed

Lines changed: 14 additions & 11 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ To see available commands and options, please see [Globalization Pipeline CLI To
4343

4444
## Maven Plugin (gp-maven-plugin)
4545

46-
This plugin integrates Globalization Pipeline service with Apache Maven build.
46+
This plugin integrates Globalization Pipeline service with an Apache Maven build.
4747
With the plugin, you can upload source resource bundles to your own Globalization
4848
Pipeline service instance, and download translated resource bundles.
4949

gp-maven-plugin.md

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,10 @@ in pom.xml.
8080
### <a name="TOC-Usage-Credentials"></a>Specifying Globalization Pipeline Service Credentials
8181

8282
The plugin requires *service instance administrator* credentials for a Globalization
83-
Pipeline service instance. There are two ways to specify the service credentials.
83+
Pipeline service instance. Please refer [Quick Start Guide](https://github.com/IBM-Bluemix/gp-common#quick-start-guide)
84+
to see how to get service credentials information of your Globalization Pipeline instance.
85+
86+
There are two ways to specify the service credentials.
8487

8588
#### JSON file
8689

@@ -219,15 +222,15 @@ and `src/nls2/resources/en`. If you want to include both sets, use the configura
219222
<bundleSets>
220223
<bundleSet>
221224
<sourceFiles>
222-
<direcotry>src/nls1/resources/en</directory>
225+
<directory>src/nls1/resources/en</directory>
223226
<includes>
224227
<include>**/*.properties</include>
225228
</includes>
226229
</sourceFiles>
227230
</bundleSet>
228231
<bundleSet>
229232
<sourceFiles>
230-
<direcotry>src/nls2/resources/en</directory>
233+
<directory>src/nls2/resources/en</directory>
231234
<includes>
232235
<include>**/*.properties</include>
233236
</includes>
@@ -249,7 +252,7 @@ as a part of output file name (or path). The following example does such mapping
249252
<bundleSets>
250253
<bundleSet>
251254
<sourceFiles>
252-
<direcotry>src/resources</directory>
255+
<directory>src/resources</directory>
253256
<includes>
254257
<include>**/*.properties</include>
255258
</includes>
@@ -287,7 +290,7 @@ versions in parallel language directories.
287290
<bundleSets>
288291
<bundleSet>
289292
<sourceFiles>
290-
<direcotry>src/main/webapp</directory>
293+
<directory>src/main/webapp</directory>
291294
<includes>
292295
<include>**/en/*.json</include>
293296
</includes>
@@ -445,11 +448,11 @@ target languages currently available in the Globalization Pipeline bundle.
445448

446449
#### `<languageMap>`
447450

448-
Specifies custom language mappings. Each nested element name is a BCP 47 language tag used by
449-
Globalization Pipeline service instance, and the element value is a language ID used for output
450-
resource file or path name. For example, Globalization Pipeline service uses language ID "pt-BR"
451-
for Brazilian Portuguese. If you want to use just "pt" for output file or path name, you can
452-
specify the mapping as below.
451+
Specifies custom language mappings. Each nested element name is a [BCP 47 language tag](https://tools.ietf.org/html/bcp47)
452+
used by Globalization Pipeline service instance, and the element value is a language ID used for
453+
output resource file or path name. For example, Globalization Pipeline service uses language ID
454+
"pt-BR" for Brazilian Portuguese. If you want to use just "pt" for output file or path name, you
455+
can specify the mapping as below.
453456

454457
```
455458
<languageMap>

0 commit comments

Comments
 (0)