Skip to content

Commit 929d4c4

Browse files
authored
Merge pull request #108 from yumaoka/bug-105-parse-props
Fixed Java properties file parsing problem
2 parents 3069032 + 84ec294 commit 929d4c4

6 files changed

Lines changed: 283 additions & 150 deletions

File tree

gp-cli/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,8 @@ There are several different resource types available:
160160

161161
* **JAVA** - Java property resource bundle file
162162
* **JAVAUTF8** - Java UTF8 property resource bundle file
163+
* **JAVAMSG** - Java property resource bundle file with MessageFormat pattern stirngs only
164+
* **JAVAMSGUTF8** - Java UTF8 property resource bundle file with MessageFormat pattern strings only
163165
* **JSON** - Resource string key/value pairs stored in JSON format. For now nested JSON object is not supported.
164166
* **AMDJS** - RequireJS I18N bundle file
165167
* **GLOBALIZEJS** - Globalize.js JSON resource bundle file

gp-maven-plugin/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -412,6 +412,9 @@ excludes all files with file name `config.json`.
412412
Specifies a resource type. Available options are
413413

414414
* **JAVA** - Java property resource bundle file
415+
* **JAVAUTF8** - Java UTF8 property resource bundle file
416+
* **JAVAMSG** - Java property resource bundle file with MessageFormat pattern stirngs only
417+
* **JAVAMSGUTF8** - Java UTF8 property resource bundle file with MessageFormat pattern strings only
415418
* **JSON** - Resource string key/value pairs stored in JSON format. For now nested JSON object is not supported.
416419
* **AMDJS** - RequireJS I18N bundle file
417420
* **GLOBALIZEJS** - Globalize.js JSON resource bundle file

gp-res-filter/src/main/java/com/ibm/g11n/pipeline/resfilter/impl/DefaultResourceFilterProvider.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import com.ibm.g11n.pipeline.resfilter.MultiBundleResourceFilter;
2626
import com.ibm.g11n.pipeline.resfilter.ResourceFilter;
2727
import com.ibm.g11n.pipeline.resfilter.ResourceFilterProvider;
28+
import com.ibm.g11n.pipeline.resfilter.impl.JavaPropertiesResource.Encoding;
29+
import com.ibm.g11n.pipeline.resfilter.impl.JavaPropertiesResource.MessagePatternEscape;
2830

2931
/**
3032
* The default {@link ResourceFilterProvider} implementation.
@@ -38,6 +40,8 @@ enum Filter {
3840
GLOBALIZEJS,
3941
IOS,
4042
JAVA,
43+
JAVAMSG,
44+
JAVAMSGUTF8,
4145
JAVAUTF8,
4246
JSON,
4347
PO,
@@ -90,10 +94,16 @@ public ResourceFilter getResourceFilter(String id) {
9094
result = new IOSStringsResource();
9195
break;
9296
case JAVA:
93-
result = new JavaPropertiesResource(false);
97+
result = new JavaPropertiesResource(Encoding.ISO_8859_1, MessagePatternEscape.AUTO);
98+
break;
99+
case JAVAMSG:
100+
result = new JavaPropertiesResource(Encoding.ISO_8859_1, MessagePatternEscape.ALL);
101+
break;
102+
case JAVAMSGUTF8:
103+
result = new JavaPropertiesResource(Encoding.UTF_8, MessagePatternEscape.ALL);
94104
break;
95105
case JAVAUTF8:
96-
result = new JavaPropertiesResource(true);
106+
result = new JavaPropertiesResource(Encoding.UTF_8, MessagePatternEscape.AUTO);
97107
break;
98108
case JSON:
99109
result = new JsonResource();

0 commit comments

Comments
 (0)