Skip to content

Commit 2b2056d

Browse files
committed
Remove more references to programs
1 parent 3c9298c commit 2b2056d

9 files changed

Lines changed: 50 additions & 50 deletions

File tree

dpctl/tests/test_raw_kernel_arg.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ def launch_raw_arg_kernel(raw):
6969
spirv_file = get_spirv_abspath("raw-arg-kernel.spv")
7070
with open(spirv_file, "br") as spv:
7171
spv_bytes = spv.read()
72-
prog = dpctl.program.create_kernel_bundle_from_spirv(q, spv_bytes)
73-
kernel = prog.get_sycl_kernel("__sycl_kernel_raw_arg_kernel")
72+
kb = dpctl.program.create_kernel_bundle_from_spirv(q, spv_bytes)
73+
kernel = kb.get_sycl_kernel("__sycl_kernel_raw_arg_kernel")
7474
local_size = 16
7575
global_size = local_size * 8
7676

dpctl/tests/test_sycl_event.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ def produce_event(profiling=False):
3737
q = dpctl.SyclQueue("opencl:cpu", property="enable_profiling")
3838
else:
3939
q = dpctl.SyclQueue("opencl:cpu")
40-
prog = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
41-
addKernel = prog.get_sycl_kernel("add")
40+
kb = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
41+
addKernel = kb.get_sycl_kernel("add")
4242

4343
n = 1024 * 1024
4444
a = np.arange(n, dtype="i")
@@ -158,10 +158,10 @@ def test_get_wait_list():
158158
size_t index = get_global_id(0); \
159159
a[index] = sin(a[index]); \
160160
}"
161-
prog = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
162-
addKernel = prog.get_sycl_kernel("add_k")
163-
sqrtKernel = prog.get_sycl_kernel("sqrt_k")
164-
sinKernel = prog.get_sycl_kernel("sin_k")
161+
kb = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
162+
addKernel = kb.get_sycl_kernel("add_k")
163+
sqrtKernel = kb.get_sycl_kernel("sqrt_k")
164+
sinKernel = kb.get_sycl_kernel("sin_k")
165165

166166
n = 1024 * 1024
167167
a = np.arange(n, dtype="f")

dpctl/tests/test_sycl_kernel_submit.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ def test_create_kernel_bundle_from_source(ctype_str, dtype, ctypes_ctor):
5959
" c[index] = d * a[index] + b[index];"
6060
"}"
6161
)
62-
prog = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
63-
axpyKernel = prog.get_sycl_kernel("axpy")
62+
kb = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
63+
axpyKernel = kb.get_sycl_kernel("axpy")
6464

6565
n_elems = 1024 * 512
6666
lws = 128
@@ -174,10 +174,10 @@ def test_submit_async():
174174
" (arg1[index] < arg2[index]) ? arg1[index] : arg2[index];"
175175
"}"
176176
)
177-
prog = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
178-
kern1Kernel = prog.get_sycl_kernel("kern1")
179-
kern2Kernel = prog.get_sycl_kernel("kern2")
180-
kern3Kernel = prog.get_sycl_kernel("kern3")
177+
kb = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
178+
kern1Kernel = kb.get_sycl_kernel("kern1")
179+
kern2Kernel = kb.get_sycl_kernel("kern2")
180+
kern3Kernel = kb.get_sycl_kernel("kern3")
181181

182182
assert isinstance(kern1Kernel, dpctl_prog.SyclKernel)
183183
assert isinstance(kern2Kernel, dpctl_prog.SyclKernel)
@@ -322,8 +322,8 @@ def test_submit_local_accessor_arg():
322322
fn = get_spirv_abspath("local_accessor_kernel_inttys_fp32.spv")
323323
with open(fn, "br") as f:
324324
spirv_bytes = f.read()
325-
prog = dpctl_prog.create_kernel_bundle_from_spirv(q, spirv_bytes)
326-
krn = prog.get_sycl_kernel("_ZTS14SyclKernel_SLMIlE")
325+
kb = dpctl_prog.create_kernel_bundle_from_spirv(q, spirv_bytes)
326+
krn = kb.get_sycl_kernel("_ZTS14SyclKernel_SLMIlE")
327327
lws = 32
328328
gws = lws * 10
329329
x = np.ones(gws, dtype="i8")

dpctl/tests/test_sycl_program.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -147,15 +147,15 @@ def _check_cpython_api_SyclKernel_Make(krn):
147147
assert krn.work_group_size == k3.work_group_size
148148

149149

150-
def _check_multi_kernel_program(prog):
151-
assert type(prog) is dpctl_prog.SyclKernelBundle
150+
def _check_multi_kernel_program(kb):
151+
assert type(kb) is dpctl_prog.SyclKernelBundle
152152

153-
assert type(prog.addressof_ref()) is int
154-
assert prog.has_sycl_kernel("add")
155-
assert prog.has_sycl_kernel("axpy")
153+
assert type(kb.addressof_ref()) is int
154+
assert kb.has_sycl_kernel("add")
155+
assert kb.has_sycl_kernel("axpy")
156156

157-
addKernel = prog.get_sycl_kernel("add")
158-
axpyKernel = prog.get_sycl_kernel("axpy")
157+
addKernel = kb.get_sycl_kernel("add")
158+
axpyKernel = kb.get_sycl_kernel("axpy")
159159

160160
assert "add" == addKernel.get_function_name()
161161
assert "axpy" == axpyKernel.get_function_name()
@@ -185,8 +185,8 @@ def _check_multi_kernel_program(prog):
185185
cmsgsz = krn.compile_sub_group_size
186186
assert type(cmsgsz) is int
187187

188-
_check_cpython_api_SyclKernelBundle_GetKernelBundleRef(prog)
189-
_check_cpython_api_SyclKernelBundle_Make(prog)
188+
_check_cpython_api_SyclKernelBundle_GetKernelBundleRef(kb)
189+
_check_cpython_api_SyclKernelBundle_Make(kb)
190190

191191

192192
def test_create_kernel_bundle_from_source_ocl():
@@ -203,8 +203,8 @@ def test_create_kernel_bundle_from_source_ocl():
203203
q = dpctl.SyclQueue("opencl")
204204
except dpctl.SyclQueueCreationError:
205205
pytest.skip("No OpenCL queue is available")
206-
prog = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
207-
_check_multi_kernel_program(prog)
206+
kb = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
207+
_check_multi_kernel_program(kb)
208208

209209

210210
def test_create_kernel_bundle_from_spirv_ocl():
@@ -215,8 +215,8 @@ def test_create_kernel_bundle_from_spirv_ocl():
215215
spirv_file = get_spirv_abspath("multi_kernel.spv")
216216
with open(spirv_file, "rb") as fin:
217217
spirv = fin.read()
218-
prog = dpctl_prog.create_kernel_bundle_from_spirv(q, spirv)
219-
_check_multi_kernel_program(prog)
218+
kb = dpctl_prog.create_kernel_bundle_from_spirv(q, spirv)
219+
_check_multi_kernel_program(kb)
220220

221221

222222
def test_create_kernel_bundle_from_spirv_l0():
@@ -227,8 +227,8 @@ def test_create_kernel_bundle_from_spirv_l0():
227227
spirv_file = get_spirv_abspath("multi_kernel.spv")
228228
with open(spirv_file, "rb") as fin:
229229
spirv = fin.read()
230-
prog = dpctl_prog.create_kernel_bundle_from_spirv(q, spirv)
231-
_check_multi_kernel_program(prog)
230+
kb = dpctl_prog.create_kernel_bundle_from_spirv(q, spirv)
231+
_check_multi_kernel_program(kb)
232232

233233

234234
@pytest.mark.xfail(
@@ -248,8 +248,8 @@ def test_create_kernel_bundle_from_source_l0():
248248
size_t index = get_global_id(0); \
249249
c[index] = a[index] + d*b[index]; \
250250
}"
251-
prog = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
252-
_check_multi_kernel_program(prog)
251+
kb = dpctl_prog.create_kernel_bundle_from_source(q, oclSrc)
252+
_check_multi_kernel_program(kb)
253253

254254

255255
def test_create_kernel_bundle_from_invalid_src_ocl():

dpctl/tests/test_work_group_memory.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ def test_submit_work_group_memory():
6262
spirv_file = get_spirv_abspath("work-group-memory-kernel.spv")
6363
with open(spirv_file, "br") as spv:
6464
spv_bytes = spv.read()
65-
prog = dpctl.program.create_kernel_bundle_from_spirv(q, spv_bytes)
66-
kernel = prog.get_sycl_kernel("__sycl_kernel_local_mem_kernel")
65+
kb = dpctl.program.create_kernel_bundle_from_spirv(q, spv_bytes)
66+
kernel = kb.get_sycl_kernel("__sycl_kernel_local_mem_kernel")
6767
local_size = 16
6868
global_size = local_size * 8
6969

dpctl/tests/test_work_group_memory_opencl.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ def test_submit_work_group_memory_opencl():
4545
except dpctl.SyclQueueCreationError:
4646
pytest.skip("OpenCL queue could not be created")
4747

48-
prog = dpctl.program.create_kernel_bundle_from_source(q, ocl_kernel_src)
49-
kernel = prog.get_sycl_kernel("local_mem_kernel")
48+
kb = dpctl.program.create_kernel_bundle_from_source(q, ocl_kernel_src)
49+
kernel = kb.get_sycl_kernel("local_mem_kernel")
5050
local_size = 16
5151
global_size = local_size * 8
5252

examples/pybind11/use_dpctl_sycl_kernel/tests/test_user_kernel.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ def test_kernel_can_be_found():
4545
q = dpctl.SyclQueue()
4646
except dpctl.SyclQueueCreationError:
4747
pytest.skip("Could not create default queue")
48-
pr = dppr.create_kernel_bundle_from_spirv(q, il, "")
49-
assert pr.has_sycl_kernel("double_it")
48+
kb = dppr.create_kernel_bundle_from_spirv(q, il, "")
49+
assert kb.has_sycl_kernel("double_it")
5050

5151

5252
def test_kernel_submit_through_extension():
@@ -57,8 +57,8 @@ def test_kernel_submit_through_extension():
5757
q = dpctl.SyclQueue()
5858
except dpctl.SyclQueueCreationError:
5959
pytest.skip("Could not create default queue")
60-
pr = dppr.create_kernel_bundle_from_spirv(q, il, "")
61-
krn = pr.get_sycl_kernel("double_it")
60+
kb = dppr.create_kernel_bundle_from_spirv(q, il, "")
61+
krn = kb.get_sycl_kernel("double_it")
6262
assert krn.num_args == 2
6363

6464
x = np.arange(0, stop=13, step=1, dtype="i4")

libsyclinterface/include/syclinterface/dpctl_sycl_kernel_bundle_interface.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
//===----------------------------------------------------------------------===//
2121
///
2222
/// \file
23-
/// This header declares a C API to create Sycl interoperability programs for
24-
/// OpenCL and Level Zero driver API.
23+
/// This header declares a C API to create Sycl kernel bundles for OpenCL and
24+
/// Level Zero backends.
2525
///
2626
//===----------------------------------------------------------------------===//
2727

@@ -70,7 +70,7 @@ DPCTLKernelBundle_CreateFromSpirv(__dpctl_keep const DPCTLSyclContextRef Ctx,
7070
* @param Dev An opaque pointer to a sycl::device
7171
* @param Source OpenCL source string
7272
* @param CompileOpts Extra compiler flags (refer Sycl spec.)
73-
* @return A new SyclKernelBundleRef pointer if the program creation
73+
* @return A new SyclKernelBundleRef pointer if the kernel bundle creation
7474
* succeeded, else returns NULL.
7575
* @ingroup KernelBundleInterface
7676
*/
@@ -82,8 +82,8 @@ __dpctl_give DPCTLSyclKernelBundleRef DPCTLKernelBundle_CreateFromOCLSource(
8282
__dpctl_keep const char *CompileOpts);
8383

8484
/*!
85-
* @brief Returns the SyclKernel with given name from the program, if not found
86-
* then return NULL.
85+
* @brief Returns the SyclKernel with given name from the kernel bundle, if
86+
* not found then return NULL.
8787
*
8888
* @param KBRef Opaque pointer to a sycl::kernel_bundle
8989
* @param KernelName Name of kernel
@@ -96,8 +96,8 @@ DPCTLKernelBundle_GetKernel(__dpctl_keep DPCTLSyclKernelBundleRef KBRef,
9696
__dpctl_keep const char *KernelName);
9797

9898
/*!
99-
* @brief Return True if a SyclKernel with given name exists in the program, if
100-
* not found then returns False.
99+
* @brief Return True if a SyclKernel with given name exists in the kernel
100+
* bundle, if not found then returns False.
101101
*
102102
* @param KBRef Opaque pointer to a sycl::kernel_bundle
103103
* @param KernelName Name of kernel

libsyclinterface/tests/test_sycl_kernel_bundle_interface.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ TEST_P(TestDPCTLSyclKernelBundleInterface, ChkCreateFromSpirvNull)
147147
ASSERT_TRUE(KBRef == nullptr);
148148
}
149149

150-
TEST_P(TestDPCTLSyclKernelBundleInterface, ChkHasKernelNullProgram)
150+
TEST_P(TestDPCTLSyclKernelBundleInterface, ChkHasKernelNullKernelBundle)
151151
{
152152

153153
DPCTLSyclKernelBundleRef NullRef = nullptr;
@@ -168,7 +168,7 @@ TEST_P(TestDPCTLSyclKernelBundleInterface, ChkGetKernel)
168168
EXPECT_NO_FATAL_FAILURE(DPCTLKernel_Delete(NullKernel));
169169
}
170170

171-
TEST_P(TestDPCTLSyclKernelBundleInterface, ChkGetKernelNullProgram)
171+
TEST_P(TestDPCTLSyclKernelBundleInterface, ChkGetKernelNullKernelBundle)
172172
{
173173
DPCTLSyclKernelBundleRef NullRef = nullptr;
174174
DPCTLSyclKernelRef KRef = nullptr;

0 commit comments

Comments
 (0)