Merge pull request #178 from IntelPython/remove-star-import

Remove star import from `_mkl_service`

Author: ndgrigorian

.flake8

@@ -4,8 +4,6 @@ extend-ignore =
     E203,
     # line too long (in docstrings):
     E501,
-    # ‘from module import *’ used; unable to detect undefined names:
-    F403,
     # doc line too long (105 > 80 characters):
     W505,
     # missing docstring in public module:

.git-blame-ignore-revs

@@ -8,3 +8,6 @@
 
 # Move to clang-format-22
 6056b26ff82dfd156708fd7d3680470d9ba3c9ce
+
+# Clean up in setup.py
+5045ed9c6b39fa1747cdae2719477e5a596f0d3b

CHANGELOG.md

@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 * Fixed Cython warnings when building `mkl-service` [gh-183](https://github.com/IntelPython/mkl-service/pull/183)
+* Removed use of star import in `mkl-service` initialization, which removes imported module pollution from the namespace [gh-178](https://github.com/IntelPython/mkl-service/pull/178)
 
 ## [2.6.1] (11/25/2025)
 

mkl/__init__.py

@@ -23,8 +23,6 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-import sys
-
 from . import _init_helper
 
 
@@ -34,6 +32,7 @@ def __init__(self):
 
     def __enter__(self):
         import ctypes
+        import sys
 
         try:
             self.saved_rtld = sys.getdlopenflags()
@@ -46,6 +45,8 @@ def __enter__(self):
         del ctypes
 
     def __exit__(self, *args):
+        import sys
+
         if self.saved_rtld:
             sys.setdlopenflags(self.saved_rtld)
             self.saved_rtld = None
@@ -55,9 +56,84 @@ def __exit__(self, *args):
     from . import _mklinit
 
 del RTLD_for_MKL
-del sys
 
-from ._py_mkl_service import *
+from ._py_mkl_service import (
+    cbwr_get,
+    cbwr_get_auto_branch,
+    cbwr_set,
+    disable_fast_mm,
+    domain_get_max_threads,
+    domain_set_num_threads,
+    dsecnd,
+    enable_instructions,
+    free_buffers,
+    get_clocks_frequency,
+    get_cpu_clocks,
+    get_cpu_frequency,
+    get_dynamic,
+    get_env_mode,
+    get_max_cpu_frequency,
+    get_max_threads,
+    get_num_stripes,
+    get_version,
+    get_version_string,
+    mem_stat,
+    peak_mem_usage,
+    second,
+    set_dynamic,
+    set_env_mode,
+    set_memory_limit,
+    set_mpi,
+    set_num_stripes,
+    set_num_threads,
+    set_num_threads_local,
+    thread_free_buffers,
+    verbose,
+    vml_clear_err_status,
+    vml_get_err_status,
+    vml_get_mode,
+    vml_set_err_status,
+    vml_set_mode,
+)
 from ._version import __version__
 
+__all__ = [
+    "get_version",
+    "get_version_string",
+    "set_num_threads",
+    "domain_set_num_threads",
+    "set_num_threads_local",
+    "set_dynamic",
+    "get_max_threads",
+    "domain_get_max_threads",
+    "get_dynamic",
+    "set_num_stripes",
+    "get_num_stripes",
+    "second",
+    "dsecnd",
+    "get_cpu_clocks",
+    "get_cpu_frequency",
+    "get_max_cpu_frequency",
+    "get_clocks_frequency",
+    "free_buffers",
+    "thread_free_buffers",
+    "disable_fast_mm",
+    "mem_stat",
+    "peak_mem_usage",
+    "set_memory_limit",
+    "cbwr_set",
+    "cbwr_get",
+    "cbwr_get_auto_branch",
+    "enable_instructions",
+    "set_env_mode",
+    "get_env_mode",
+    "verbose",
+    "set_mpi",
+    "vml_set_mode",
+    "vml_get_mode",
+    "vml_set_err_status",
+    "vml_get_err_status",
+    "vml_clear_err_status",
+]
+
 del _init_helper

pyproject.toml

@@ -72,6 +72,13 @@ test = ["pytest"]
 Download = "http://github.com/IntelPython/mkl-service"
 Homepage = "http://github.com/IntelPython/mkl-service"
 
+[tool.black]
+line-length = 80
+
+[tool.isort]
+line_length = 80
+profile = "black"
+
 [tool.setuptools]
 include-package-data = true
 packages = ["mkl"]

setup.py

@@ -37,7 +37,10 @@ def extensions():
     if mkl_root:
         mkl_info = {
             "include_dirs": [join(mkl_root, "include")],
-            "library_dirs": [join(mkl_root, "lib"), join(mkl_root, "lib", "intel64")],
+            "library_dirs": [
+                join(mkl_root, "lib"),
+                join(mkl_root, "lib", "intel64"),
+            ],
             "libraries": ["mkl_rt"],
         }
     else:
@@ -62,7 +65,8 @@ def extensions():
             "mkl._mklinit",
             sources=[join("mkl", "_mklinitmodule.c")],
             include_dirs=mkl_include_dirs,
-            libraries=mkl_libraries + (["pthread"] if os.name == "posix" else []),
+            libraries=mkl_libraries
+            + (["pthread"] if os.name == "posix" else []),
             library_dirs=mkl_library_dirs,
             runtime_library_dirs=mkl_rpaths,
             extra_compile_args=[