Skip to content

Commit 20f650b

Browse files
[SPIR-V] Remove redundant check and fix typos
1 parent 0963833 commit 20f650b

2 files changed

Lines changed: 10 additions & 11 deletions

File tree

llvm/lib/IR/Type.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -859,10 +859,9 @@ struct TargetTypeInfo {
859859
static TargetTypeInfo getTargetTypeInfo(const TargetExtType *Ty) {
860860
LLVMContext &C = Ty->getContext();
861861
StringRef Name = Ty->getName();
862-
if (Name.startswith("spirv.") || Name.startswith("opencl.")) {
862+
if (Name.startswith("spirv."))
863863
return TargetTypeInfo(Type::getInt8PtrTy(C, 0), TargetExtType::HasZeroInit,
864864
TargetExtType::CanBeGlobal);
865-
}
866865

867866
// Opaque types in the AArch64 name space.
868867
if (Name == "aarch64.svcount")

llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1975,7 +1975,7 @@ static const TargetExtType *parseToTargetExtType(const Type *OpaqueType,
19751975
assert(NameWithParameters.startswith("spirv.") &&
19761976
"Unknown builtin opaque type!");
19771977

1978-
// Parametrized SPIR-V builtins names follow this format:
1978+
// Parameterized SPIR-V builtins names follow this format:
19791979
// e.g. %spirv.Image._void_1_0_0_0_0_0_0, %spirv.Pipe._0
19801980
if (NameWithParameters.find('_') == std::string::npos)
19811981
return TargetExtType::get(OpaqueType->getContext(), NameWithParameters);
@@ -1985,12 +1985,12 @@ static const TargetExtType *parseToTargetExtType(const Type *OpaqueType,
19851985
SplitString(NameWithParameters.substr(BaseNameLength + 1), Parameters, "_");
19861986

19871987
SmallVector<Type *, 1> TypeParameters;
1988-
bool HasTypeParamter = !isDigit(Parameters[0][0]);
1989-
if (HasTypeParamter)
1988+
bool HasTypeParameter = !isDigit(Parameters[0][0]);
1989+
if (HasTypeParameter)
19901990
TypeParameters.push_back(parseTypeString(
19911991
Parameters[0], MIRBuilder.getMF().getFunction().getContext()));
19921992
SmallVector<unsigned> IntParameters;
1993-
for (unsigned i = HasTypeParamter ? 1 : 0; i < Parameters.size(); i++) {
1993+
for (unsigned i = HasTypeParameter ? 1 : 0; i < Parameters.size(); i++) {
19941994
unsigned IntParameter = 0;
19951995
bool ValidLiteral = !Parameters[i].getAsInteger(10, IntParameter);
19961996
assert(ValidLiteral &&
@@ -2006,10 +2006,10 @@ static const TargetExtType *parseToTargetExtType(const Type *OpaqueType,
20062006
// Implementation functions for builtin types.
20072007
//===----------------------------------------------------------------------===//
20082008

2009-
static SPIRVType *getNonParametrizedType(const TargetExtType *ExtensionType,
2010-
const SPIRV::BuiltinType *TypeRecord,
2011-
MachineIRBuilder &MIRBuilder,
2012-
SPIRVGlobalRegistry *GR) {
2009+
static SPIRVType *getNonParameterizedType(const TargetExtType *ExtensionType,
2010+
const SPIRV::BuiltinType *TypeRecord,
2011+
MachineIRBuilder &MIRBuilder,
2012+
SPIRVGlobalRegistry *GR) {
20132013
unsigned Opcode = TypeRecord->Opcode;
20142014
// Create or get an existing type from GlobalRegistry.
20152015
return GR->getOrCreateOpTypeByOpcode(ExtensionType, MIRBuilder, Opcode);
@@ -2114,7 +2114,7 @@ SPIRVType *lowerBuiltinType(const Type *OpaqueType,
21142114
break;
21152115
default:
21162116
TargetType =
2117-
getNonParametrizedType(BuiltinType, TypeRecord, MIRBuilder, GR);
2117+
getNonParameterizedType(BuiltinType, TypeRecord, MIRBuilder, GR);
21182118
break;
21192119
}
21202120

0 commit comments

Comments
 (0)