Skip to content

Commit 49a8bd8

Browse files
authored
tidy up cl_khr_create_command_queue (#1138)
Removes unneeded special-case text regarding the type accepted for CL_QUEUE_PROPERTIES. Calling this a cl_bitfield was a bug all along, and using cl_command_queue_properties is fine because it is a bitfield anyhow. Generalizes some text so it is not specific to OpenCL 2.x devices. Removes a TODO - no changes required.
1 parent f09a9c2 commit 49a8bd8

2 files changed

Lines changed: 3 additions & 19 deletions

File tree

api/cl_khr_create_command_queue.asciidoc

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,11 @@ No new command-queue properties are required by this extension.
2424
Applications may use the existing {CL_DEVICE_QUEUE_PROPERTIES} query to
2525
determine command-queue properties that are supported by the device.
2626

27-
OpenCL 2.x devices may support this extension for compatibility.
27+
Newer OpenCL devices may support this extension for compatibility.
2828
In this scenario, the function added by this extension will have the same
2929
capabilities as the core {clCreateCommandQueueWithProperties} API.
30-
Applications that only target OpenCL 2.x devices should use the core OpenCL
31-
2.x {clCreateCommandQueueWithProperties} API instead of this extension API.
32-
33-
NOTE: The type of the property value passed as {CL_QUEUE_PROPERTIES} to
34-
{clCreateCommandQueueWithPropertiesKHR} is specified as
35-
{cl_bitfield_TYPE} while the type passed to
36-
{clCreateCommandQueueWithProperties} is
37-
{cl_command_queue_properties_TYPE}.
38-
While this is not a promotion in terms of the suffixing, both types
39-
are aliased to {cl_ulong_TYPE}, so no ABI or compiler issues should
40-
result if the extension and core APIs are supported.
41-
30+
Applications that only target newer OpenCL devices should use the core
31+
{clCreateCommandQueueWithProperties} API instead of this extension API.
4232

4333
=== New Commands
4434

@@ -48,8 +38,6 @@ result if the extension and core APIs are supported.
4838

4939
* {cl_queue_properties_khr_TYPE}
5040

51-
//@ TODO Missing bitfield values allowed for CL_QUEUE_PROPERTIES?
52-
5341
=== Version History
5442

5543
* Revision 1.0.0, 2020-04-21

api/opencl_runtime_layer.asciidoc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,6 @@ endif::cl_khr_create_command_queue[]
6868

6969
include::{generated}/api/version-notes/CL_QUEUE_PROPERTIES.asciidoc[]
7070
| {cl_command_queue_properties_TYPE}
71-
72-
ifdef::cl_khr_create_command_queue[]
73-
or {cl_bitfield_TYPE} if the {cl_khr_create_command_queue_EXT} extension is supported
74-
endif::cl_khr_create_command_queue[]
7571
| This is a bitfield and can be set to a combination of the following
7672
values:
7773

0 commit comments

Comments
 (0)