Merge pull request #1435 from mrvisscher/change-result-close-behaviour

Results won't close on CS and Parameter changes anymore

Author: marc-vdm

activity_browser/layouts/tabs/LCA_results_tab.py

@@ -35,7 +35,6 @@ def connect_signals(self):
         signals.lca_calculation.connect(self.generate_setup)
         self.tabCloseRequested.connect(self.close_tab)
         bd.projects.current_changed.connect(self.close_all)
-        bd.parameters.parameters_changed.connect(self.close_all)
 
     @Slot(str, name="removeSetup")
     def remove_setup(self, name: str):

activity_browser/layouts/tabs/LCA_results_tabs.py

@@ -164,8 +164,6 @@ def __init__(self, data: dict, parent=None):
         self.currentChanged.connect(self.generate_content_on_click)
         QApplication.restoreOverrideCursor()
 
-        calculation_setups.metadata_changed.connect(self.check_cs)
-
     def setup_tabs(self):
         """Have all of the tabs pull in their required data and add them."""
         self._update_tabs()
@@ -235,10 +233,6 @@ def generate_lcia_scenario_excel(self):
                 filepath += ".xlsx"
             df.to_excel(filepath)
 
-    def check_cs(self):
-        if self.cs != calculation_setups.get(self.cs_name, None):
-            self.deleteLater()
-
 
 class NewAnalysisTab(BaseRightTab):
     """Parent class around which all sub-tabs are built."""