Fix broken groups check on parameter recalculate

Author: mrvisscher

activity_browser/actions/parameter/parameter_modify.py

@@ -1,13 +1,17 @@
-from typing import Any
+from logging import getLogger
 
-from bw2data.parameters import ParameterBase, parameters
+import bw2data as bd
+from bw2data.parameters import ParameterBase, parameters, ActivityParameter, Group, GroupDependency
+from peewee import DoesNotExist
 
 from activity_browser.ui.icons import qicons
 from activity_browser.bwutils import refresh_parameter, Parameter
 from activity_browser.actions.base import ABAction, exception_dialogs
 
 from .parameter_rename import ParameterRename
 
+log = getLogger(__name__)
+
 
 class ParameterModify(ABAction):
     """
@@ -35,4 +39,18 @@ def run(parameter: tuple | Parameter | ParameterBase, field: str, value: any):
         param_model.save()
 
         if field in ("amount", "formula"):
+            ParameterModify.fix_broken_groups()
             parameters.recalculate()
+
+    @staticmethod
+    def fix_broken_groups():
+        groups = Group.select().execute()
+        for group in groups:
+            if group.name == "project" or group.name in bd.databases:
+                continue
+            try:
+                ActivityParameter._static_dependencies(group.name)
+            except DoesNotExist:
+                log.warning(f"Removing broken parameter group {group.name}")
+                GroupDependency.get(GroupDependency.group == group.name).delete_instance()
+                group.delete_instance()

activity_browser/layouts/pages/parameters/parameter_models.py

@@ -85,16 +85,8 @@ def edit_single_parameter(self, index: QModelIndex) -> None:
         param = self.get_parameter(index)
         field = self._dataframe.columns[index.column()]
 
-        try:
-            actions.ParameterModify.run(param, field, index.data())
-        except Exception as e:
-            QtWidgets.QMessageBox.warning(
-                application.main_window,
-                "Could not save changes",
-                str(e),
-                QtWidgets.QMessageBox.Ok,
-                QtWidgets.QMessageBox.Ok,
-            )
+        actions.ParameterModify.run(param, field, index.data())
+
 
     @Slot(QModelIndex, name="startRenameParameter")
     def handle_parameter_rename(self, proxy: QModelIndex) -> None: