Changing FU amounts

Author: mrvisscher

activity_browser/actions/__init__.py

@@ -20,6 +20,7 @@
 from .calculation_setup.cs_duplicate import CSDuplicate
 from .calculation_setup.cs_rename import CSRename
 from .calculation_setup.cs_add_functional_unit import CSAddFunctionalUnit
+from .calculation_setup.cs_change_functional_unit import CSChangeFunctionalUnit
 from .calculation_setup.cs_add_impact_category import CSAddImpactCategory
 from .calculation_setup.cs_delete_impact_category import CSDeleteImpactCategory
 from .calculation_setup.cs_delete_functional_unit import CSDeleteFunctionalUnit

activity_browser/actions/calculation_setup/cs_change_functional_unit.py

@@ -0,0 +1,41 @@
+from logging import getLogger
+
+from activity_browser import bwutils
+from activity_browser.actions.base import ABAction, exception_dialogs
+from activity_browser.mod import bw2data as bd
+
+log = getLogger(__name__)
+
+
+class CSChangeFunctionalUnit(ABAction):
+    """
+    Updates the functional unit amount for a specific inventory item in a calculation setup.
+
+    This method modifies the amount of a functional unit in the inventory of a given calculation setup
+    and saves the updated setup.
+
+    Args:
+        cs_name (str): The name of the calculation setup to modify.
+        index (int): The index of the inventory item within the calculation setup.
+        amount (float): The new amount to set for the functional unit.
+
+    Steps:
+    - Retrieve the calculation setup by its name.
+    - Extract the key of the inventory item at the specified index.
+    - Update the amount for the specified inventory item.
+    - Serialize and save the updated calculation setup.
+
+    Raises:
+        Exception: If an error occurs during the process, it is handled by the `exception_dialogs` decorator.
+    """
+    text = "Add Functional Unit to Calculation Setup"
+
+    @staticmethod
+    @exception_dialogs
+    def run(cs_name: str, index: int, amount: float):
+        calculation_setup = bd.calculation_setups[cs_name]
+
+        key = list(calculation_setup['inv'][index].keys())[0]
+        calculation_setup['inv'][index][key] = amount
+
+        bd.calculation_setups.serialize()

activity_browser/layouts/pages/activity_details/exchanges_tab.py

@@ -261,61 +261,6 @@ def paintEvent(self, event):
         painter.drawText(self.rect(), Qt.AlignCenter, "Drop here to create new exchanges")
 
 
-class ExchangeAmountDelegate(QtWidgets.QStyledItemDelegate):
-    def displayText(self, value, locale):
-        import math
-        try:
-            value = float(value)
-        except ValueError:
-            value = math.nan
-
-        if math.isnan(value):
-            return ""
-        return str(abs(value))
-
-    def createEditor(self, parent, option, index):
-        editor = QtWidgets.QLineEdit(parent)
-        locale = QtCore.QLocale(QtCore.QLocale.English)
-        locale.setNumberOptions(QtCore.QLocale.RejectGroupSeparator)
-        validator = QtGui.QRegularExpressionValidator(
-            QtCore.QRegularExpression(r"^[+-]?((\d+(\.\d*)?)|(\.\d+))([eE][+-]?\d+)?$"),
-            editor)
-        validator.setLocale(locale)
-        editor.setValidator(validator)
-        return editor
-
-    def setEditorData(self, editor: QtWidgets.QLineEdit, index: QtCore.QModelIndex):
-        """Populate the editor with data if editing an existing field."""
-        import math
-
-        data = index.data(QtCore.Qt.DisplayRole)
-
-        try:
-            value = abs(float(data))
-        except ValueError:
-            value = math.nan
-
-        editor.setText(format(value, '.10f').rstrip('0').rstrip('.'))
-
-    def setModelData(
-            self,
-            editor: QtWidgets.QLineEdit,
-            model: QtCore.QAbstractItemModel,
-            index: QtCore.QModelIndex,
-    ):
-        """Take the editor, read the given value and set it in the model"""
-        try:
-            value = float(editor.text())
-            old = float(index.data(QtCore.Qt.DisplayRole))
-
-            if old < 0:
-                value = value * -1
-
-            model.setData(index, value, QtCore.Qt.EditRole)
-        except ValueError:
-            pass
-
-
 class ExchangesView(widgets.ABTreeView):
     """
     A view that displays the exchanges in a tree structure.
@@ -325,7 +270,7 @@ class ExchangesView(widgets.ABTreeView):
         hovered_item (ExchangesItem): The item currently being hovered over.
     """
     defaultColumnDelegates = {
-        "amount": ExchangeAmountDelegate,
+        "amount": delegates.AmountDelegate,
         "allocation_factor": delegates.FloatDelegate,
         "substitution_factor": delegates.FloatDelegate,
         "unit": delegates.StringDelegate,

activity_browser/layouts/pages/calculation_setup/functional_unit_section.py

@@ -1,10 +1,11 @@
 from qtpy import QtWidgets
+from qtpy.QtCore import Qt
 
 import bw2data as bd
 import pandas as pd
 
 from activity_browser import actions
-from activity_browser.ui import widgets, icons
+from activity_browser.ui import widgets, icons, delegates
 from activity_browser.bwutils import AB_metadata
 
 
@@ -46,6 +47,7 @@ def build_df(self):
         act_df = AB_metadata.get_metadata(keys, cols)
         act_df["amount"] = amounts
         act_df["_activity_key"] = keys
+        act_df["_cs_name"] = self.calculation_setup_name
 
         act_df["_processor_key"] = act_df["processor"]
         act_df["_processor_key"] = act_df["_processor_key"].fillna(act_df["_activity_key"])
@@ -73,12 +75,15 @@ def build_df(self):
         act_df.update(act_df["product"].rename("name"))
         act_df["product"] = act_df["name"]
 
-        cols = ["amount", "unit", "product", "process", "database", "location", "_processor_key", "_activity_key"]
+        cols = ["amount", "unit", "product", "process", "database", "location", "_processor_key", "_activity_key", "_cs_name"]
 
         return act_df[cols].reset_index(drop=True)
 
 
 class FunctionalUnitView(widgets.ABTreeView):
+    defaultColumnDelegates = {
+        "amount": delegates.AmountDelegate
+    }
 
     class ContextMenu(widgets.ABMenu):
         menuSetup = [
@@ -119,10 +124,16 @@ def mouseDoubleClickEvent(self, event) -> None:
         Args:
             event: The mouse double click event.
         """
+        index = self.indexAt(event.pos())
+        if index.column() == 0:
+            return super().mouseDoubleClickEvent(event)
+
         if self.selectedIndexes():
             activities = [index.internalPointer()["_processor_key"] for index in self.selectedIndexes()]
             actions.ActivityOpen.run(list(set(activities)))
 
+        return None
+
     def dragMoveEvent(self, event) -> None:
         pass
 
@@ -158,6 +169,45 @@ def decorationData(self, col: int, key: str):
             return icons.qicons.product
         if key == "process":
             return icons.qicons.process
+        return super().decorationData(col, key)
+
+    def flags(self, col: int, key: str):
+        """
+        Returns the item flags for the given column and key.
+
+        Args:
+            col (int): The column index.
+            key (str): The key for which to return the flags.
+
+        Returns:
+            QtCore.Qt.ItemFlags: The item flags.
+        """
+        flags = super().flags(col, key)
+        if key in ["amount"]:
+            return flags | Qt.ItemFlag.ItemIsEditable
+        return flags
+
+    def setData(self, col: int, key: str, value) -> bool:
+        """
+        Sets the data for the given column and key.
+
+        Args:
+            col (int): The column index.
+            key (str): The key for which to set the data.
+            value: The value to set.
+
+        Returns:
+            bool: True if the data was set successfully, False otherwise.
+        """
+        if key not in ["amount"]:
+            return False
+
+        cs_name = self["_cs_name"]
+        index = self.key()
+
+        actions.CSChangeFunctionalUnit.run(cs_name, index, value)
+
+
 
 
 class FunctionalUnitModel(widgets.ABItemModel):

activity_browser/ui/delegates/__init__.py

@@ -14,8 +14,10 @@
 from .new_formula import NewFormulaDelegate
 from .date_time import DateTimeDelegate
 from .property import PropertyDelegate
+from .amount import AmountDelegate
 
 __all__ = [
+    "AmountDelegate",
     "CheckboxDelegate",
     "ComboBoxDelegate",
     "DatabaseDelegate",

activity_browser/ui/delegates/amount.py

@@ -0,0 +1,55 @@
+from qtpy import QtCore, QtGui, QtWidgets
+
+class AmountDelegate(QtWidgets.QStyledItemDelegate):
+    def displayText(self, value, locale):
+        import math
+        try:
+            value = float(value)
+        except ValueError:
+            value = math.nan
+
+        if math.isnan(value):
+            return ""
+        return str(abs(value))
+
+    def createEditor(self, parent, option, index):
+        editor = QtWidgets.QLineEdit(parent)
+        locale = QtCore.QLocale(QtCore.QLocale.English)
+        locale.setNumberOptions(QtCore.QLocale.RejectGroupSeparator)
+        validator = QtGui.QRegularExpressionValidator(
+            QtCore.QRegularExpression(r"^[+-]?((\d+(\.\d*)?)|(\.\d+))([eE][+-]?\d+)?$"),
+            editor)
+        validator.setLocale(locale)
+        editor.setValidator(validator)
+        return editor
+
+    def setEditorData(self, editor: QtWidgets.QLineEdit, index: QtCore.QModelIndex):
+        """Populate the editor with data if editing an existing field."""
+        import math
+
+        data = index.data(QtCore.Qt.DisplayRole)
+
+        try:
+            value = abs(float(data))
+        except ValueError:
+            value = math.nan
+
+        editor.setText(format(value, '.10f').rstrip('0').rstrip('.'))
+
+    def setModelData(
+            self,
+            editor: QtWidgets.QLineEdit,
+            model: QtCore.QAbstractItemModel,
+            index: QtCore.QModelIndex,
+    ):
+        """Take the editor, read the given value and set it in the model"""
+        try:
+            value = float(editor.text())
+            old = float(index.data(QtCore.Qt.DisplayRole))
+
+            if old < 0:
+                value = value * -1
+
+            model.setData(index, value, QtCore.Qt.EditRole)
+        except ValueError:
+            pass