Disable HMR by default

Agent-Logs-Url: https://github.com/NativeScript/nativescript-cli/sessions/58c98aaf-7d9e-410b-b92b-0708f4ff4655

Co-authored-by: NathanWalker <457187+NathanWalker@users.noreply.github.com>

Author: Copilot

lib/data/prepare-data.ts

@@ -33,11 +33,17 @@ export class PrepareData extends ControllerDataBase {
 			Object.assign(env, data.env);
 		}
 
+		const hmr =
+			data.hmr ||
+			data.useHotModuleReload ||
+			env.hmr === true ||
+			env.hmr === "true";
+
 		this.release = data.release;
-		this.hmr = data.hmr || data.useHotModuleReload;
+		this.hmr = hmr;
 		this.env = {
 			...env,
-			hmr: data.hmr || data.useHotModuleReload,
+			hmr,
 		};
 		this.watch = data.watch;
 		if (_.isBoolean(data.watchNative)) {

lib/options.ts

@@ -50,17 +50,16 @@ export class Options {
 		}
 
 		this.argv.bundle = "webpack";
+		const isHmrEnabled = this.isHmrEnabled();
 
 		// Check if the user has explicitly provide --hmr and --release options from command line
-		if (this.initialArgv.release && this.initialArgv.hmr) {
+		if (this.argv.release && isHmrEnabled) {
 			this.$errors.fail(
 				"The options --release and --hmr cannot be used simultaneously."
 			);
 		}
 
-		if (this.argv.hmr) {
-			this.argv.hmr = !this.argv.release;
-		}
+		this.argv.hmr = isHmrEnabled && !this.argv.release;
 
 		if (this.argv.debugBrk) {
 			// we cannot use HMR along with debug-brk because we have to restart the app
@@ -168,7 +167,7 @@ export class Options {
 			hmr: {
 				type: OptionType.Boolean,
 				hasSensitiveValue: false,
-				default: true,
+				default: false,
 			},
 			collection: {
 				type: OptionType.String,
@@ -379,6 +378,21 @@ export class Options {
 		return optionName;
 	}
 
+	private isHmrEnabled(): boolean {
+		if (process.argv.includes("--no-hmr")) {
+			return false;
+		}
+
+		return (
+			this.isTruthyBooleanValue(this.argv.hmr) ||
+			this.isTruthyBooleanValue(_.get(this.argv, "env.hmr"))
+		);
+	}
+
+	private isTruthyBooleanValue(value: unknown): boolean {
+		return value === true || value === "true";
+	}
+
 	private setArgv(): void {
 		const opts: IDictionary<IDashedOption> = <IDictionary<IDashedOption>>{};
 		_.each(this.options, (value: IDashedOption, key: string) => {

package-lock.json

@@ -319,6 +319,12 @@ describe("options", () => {
 				expectedError:
 					"The options --release and --hmr cannot be used simultaneously.",
 			},
+			{
+				name: "--release --env.hmr",
+				args: ["--release", "--env.hmr"],
+				expectedError:
+					"The options --release and --hmr cannot be used simultaneously.",
+			},
 		];
 
 		_.each(testCasesExpectingToThrow, (testCase) => {
@@ -341,14 +347,29 @@ describe("options", () => {
 		describe("hmr option", () => {
 			const testCases = [
 				{
-					name: "should set hmr to true by default",
+					name: "should set hmr to false by default",
+					expectedHmrValue: false,
+				},
+				{
+					name: "should set hmr to true when --hmr is provided",
+					args: ["--hmr"],
 					expectedHmrValue: true,
 				},
 				{
 					name: "should set hmr to false when --no-hmr is provided",
 					args: ["--no-hmr"],
 					expectedHmrValue: false,
 				},
+				{
+					name: "should set hmr to true when --env.hmr is provided",
+					args: ["--env.hmr"],
+					expectedHmrValue: true,
+				},
+				{
+					name: "should keep hmr disabled when --no-hmr and --env.hmr are provided",
+					args: ["--no-hmr", "--env.hmr"],
+					expectedHmrValue: false,
+				},
 				{
 					name:
 						"should set hmr to false when provided through dashed options from command",