[MIG] mis_builder: Migration to 19.0

Author: Qlasta

.pre-commit-config.yaml

@@ -1,7 +1,6 @@
 exclude: |
   (?x)
   # NOT INSTALLABLE ADDONS
-  ^mis_builder/|
   ^mis_builder_budget/|
   ^mis_builder_demo/|
   # END NOT INSTALLABLE ADDONS

mis_builder/README.rst

@@ -21,13 +21,13 @@ MIS Builder
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fmis--builder-lightgray.png?logo=github
-    :target: https://github.com/OCA/mis-builder/tree/18.0/mis_builder
+    :target: https://github.com/OCA/mis-builder/tree/19.0/mis_builder
     :alt: OCA/mis-builder
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/mis-builder-18-0/mis-builder-18-0-mis_builder
+    :target: https://translation.odoo-community.org/projects/mis-builder-19-0/mis-builder-19-0-mis_builder
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/mis-builder&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/mis-builder&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -723,7 +723,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/mis-builder/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/mis-builder/issues/new?body=module:%20mis_builder%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/mis-builder/issues/new?body=module:%20mis_builder%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -790,6 +790,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-sbidoul| 
 
-This module is part of the `OCA/mis-builder <https://github.com/OCA/mis-builder/tree/18.0/mis_builder>`_ project on GitHub.
+This module is part of the `OCA/mis-builder <https://github.com/OCA/mis-builder/tree/19.0/mis_builder>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

mis_builder/__manifest__.py

@@ -3,12 +3,12 @@
 
 {
     "name": "MIS Builder",
-    "version": "18.0.1.8.0",
+    "version": "19.0.1.0.0",
     "category": "Reporting",
     "summary": """
         Build 'Management Information System' Reports and Dashboards
     """,
-    "author": "ACSONE SA/NV, " "Odoo Community Association (OCA)",
+    "author": "ACSONE SA/NV, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/mis-builder",
     "depends": [
         "account",
@@ -41,7 +41,7 @@
         ],
     },
     "qweb": ["static/src/xml/mis_report_widget.xml"],
-    "installable": False,
+    "installable": True,
     "application": True,
     "license": "AGPL-3",
     "development_status": "Production/Stable",

mis_builder/migrations/18.0.1.3.0/post-migration.py

@@ -7,7 +7,7 @@
 
 from odoo import fields
 from odoo.exceptions import UserError
-from odoo.models import expression
+from odoo.fields import Domain
 from odoo.tools.float_utils import float_is_zero
 from odoo.tools.safe_eval import datetime, dateutil, safe_eval, time
 
@@ -184,7 +184,7 @@ def _account_codes_to_domain(self, account_codes):
                 elems.append([("code", "=like", account_code)])
             else:
                 elems.append([("code", "=", account_code)])
-        return tuple(expression.OR(elems))
+        return tuple(Domain.OR(elems))
 
     def _parse_match_object(self, mo):
         """Split a match object corresponding to an accounting variable
@@ -285,7 +285,7 @@ def done_parsing(self):
                 # separately.
                 account_ids = []
                 for company in self.companies:
-                    acc_domain_with_company = expression.AND(
+                    acc_domain_with_company = Domain.AND(
                         [acc_domain, [("company_ids", "=", company.id)]]
                     )
                     account_ids += (
@@ -328,7 +328,7 @@ def get_aml_domain_for_expr(self, expr, date_from, date_to, account_id=None):
             account_ids = set()
             account_ids.update(self._account_ids_by_acc_domain[acc_domain])
             if not account_id:
-                aml_domain.append(("account_id", "in", tuple(account_ids)))
+                aml_domain.append(("account_id", "in", list(account_ids)))
             else:
                 # filter on account_id
                 if account_id in account_ids:
@@ -341,15 +341,17 @@ def get_aml_domain_for_expr(self, expr, date_from, date_to, account_id=None):
                 aml_domain.append(("debit", "<>", 0.0))
             elif fld_name:
                 aml_domain.append((fld_name, "!=", False))
-            aml_domains.append(expression.normalize_domain(aml_domain))
+            aml_domains.append(aml_domain)
             if mode not in date_domain_by_mode:
                 date_domain_by_mode[mode] = self.get_aml_domain_for_dates(
                     date_from, date_to, mode
                 )
         assert aml_domains
         # TODO we could do this for more precision:
         #      AND(OR(aml_domains[mode]), date_domain[mode]) for each mode
-        return expression.OR(aml_domains) + expression.OR(date_domain_by_mode.values())
+        return Domain.AND(
+            [Domain.OR(aml_domains), Domain.OR(list(date_domain_by_mode.values()))]
+        )
 
     def get_aml_domain_for_dates(self, date_from, date_to, mode):
         if mode == self.MODE_VARIATION:
@@ -384,7 +386,7 @@ def get_aml_domain_for_dates(self, date_from, date_to, mode):
                 ("date", "<", fields.Date.to_string(fy_date_from)),
                 ("account_id.include_initial_balance", "=", False),
             ]
-        return expression.normalize_domain(domain)
+        return Domain(domain)
 
     def _get_company_rates(self, date):
         # get exchange rates for each company with its rouding

mis_builder/models/aep.py

@@ -5,7 +5,7 @@
 
 from odoo import api, fields, models
 from odoo.exceptions import UserError
-from odoo.osv import expression
+from odoo.fields import Domain
 
 ACC_SUM = "sum"
 ACC_AVG = "avg"
@@ -79,7 +79,7 @@ def _query_kpi_data(self, date_from, date_to, base_domain):
         dt_to = fields.Date.from_string(date_to)
         # all data items within or overlapping [date_from, date_to]
         date_domain = [("date_from", "<=", date_to), ("date_to", ">=", date_from)]
-        domain = expression.AND([date_domain, base_domain])
+        domain = Domain(date_domain) & Domain(base_domain)
         res = defaultdict(float)
         res_avg = defaultdict(list)
         for item in self.search(domain):

mis_builder/models/mis_kpi_data.py

@@ -13,6 +13,7 @@
 
 from odoo import api, fields, models
 from odoo.exceptions import UserError, ValidationError
+from odoo.fields import Domain
 from odoo.tools.safe_eval import (
     datetime as safe_datetime,
 )
@@ -292,13 +293,10 @@ class MisReportKpiExpression(models.Model):
     # TODO FIXME set readonly=True when onchange('subkpi_ids') below works
     subkpi_id = fields.Many2one("mis.report.subkpi", readonly=False, ondelete="cascade")
 
-    _sql_constraints = [
-        (
-            "subkpi_kpi_unique",
-            "unique(subkpi_id, kpi_id)",
-            "Sub KPI must be used once and only once for each KPI",
-        )
-    ]
+    _subkpi_kpi_unique = models.Constraint(
+        "unique(subkpi_id, kpi_id)",
+        "Sub KPI must be used once and only once for each KPI",
+    )
 
     @api.depends(
         "kpi_id.description",
@@ -324,22 +322,18 @@ def _compute_display_name(self):
     def _search_display_name(self, operator, value):
         if "." in value:
             kpi_name, subkpi_name = value.split(".", 1)
-            name_search_domain = [
-                "|",
-                "|",
-                "&",
-                ("kpi_id.name", "=", kpi_name),
-                ("subkpi_id.name", operator, subkpi_name),
-                ("kpi_id.description", operator, value),
-                ("subkpi_id.description", operator, value),
-            ]
+            name_search_domain = (
+                (
+                    Domain("kpi_id.name", "=", kpi_name)
+                    & Domain("subkpi_id.name", operator, subkpi_name)
+                )
+                | Domain("kpi_id.description", operator, value)
+                | Domain("subkpi_id.description", operator, value)
+            )
         else:
-            name_search_domain = [
-                "|",
-                ("kpi_id.name", operator, value),
-                ("kpi_id.description", operator, value),
-            ]
-
+            name_search_domain = Domain("kpi_id.name", operator, value) | Domain(
+                "kpi_id.description", operator, value
+            )
         return name_search_domain
 
 
@@ -619,7 +613,7 @@ def _fetch_queries(self, date_from, date_to, get_additional_query_filter=None):
                         v = data[0][field_name]
                     except KeyError:
                         _logger.error(
-                            "field %s not found in read_group " "for %s; not summable?",
+                            "field %s not found in read_group for %s; not summable?",
                             field_name,
                             model._name,
                         )

mis_builder/models/mis_report.py

@@ -10,6 +10,7 @@
 
 from odoo import api, fields, models
 from odoo.exceptions import UserError, ValidationError
+from odoo.fields import Domain
 
 from .aep import AccountingExpressionProcessor as AEP
 from .expression_evaluator import ExpressionEvaluator
@@ -289,19 +290,20 @@ def _compute_dates(self):
 
     _order = "sequence, id"
 
-    _sql_constraints = [
-        ("duration", "CHECK (duration>0)", "Wrong duration, it must be positive!"),
-        (
-            "normalize_factor",
-            "CHECK (normalize_factor>0)",
-            "Wrong normalize factor, it must be positive!",
-        ),
-        (
-            "name_unique",
-            "unique(name, report_instance_id)",
-            "Period name should be unique by report",
-        ),
-    ]
+    _duration = models.Constraint(
+        "CHECK(duration > 0)",
+        "Wrong duration, it must be positive!",
+    )
+
+    _normalize_factor = models.Constraint(
+        "CHECK(normalize_factor > 0)",
+        "Wrong normalize factor, it must be positive!",
+    )
+
+    _name_unique = models.Constraint(
+        "unique(name, report_instance_id)",
+        "Period name should be unique by report",
+    )
 
     @api.depends("source", "report_instance_id.report_id.move_lines_source")
     def _compute_source_aml_model_id(self):
@@ -423,17 +425,15 @@ def _check_mode_source(self):
                 if rec.mode == MODE_NONE:
                     raise DateFilterRequired(
                         self.env._(
-                            "A date filter is mandatory for this source "
-                            "in column %s.",
+                            "A date filter is mandatory for this source in column %s.",
                             rec.name,
                         )
                     )
             elif rec.source in (SRC_SUMCOL, SRC_CMPCOL):
                 if rec.mode != MODE_NONE:
                     raise DateFilterForbidden(
                         self.env._(
-                            "No date filter is allowed for this source "
-                            "in column %s.",
+                            "No date filter is allowed for this source in column %s.",
                             rec.name,
                         )
                     )
@@ -460,8 +460,7 @@ def _check_source_cmpcol(self):
                 ):
                     raise ValidationError(
                         self.env._(
-                            "Columns to compare must belong to the same report "
-                            "in %s",
+                            "Columns to compare must belong to the same report in %s",
                             rec.name,
                         )
                     )
@@ -499,7 +498,7 @@ def _compute_pivot_date(self):
     sequence = fields.Integer(default=10)
     description = fields.Char(related="report_id.description")
     date = fields.Date(
-        string="Base date", help="Report base date " "(leave empty to use current date)"
+        string="Base date", help="Report base date (leave empty to use current date)"
     )
     pivot_date = fields.Date(compute="_compute_pivot_date")
     report_id = fields.Many2one("mis.report", required=True, string="Report")
@@ -765,9 +764,7 @@ def get_views(self, views, options=None):
             context.get("from_dashboard")
             and context.get("active_model") == "mis.report.instance"
         ):
-            view_id = self.env.ref(
-                "mis_builder." "mis_report_instance_result_view_form"
-            )
+            view_id = self.env.ref("mis_builder.mis_report_instance_result_view_form")
             mis_report_form_view = view_id and [view_id.id, "form"]
             for view in views:
                 if view and view[1] == "form":
@@ -778,7 +775,7 @@ def get_views(self, views, options=None):
 
     def preview(self):
         self.ensure_one()
-        view_id = self.env.ref("mis_builder." "mis_report_instance_result_view_form")
+        view_id = self.env.ref("mis_builder.mis_report_instance_result_view_form")
         return {
             "type": "ir.actions.act_window",
             "res_model": "mis.report.instance",
@@ -980,7 +977,9 @@ def drilldown(self, arg):
                 period.date_to,
                 account_id,
             )
-            domain.extend(period._get_additional_move_line_filter())
+            additional_domain = period._get_additional_move_line_filter()
+            if additional_domain:
+                domain = Domain.AND([domain, additional_domain])
             views = self._get_drilldown_model_views(period.source_aml_model_name)
             return {
                 "name": self._get_drilldown_action_name(arg),