Skip to content

Commit 50cca17

Browse files
committed
[Swift6] Remove QueryStringEncodable for models
1 parent 28daa68 commit 50cca17

413 files changed

Lines changed: 442 additions & 610 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

modules/openapi-generator/src/main/resources/swift6/Extensions.mustache

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,6 @@ import FoundationNetworking
1111
@preconcurrency import PromiseKit{{/usePromiseKit}}{{#useVapor}}
1212
import Vapor{{/useVapor}}{{^useVapor}}
1313

14-
extension QueryStringEncodable {
15-
@_disfavoredOverload
16-
func encodeToQueryString(codableHelper: CodableHelper) -> String { String(describing: self) }
17-
}
18-
1914
extension Bool: QueryStringEncodable {
2015
func encodeToQueryString(codableHelper: CodableHelper) -> String { String(describing: self) }
2116
}
@@ -57,7 +52,9 @@ extension UUID: QueryStringEncodable {
5752
}
5853

5954
extension RawRepresentable where RawValue: QueryStringEncodable {
60-
func encodeToQueryString(codableHelper: CodableHelper) -> String { String(describing: rawValue) }
55+
func encodeToQueryString(codableHelper: CodableHelper) -> String {
56+
rawValue.encodeToQueryString(codableHelper: codableHelper)
57+
}
6158
}
6259

6360
private func encodeIfPossible<T>(_ object: T, codableHelper: CodableHelper) -> String {
@@ -100,15 +97,6 @@ extension Date: QueryStringEncodable {
10097
func encodeToQueryString(codableHelper: CodableHelper) -> String {
10198
return codableHelper.dateFormatter.string(from: self)
10299
}
103-
}
104-
105-
extension QueryStringEncodable where Self: Encodable {
106-
func encodeToQueryString(codableHelper: CodableHelper) -> String {
107-
guard let data = try? codableHelper.jsonEncoder.encode(self) else {
108-
fatalError("Could not encode to json: \(self)")
109-
}
110-
return data.encodeToQueryString(codableHelper: codableHelper)
111-
}
112100
}{{/useVapor}}{{#generateModelAdditionalProperties}}
113101

114102
extension String: @retroactive CodingKey {

modules/openapi-generator/src/main/resources/swift6/modelObject.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
{{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{{classname}}}: {{^useClasses}}Sendable, {{/useClasses}}{{#useClasses}}{{#readonlyProperties}}@unchecked Sendable, {{/readonlyProperties}}{{/useClasses}}{{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable{{#useJsonEncodable}}, QueryStringEncodable{{/useJsonEncodable}}{{/useVapor}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}} {
2-
{{/objcCompatible}}{{#objcCompatible}}@objcMembers {{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} class {{classname}}: NSObject, Codable{{#useJsonEncodable}}, QueryStringEncodable{{/useJsonEncodable}} {
1+
{{^objcCompatible}}{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} {{#useClasses}}final class{{/useClasses}}{{^useClasses}}struct{{/useClasses}} {{{classname}}}: {{^useClasses}}Sendable, {{/useClasses}}{{#useClasses}}{{#readonlyProperties}}@unchecked Sendable, {{/readonlyProperties}}{{/useClasses}}{{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable{{/useVapor}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}} {
2+
{{/objcCompatible}}{{#objcCompatible}}@objcMembers {{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} class {{classname}}: NSObject, Codable {
33
{{/objcCompatible}}
44

55
{{#allVars}}

modules/openapi-generator/src/main/resources/swift6/modelOneOf.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} enum {{classname}}: {{^useClasses}}Sendable, {{/useClasses}}{{#useClasses}}{{#readonlyProperties}}Sendable, {{/readonlyProperties}}{{/useClasses}}{{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable{{#useJsonEncodable}}, QueryStringEncodable{{/useJsonEncodable}}{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}}{{/useVapor}} {
1+
{{#nonPublicApi}}internal{{/nonPublicApi}}{{^nonPublicApi}}public{{/nonPublicApi}} enum {{classname}}: {{^useClasses}}Sendable, {{/useClasses}}{{#useClasses}}{{#readonlyProperties}}Sendable, {{/readonlyProperties}}{{/useClasses}}{{#useVapor}}Content{{/useVapor}}{{^useVapor}}Codable{{#vendorExtensions.x-swift-hashable}}, Hashable{{/vendorExtensions.x-swift-hashable}}{{/useVapor}} {
22
{{#oneOf}}
33
case type{{#transformArrayType}}{{.}}{{/transformArrayType}}({{.}})
44
{{/oneOf}}

samples/client/petstore/swift6/alamofireLibrary/Sources/PetstoreClient/Infrastructure/Extensions.swift

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ import Foundation
99
import FoundationNetworking
1010
#endif
1111

12-
extension QueryStringEncodable {
13-
@_disfavoredOverload
14-
func encodeToQueryString(codableHelper: CodableHelper) -> String { String(describing: self) }
15-
}
16-
1712
extension Bool: QueryStringEncodable {
1813
func encodeToQueryString(codableHelper: CodableHelper) -> String { String(describing: self) }
1914
}
@@ -55,7 +50,9 @@ extension UUID: QueryStringEncodable {
5550
}
5651

5752
extension RawRepresentable where RawValue: QueryStringEncodable {
58-
func encodeToQueryString(codableHelper: CodableHelper) -> String { String(describing: rawValue) }
53+
func encodeToQueryString(codableHelper: CodableHelper) -> String {
54+
rawValue.encodeToQueryString(codableHelper: codableHelper)
55+
}
5956
}
6057

6158
private func encodeIfPossible<T>(_ object: T, codableHelper: CodableHelper) -> String {
@@ -100,15 +97,6 @@ extension Date: QueryStringEncodable {
10097
}
10198
}
10299

103-
extension QueryStringEncodable where Self: Encodable {
104-
func encodeToQueryString(codableHelper: CodableHelper) -> String {
105-
guard let data = try? codableHelper.jsonEncoder.encode(self) else {
106-
fatalError("Could not encode to json: \(self)")
107-
}
108-
return data.encodeToQueryString(codableHelper: codableHelper)
109-
}
110-
}
111-
112100
extension String: @retroactive CodingKey {
113101

114102
public var stringValue: String {

samples/client/petstore/swift6/alamofireLibrary/Sources/PetstoreClient/Models/AdditionalPropertiesClass.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import Foundation
99

10-
public struct AdditionalPropertiesClass: Sendable, Codable, QueryStringEncodable, Hashable {
10+
public struct AdditionalPropertiesClass: Sendable, Codable, Hashable {
1111

1212
public var mapString: [String: String]?
1313
public var mapMapString: [String: [String: String]]?

samples/client/petstore/swift6/alamofireLibrary/Sources/PetstoreClient/Models/Animal.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import Foundation
99

10-
public struct Animal: Sendable, Codable, QueryStringEncodable, Hashable {
10+
public struct Animal: Sendable, Codable, Hashable {
1111

1212
public var className: String
1313
public var color: String? = "red"

samples/client/petstore/swift6/alamofireLibrary/Sources/PetstoreClient/Models/ApiResponse.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import Foundation
99

10-
public struct ApiResponse: Sendable, Codable, QueryStringEncodable, Hashable {
10+
public struct ApiResponse: Sendable, Codable, Hashable {
1111

1212
public var code: Int?
1313
public var type: String?

samples/client/petstore/swift6/alamofireLibrary/Sources/PetstoreClient/Models/ArrayOfArrayOfNumberOnly.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import Foundation
99

10-
public struct ArrayOfArrayOfNumberOnly: Sendable, Codable, QueryStringEncodable, Hashable {
10+
public struct ArrayOfArrayOfNumberOnly: Sendable, Codable, Hashable {
1111

1212
public var arrayArrayNumber: [[Double]]?
1313

samples/client/petstore/swift6/alamofireLibrary/Sources/PetstoreClient/Models/ArrayOfNumberOnly.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import Foundation
99

10-
public struct ArrayOfNumberOnly: Sendable, Codable, QueryStringEncodable, Hashable {
10+
public struct ArrayOfNumberOnly: Sendable, Codable, Hashable {
1111

1212
public var arrayNumber: [Double]?
1313

samples/client/petstore/swift6/alamofireLibrary/Sources/PetstoreClient/Models/ArrayTest.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import Foundation
99

10-
public struct ArrayTest: Sendable, Codable, QueryStringEncodable, Hashable {
10+
public struct ArrayTest: Sendable, Codable, Hashable {
1111

1212
public var arrayOfString: [String]?
1313
public var arrayArrayOfInteger: [[Int64]]?

0 commit comments

Comments
 (0)