fix(kotlin-spring): use Jackson 3 annotation package in model imports

yonatankarp · yonatankarp · commit bb12527020c5 · 2026-04-01T10:52:13.000+02:00
When useJackson3=true, generated model source files still imported from
com.fasterxml.jackson.annotation (Jackson 2). The importMapping in
KotlinSpringServerCodegen was hardcoded to the Jackson 2 package.

Now derives the annotation package from the useJackson3 flag, consistent
with how build files already handled it. Also adds the missing
tools.jackson.core:jackson-annotations dependency to all Spring Boot 4
build templates and fixes the hardcoded YAMLMapper import in
homeController.mustache.
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java
@@ -492,15 +492,16 @@ public void processOpts() {
         importMapping.put("ApiModelProperty", "io.swagger.annotations.ApiModelProperty");
 
         // Jackson import mappings
-        importMapping.put("JsonValue", "com.fasterxml.jackson.annotation.JsonValue");
-        importMapping.put("JsonCreator", "com.fasterxml.jackson.annotation.JsonCreator");
-        importMapping.put("JsonProperty", "com.fasterxml.jackson.annotation.JsonProperty");
-        importMapping.put("JsonSubTypes", "com.fasterxml.jackson.annotation.JsonSubTypes");
-        importMapping.put("JsonTypeInfo", "com.fasterxml.jackson.annotation.JsonTypeInfo");
-        importMapping.put("JsonIgnoreProperties", "com.fasterxml.jackson.annotation.JsonIgnoreProperties");
+        String jacksonAnnotationPkg = isUseJackson3() ? JACKSON3_PACKAGE : JACKSON2_PACKAGE;
+        importMapping.put("JsonValue", jacksonAnnotationPkg + ".annotation.JsonValue");
+        importMapping.put("JsonCreator", jacksonAnnotationPkg + ".annotation.JsonCreator");
+        importMapping.put("JsonProperty", jacksonAnnotationPkg + ".annotation.JsonProperty");
+        importMapping.put("JsonSubTypes", jacksonAnnotationPkg + ".annotation.JsonSubTypes");
+        importMapping.put("JsonTypeInfo", jacksonAnnotationPkg + ".annotation.JsonTypeInfo");
+        importMapping.put("JsonIgnoreProperties", jacksonAnnotationPkg + ".annotation.JsonIgnoreProperties");
         // import JsonCreator if JsonProperty is imported
         // used later in recursive import in postProcessingModels
-        importMapping.put("com.fasterxml.jackson.annotation.JsonProperty", "com.fasterxml.jackson.annotation.JsonCreator");
+        importMapping.put(jacksonAnnotationPkg + ".annotation.JsonProperty", jacksonAnnotationPkg + ".annotation.JsonCreator");
 
         if (isUseJackson3()) {
             // Override databind imports for Jackson 3
diff --git a/modules/openapi-generator/src/main/resources/kotlin-spring/homeController.mustache b/modules/openapi-generator/src/main/resources/kotlin-spring/homeController.mustache
@@ -4,7 +4,7 @@ import org.springframework.context.annotation.Bean
 import org.springframework.stereotype.Controller
 import org.springframework.web.bind.annotation.RequestMapping
 {{#sourceDocumentationProvider}}
-import com.fasterxml.jackson.dataformat.yaml.YAMLMapper
+import {{jacksonPackage}}.dataformat.yaml.YAMLMapper
 import org.springframework.beans.factory.annotation.Value
 import org.springframework.core.io.Resource
 import org.springframework.util.StreamUtils
diff --git a/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-boot/buildGradle-sb4-Kts.mustache b/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-boot/buildGradle-sb4-Kts.mustache
@@ -46,6 +46,7 @@ dependencies {
 
     implementation("com.google.code.findbugs:jsr305:3.0.2")
 {{#useJackson3}}
+    implementation("tools.jackson.core:jackson-annotations")
     implementation("tools.jackson.dataformat:jackson-dataformat-yaml")
     implementation("tools.jackson.dataformat:jackson-dataformat-xml")
     implementation("tools.jackson.module:jackson-module-kotlin")
diff --git a/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-boot/pom-sb4.mustache b/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-boot/pom-sb4.mustache
@@ -158,6 +158,12 @@
             <artifactId>jsr305</artifactId>
             <version>${findbugs-jsr305.version}</version>
         </dependency>
+{{#useJackson3}}
+        <dependency>
+            <groupId>{{jacksonPackage}}.core</groupId>
+            <artifactId>jackson-annotations</artifactId>
+        </dependency>
+{{/useJackson3}}
         <dependency>
             <groupId>{{jacksonPackage}}.dataformat</groupId>
             <artifactId>jackson-dataformat-yaml</artifactId>
diff --git a/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-cloud/buildGradle-sb4-Kts.mustache b/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-cloud/buildGradle-sb4-Kts.mustache
@@ -54,6 +54,7 @@ dependencies {
 
     implementation("com.google.code.findbugs:jsr305:3.0.2")
 {{#useJackson3}}
+    implementation("tools.jackson.core:jackson-annotations")
     implementation("tools.jackson.dataformat:jackson-dataformat-yaml")
     implementation("tools.jackson.dataformat:jackson-dataformat-xml")
     implementation("tools.jackson.module:jackson-module-kotlin")
diff --git a/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-cloud/pom-sb4.mustache b/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-cloud/pom-sb4.mustache
@@ -183,6 +183,12 @@
             <artifactId>spring-boot-starter-oauth2-client</artifactId>
         </dependency>
         {{/hasAuthMethods}}
+{{#useJackson3}}
+        <dependency>
+            <groupId>{{jacksonPackage}}.core</groupId>
+            <artifactId>jackson-annotations</artifactId>
+        </dependency>
+{{/useJackson3}}
         <dependency>
             <groupId>{{jacksonPackage}}.dataformat</groupId>
             <artifactId>jackson-dataformat-yaml</artifactId>
diff --git a/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-declarative-http-interface/buildGradle-sb4-Kts.mustache b/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-declarative-http-interface/buildGradle-sb4-Kts.mustache
@@ -54,6 +54,7 @@ dependencies {
 
     implementation("com.google.code.findbugs:jsr305:3.0.2")
 {{#useJackson3}}
+    implementation("tools.jackson.core:jackson-annotations")
     implementation("tools.jackson.dataformat:jackson-dataformat-yaml")
     implementation("tools.jackson.dataformat:jackson-dataformat-xml")
     implementation("tools.jackson.module:jackson-module-kotlin")
diff --git a/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-declarative-http-interface/pom-sb4.mustache b/modules/openapi-generator/src/main/resources/kotlin-spring/libraries/spring-declarative-http-interface/pom-sb4.mustache
@@ -179,6 +179,12 @@
             <artifactId>spring-boot-starter-oauth2-client</artifactId>
         </dependency>
         {{/hasAuthMethods}}
+{{#useJackson3}}
+        <dependency>
+            <groupId>{{jacksonPackage}}.core</groupId>
+            <artifactId>jackson-annotations</artifactId>
+        </dependency>
+{{/useJackson3}}
         <dependency>
             <groupId>{{jacksonPackage}}.dataformat</groupId>
             <artifactId>jackson-dataformat-yaml</artifactId>
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java
@@ -4825,6 +4825,42 @@ public void shouldGenerateSpringBoot4PomWithJackson3Deps() throws IOException {
         assertFileNotContains(pomPath, "com.fasterxml.jackson.module");
     }
 
+    @Test
+    public void shouldGenerateJackson3AnnotationImportsInModels() throws IOException {
+        File output = Files.createTempDirectory("test").toFile().getCanonicalFile();
+        output.deleteOnExit();
+        String outputPath = output.getAbsolutePath().replace('\\', '/');
+
+        final OpenAPI openAPI = TestUtils.parseFlattenSpec("src/test/resources/3_0/petstore.yaml");
+        final KotlinSpringServerCodegen codegen = new KotlinSpringServerCodegen();
+        codegen.setOpenAPI(openAPI);
+        codegen.setOutputDir(output.getAbsolutePath());
+
+        codegen.additionalProperties().put(KotlinSpringServerCodegen.USE_SPRING_BOOT4, "true");
+        codegen.additionalProperties().put(AbstractKotlinCodegen.USE_JACKSON_3, "true");
+        codegen.additionalProperties().put(DOCUMENTATION_PROVIDER, DocumentationProvider.NONE.toCliOptValue());
+        codegen.additionalProperties().put(ANNOTATION_LIBRARY, AnnotationLibrary.NONE.toCliOptValue());
+
+        ClientOptInput input = new ClientOptInput();
+        input.openAPI(openAPI);
+        input.config(codegen);
+
+        DefaultGenerator generator = new DefaultGenerator();
+        generator.setGenerateMetadata(false);
+        generator.opts(input).generate();
+
+        // Model files must use Jackson 3 annotation package
+        Path petModelPath = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/model/Pet.kt");
+        assertFileContains(petModelPath, "tools.jackson.annotation.JsonProperty");
+        assertFileNotContains(petModelPath, "com.fasterxml.jackson.annotation");
+
+        // Enum model with @JsonValue/@JsonCreator must also use Jackson 3
+        Path orderModelPath = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/model/Order.kt");
+        assertFileContains(orderModelPath, "tools.jackson.annotation.JsonValue");
+        assertFileContains(orderModelPath, "tools.jackson.annotation.JsonCreator");
+        assertFileNotContains(orderModelPath, "com.fasterxml.jackson.annotation");
+    }
+
     @Test
     public void shouldDefaultToJackson3WhenSpringBoot4Enabled() throws IOException {
         File output = Files.createTempDirectory("test").toFile().getCanonicalFile();
diff --git a/samples/server/petstore/kotlin-springboot-4/build.gradle.kts b/samples/server/petstore/kotlin-springboot-4/build.gradle.kts
@@ -29,6 +29,7 @@ dependencies {
         implementation("org.springframework.boot:spring-boot-starter-webmvc")
 
     implementation("com.google.code.findbugs:jsr305:3.0.2")
+    implementation("tools.jackson.core:jackson-annotations")
     implementation("tools.jackson.dataformat:jackson-dataformat-yaml")
     implementation("tools.jackson.dataformat:jackson-dataformat-xml")
     implementation("tools.jackson.module:jackson-module-kotlin")
diff --git a/samples/server/petstore/kotlin-springboot-4/pom.xml b/samples/server/petstore/kotlin-springboot-4/pom.xml
@@ -98,6 +98,10 @@
             <artifactId>jsr305</artifactId>
             <version>${findbugs-jsr305.version}</version>
         </dependency>
+        <dependency>
+            <groupId>tools.jackson.core</groupId>
+            <artifactId>jackson-annotations</artifactId>
+        </dependency>
         <dependency>
             <groupId>tools.jackson.dataformat</groupId>
             <artifactId>jackson-dataformat-yaml</artifactId>
diff --git a/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/Category.kt b/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/Category.kt
@@ -1,7 +1,7 @@
 package org.openapitools.model
 
 import java.util.Objects
-import com.fasterxml.jackson.annotation.JsonProperty
+import tools.jackson.annotation.JsonProperty
 import jakarta.validation.constraints.DecimalMax
 import jakarta.validation.constraints.DecimalMin
 import jakarta.validation.constraints.Email
diff --git a/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/ModelApiResponse.kt b/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/ModelApiResponse.kt
@@ -1,7 +1,7 @@
 package org.openapitools.model
 
 import java.util.Objects
-import com.fasterxml.jackson.annotation.JsonProperty
+import tools.jackson.annotation.JsonProperty
 import jakarta.validation.constraints.DecimalMax
 import jakarta.validation.constraints.DecimalMin
 import jakarta.validation.constraints.Email
diff --git a/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/Order.kt b/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/Order.kt
@@ -1,9 +1,9 @@
 package org.openapitools.model
 
 import java.util.Objects
-import com.fasterxml.jackson.annotation.JsonCreator
-import com.fasterxml.jackson.annotation.JsonProperty
-import com.fasterxml.jackson.annotation.JsonValue
+import tools.jackson.annotation.JsonCreator
+import tools.jackson.annotation.JsonProperty
+import tools.jackson.annotation.JsonValue
 import jakarta.validation.constraints.DecimalMax
 import jakarta.validation.constraints.DecimalMin
 import jakarta.validation.constraints.Email
diff --git a/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/Pet.kt b/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/Pet.kt
@@ -1,11 +1,11 @@
 package org.openapitools.model
 
 import java.util.Objects
-import com.fasterxml.jackson.annotation.JsonCreator
-import com.fasterxml.jackson.annotation.JsonProperty
-import com.fasterxml.jackson.annotation.JsonValue
 import org.openapitools.model.Category
 import org.openapitools.model.Tag
+import tools.jackson.annotation.JsonCreator
+import tools.jackson.annotation.JsonProperty
+import tools.jackson.annotation.JsonValue
 import jakarta.validation.constraints.DecimalMax
 import jakarta.validation.constraints.DecimalMin
 import jakarta.validation.constraints.Email
diff --git a/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/Tag.kt b/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/Tag.kt
@@ -1,7 +1,7 @@
 package org.openapitools.model
 
 import java.util.Objects
-import com.fasterxml.jackson.annotation.JsonProperty
+import tools.jackson.annotation.JsonProperty
 import jakarta.validation.constraints.DecimalMax
 import jakarta.validation.constraints.DecimalMin
 import jakarta.validation.constraints.Email
diff --git a/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/User.kt b/samples/server/petstore/kotlin-springboot-4/src/main/kotlin/org/openapitools/model/User.kt
@@ -1,7 +1,7 @@
 package org.openapitools.model
 
 import java.util.Objects
-import com.fasterxml.jackson.annotation.JsonProperty
+import tools.jackson.annotation.JsonProperty
 import jakarta.validation.constraints.DecimalMax
 import jakarta.validation.constraints.DecimalMin
 import jakarta.validation.constraints.Email
