Skip to content

Commit de36fc5

Browse files
committed
Fix tests
1 parent a8fd5e0 commit de36fc5

1 file changed

Lines changed: 29 additions & 19 deletions

File tree

modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java

Lines changed: 29 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4833,6 +4833,8 @@ public void testAllArgsConstructor_16797_REFACTOR_ALLOF_WITH_PROPERTIES_ONLY() t
48334833
.hasParameter("requestId").toConstructor()
48344834
.hasParameter("success").toConstructor()
48354835
.hasParameter("pageInfo")
4836+
.toConstructor()
4837+
.assertConstructorAnnotations().containsWithName("JsonCreator");
48364838
;
48374839
}
48384840

@@ -4895,6 +4897,7 @@ public void testAllArgsConstructor_defaultOrder_15796() throws IOException {
48954897
.hasParameter("name").toConstructor()
48964898
.hasParameter("type").toConstructor()
48974899
.hasParameter("hairType").toConstructor()
4900+
.assertConstructorAnnotations().containsWithName("JsonCreator");
48984901
;
48994902
}
49004903

@@ -4910,13 +4913,20 @@ public void generateAllArgsConstructor() throws IOException {
49104913
.assertConstructor("LocalDate", "String", "String")
49114914
.hasParameter("dateOfBirth").toConstructor()
49124915
.hasParameter("name").toConstructor()
4913-
.hasParameter("type").toConstructor();
4916+
.hasParameter("type").toConstructor()
4917+
.assertConstructorAnnotations().containsWithName("JsonCreator").toConstructor()
4918+
.toFileAssert()
4919+
.assertConstructor("String")
4920+
.assertConstructorAnnotations().doesNotContainWithName("JsonCreator").toConstructor();
49144921
JavaFileAssert.assertThat(files.get("Cat.java"))
49154922
.assertConstructor("Integer", "String", "LocalDate", "String", "String");
49164923

49174924
// test required constructor
49184925
JavaFileAssert.assertThat(files.get("Page.java"))
49194926
.assertConstructor("Integer")
4927+
.assertConstructorAnnotations().containsWithName("JsonCreator")
4928+
.toConstructor()
4929+
.assertConstructorAnnotations().containsWithName("JsonCreator").toConstructor()
49204930
.toFileAssert()
49214931
.fileContains("Constructor with only required parameters and all parameters");
49224932

@@ -5353,14 +5363,14 @@ public void shouldAnnotateNonRequiredFieldsAsNullable() throws IOException {
53535363
JavaFileAssert.assertThat(file)
53545364
.fileContains(
53555365
"public Item(" +
5356-
"String mandatoryName," +
5357-
" @Nullable String optionalDescription," +
5358-
" String optionalOneWithDefault," +
5359-
" String nullableStr," +
5360-
" List<String> mandatoryContainer," +
5361-
" List<String> optionalContainer," +
5362-
" List<String> optionalContainerWithDefault," +
5363-
" List<String> nullableContainer)"
5366+
"@JsonProperty(\"mandatoryName\") String mandatoryName," +
5367+
" @Nullable @JsonProperty(\"optionalDescription\") String optionalDescription," +
5368+
" @JsonProperty(\"optionalOneWithDefault\") String optionalOneWithDefault," +
5369+
" @JsonProperty(\"nullableStr\") String nullableStr," +
5370+
" @JsonProperty(\"mandatoryContainer\") List<String> mandatoryContainer," +
5371+
" @JsonProperty(\"optionalContainer\") List<String> optionalContainer," +
5372+
" @JsonProperty(\"optionalContainerWithDefault\") List<String> optionalContainerWithDefault," +
5373+
" @JsonProperty(\"nullableContainer\") List<String> nullableContainer)"
53645374
);
53655375
}
53665376

@@ -5388,10 +5398,10 @@ public void shouldAnnotateNonRequiredFieldsAsNullableWhenSetContainerDefaultToNu
53885398
.doesNotHaveAnnotation("Nullable");
53895399
JavaFileAssert.assertThat(file)
53905400
.fileContains(
5391-
", List<String> mandatoryContainer," +
5392-
" @Nullable List<String> optionalContainer," +
5393-
" List<String> optionalContainerWithDefault," +
5394-
" List<String> nullableContainer)"
5401+
", @JsonProperty(\"mandatoryContainer\") List<String> mandatoryContainer," +
5402+
" @Nullable @JsonProperty(\"optionalContainer\") List<String> optionalContainer," +
5403+
" @JsonProperty(\"optionalContainerWithDefault\") List<String> optionalContainerWithDefault," +
5404+
" @JsonProperty(\"nullableContainer\") List<String> nullableContainer)"
53955405
);
53965406
}
53975407

@@ -5419,8 +5429,8 @@ public void shouldNotAnnotateNonRequiredFieldsAsNullableWhileUseOptional() throw
54195429
.doesNotHaveAnnotation("Nullable");
54205430
JavaFileAssert.assertThat(file)
54215431
.fileContains(
5422-
"public Item(String mandatoryName, String optionalDescription," +
5423-
" String optionalOneWithDefault, String nullableStr"
5432+
"public Item(@JsonProperty(\"mandatoryName\") String mandatoryName, @JsonProperty(\"optionalDescription\") String optionalDescription," +
5433+
" @JsonProperty(\"optionalOneWithDefault\") String optionalOneWithDefault, @JsonProperty(\"nullableStr\") String nullableStr"
54245434
);
54255435
}
54265436

@@ -5462,10 +5472,10 @@ public void shouldAnnotateNonRequiredFieldsAsNullableWhileNotUsingOpenApiNullabl
54625472

54635473
JavaFileAssert.assertThat(file)
54645474
.fileContains(
5465-
" List<String> mandatoryContainer," +
5466-
" @Nullable List<String> optionalContainer," +
5467-
" List<String> optionalContainerWithDefault," +
5468-
" @Nullable List<String> nullableContainer)"
5475+
" @JsonProperty(\"mandatoryContainer\") List<String> mandatoryContainer," +
5476+
" @Nullable @JsonProperty(\"optionalContainer\") List<String> optionalContainer," +
5477+
" @JsonProperty(\"optionalContainerWithDefault\") List<String> optionalContainerWithDefault," +
5478+
" @Nullable @JsonProperty(\"nullableContainer\") List<String> nullableContainer)"
54695479
);
54705480
}
54715481

0 commit comments

Comments
 (0)