[BUG] [KOTLIN] Type with additionalProperties generates invalid code

[felixkrull-neuland]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

In 7.16.0, using the Kotlin client generator with the multiplatform library, openapi-generator generates invalid code for types that have additionalProperties: {}. It adds an additional set of parentheses to the HashMap constructor invocation which makes the code not compile:

data class Abc (
...
) : kotlin.collections.HashMap<String, kotlin.Any>()() {
...

openapi-generator version

7.16.0, this worked in 7.15.0. I tried with latest master, still happens.

OpenAPI declaration file content or url

gist. I removed url etc, but otherwise this is 1:1 the real file we have.

Generation Details

java -jar openapi-generator-cli.jar generate -g kotlin -i openapi-issue.json --library multiplatform -o generated --additional-properties dateLibrary=string

Steps to reproduce

1. generate code (Kotlin, client, multiplatform)
2. open generated/src/commonMain/kotlin/org/openapitools/client/models/ProblemDetails.kt
3. notice the invalid kotlin.collections.HashMap<String, kotlin.Any>()()

[jan-beszterda]

I have similar issue with kotlin generator run as Gradle task with OpenAPI generator version 7.15.0 and 7.16.0

When specification file includes ``"additionalProperties": {}or"additionalProperties": true` in a component schema, the generated code does not compile:

data class ComponentA(

    // properties

) : kotlin.collections.HashMap<String, kotlin.Any>()() {


}

[MasaHirano]

I am seeing the same issue with:

• OpenAPI Generator Gradle Plugin version: 7.16.0
• Generator name: kotlin
• Kotlin version: 2.2.20

[armond-avanes]

I'm still seeing this on the plugin version 7.20.0 for kotlin generator (Kotlin version 2.3.10).
@wing328 Any chance we can get a fix in near future (7.21.0 ?)?

[dmh002-politiet]

I made a test that reproduces the issue, will look into a possible fix, but others are welcome to contribute

[dmh002-politiet]

After some debugging, i see that the change was introduced in #21772 in data_class.mustache.
When additionalProperties: {}, it makes isMap=true which means we add ().
At the same time, when multiplatform=true, we add another set of ()

[dmh002-politiet]

I believe i have a fix.

[armond-avanes]

@dmh002-politiet Have you raised a PR for the fix?

UPDATE: Found it: #23103