From 8a363ee6d72e110dfede385cdee2af50e78acb05 Mon Sep 17 00:00:00 2001 From: Francesco Casella Date: Sat, 14 Feb 2026 16:41:20 +0100 Subject: [PATCH 1/8] Update repos.json --- repos.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/repos.json b/repos.json index d6e0608..b703a10 100644 --- a/repos.json +++ b/repos.json @@ -468,7 +468,8 @@ "names": ["ExternalMedia"], "zipfiles": { "3.3.2": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v3.3.2/ExternalMedia-3.3.2.zip", - "4.0.0": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.0.0/ExternalMedia-4.0.0.zip" + "4.0.0": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.0.0/ExternalMedia-4.0.0.zip", + "4.1.1": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.1.1/ExternalMedia-4.1.1.zip" }, "support": [ [">=3.3.2", "fullSupport"], From 975ac403eff47b13cd679938085a60acfa6d13f1 Mon Sep 17 00:00:00 2001 From: Adrian Pop Date: Sun, 29 Mar 2026 23:07:24 +0200 Subject: [PATCH 2/8] fix link to ExternalMedia zip version --- repos.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/repos.json b/repos.json index b703a10..5ec3c98 100644 --- a/repos.json +++ b/repos.json @@ -468,8 +468,8 @@ "names": ["ExternalMedia"], "zipfiles": { "3.3.2": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v3.3.2/ExternalMedia-3.3.2.zip", - "4.0.0": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.0.0/ExternalMedia-4.0.0.zip", - "4.1.1": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.1.1/ExternalMedia-4.1.1.zip" + "4.0.0": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.0.0/ExternalMedia-v4.0.0.zip", + "4.1.1": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.1.1/ExternalMedia-v4.1.1.zip" }, "support": [ [">=3.3.2", "fullSupport"], From d75f603c0c4899d28de48605ca1bdf29c6c9d3ca Mon Sep 17 00:00:00 2001 From: Adrian Pop Date: Sun, 29 Mar 2026 23:19:40 +0200 Subject: [PATCH 3/8] tell which zip file could not be downloaded --- ompackagemanager/updateinfo.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/ompackagemanager/updateinfo.py b/ompackagemanager/updateinfo.py index 7191d37..7d387e4 100755 --- a/ompackagemanager/updateinfo.py +++ b/ompackagemanager/updateinfo.py @@ -285,11 +285,15 @@ def main(): except FileNotFoundError: pass os.mkdir(repopath) - zipfilepath = repopath + "-" + tagName + ".zip" - with open(zipfilepath, 'wb') as fout: - fout.write(requests.get(sha, allow_redirects=True).content) - with zipfile.ZipFile(zipfilepath, 'r') as zip_ref: - zip_ref.extractall(repopath) + try: + zipfilepath = repopath + "-" + tagName + ".zip" + with open(zipfilepath, 'wb') as fout: + fout.write(requests.get(sha, allow_redirects=True).content) + with zipfile.ZipFile(zipfilepath, 'r') as zip_ref: + zip_ref.extractall(repopath) + except: + print("Failed to download or extract zip file from URL: %s" % zipfilepath) + raise else: gitrepo = getgitrepo(giturl, repopath + ".git") try: From 20f509873401ca4d8e42084d0f10a946c36ac3fd Mon Sep 17 00:00:00 2001 From: Adrian Pop Date: Sun, 29 Mar 2026 23:24:14 +0200 Subject: [PATCH 4/8] catch the proper exception --- ompackagemanager/updateinfo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ompackagemanager/updateinfo.py b/ompackagemanager/updateinfo.py index 7d387e4..d1cece6 100755 --- a/ompackagemanager/updateinfo.py +++ b/ompackagemanager/updateinfo.py @@ -291,7 +291,7 @@ def main(): fout.write(requests.get(sha, allow_redirects=True).content) with zipfile.ZipFile(zipfilepath, 'r') as zip_ref: zip_ref.extractall(repopath) - except: + except zipfile.BadZipfile: print("Failed to download or extract zip file from URL: %s" % zipfilepath) raise else: From d7de070a024c1fe9069b7175a2fa52249705eb7c Mon Sep 17 00:00:00 2001 From: Adrian Pop Date: Sun, 29 Mar 2026 23:32:53 +0200 Subject: [PATCH 5/8] display the failed to download URL --- ompackagemanager/updateinfo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ompackagemanager/updateinfo.py b/ompackagemanager/updateinfo.py index d1cece6..ec473cb 100755 --- a/ompackagemanager/updateinfo.py +++ b/ompackagemanager/updateinfo.py @@ -292,7 +292,7 @@ def main(): with zipfile.ZipFile(zipfilepath, 'r') as zip_ref: zip_ref.extractall(repopath) except zipfile.BadZipfile: - print("Failed to download or extract zip file from URL: %s" % zipfilepath) + print("Failed to download or extract zip file from URL: %s downloaded to %s" % (sha, zipfilepath)) raise else: gitrepo = getgitrepo(giturl, repopath + ".git") From a701f934e10c724c2cfea006265f35959d3249db Mon Sep 17 00:00:00 2001 From: Adrian Pop Date: Sun, 29 Mar 2026 23:36:12 +0200 Subject: [PATCH 6/8] formatting --- ompackagemanager/updateinfo.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ompackagemanager/updateinfo.py b/ompackagemanager/updateinfo.py index ec473cb..d0fcfac 100755 --- a/ompackagemanager/updateinfo.py +++ b/ompackagemanager/updateinfo.py @@ -292,7 +292,9 @@ def main(): with zipfile.ZipFile(zipfilepath, 'r') as zip_ref: zip_ref.extractall(repopath) except zipfile.BadZipfile: - print("Failed to download or extract zip file from URL: %s downloaded to %s" % (sha, zipfilepath)) + print( + "Failed to download or extract zip file from URL: %s downloaded to %s" % + (sha, zipfilepath)) raise else: gitrepo = getgitrepo(giturl, repopath + ".git") From b3359d119578d2455e9505a0335fcdf61d6cc05c Mon Sep 17 00:00:00 2001 From: Adrian Pop Date: Sun, 29 Mar 2026 23:40:17 +0200 Subject: [PATCH 7/8] formatting --- ompackagemanager/updateinfo.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ompackagemanager/updateinfo.py b/ompackagemanager/updateinfo.py index d0fcfac..d90d68e 100755 --- a/ompackagemanager/updateinfo.py +++ b/ompackagemanager/updateinfo.py @@ -293,7 +293,7 @@ def main(): zip_ref.extractall(repopath) except zipfile.BadZipfile: print( - "Failed to download or extract zip file from URL: %s downloaded to %s" % + "Failed to download or extract zip file from URL: %s downloaded to %s" % (sha, zipfilepath)) raise else: From d245bd9b442c877e16c5869cfe9a4210d30539dd Mon Sep 17 00:00:00 2001 From: Adrian Pop Date: Sun, 29 Mar 2026 23:44:02 +0200 Subject: [PATCH 8/8] proper url --- repos.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repos.json b/repos.json index 5ec3c98..a3043a0 100644 --- a/repos.json +++ b/repos.json @@ -468,7 +468,7 @@ "names": ["ExternalMedia"], "zipfiles": { "3.3.2": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v3.3.2/ExternalMedia-3.3.2.zip", - "4.0.0": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.0.0/ExternalMedia-v4.0.0.zip", + "4.0.0": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.0.0/ExternalMedia-4.0.0.zip", "4.1.1": "https://github.com/modelica-3rdparty/ExternalMedia/releases/download/v4.1.1/ExternalMedia-v4.1.1.zip" }, "support": [