Skip to content

Commit a2b105e

Browse files
committed
[ModelicaSystemDoE] simplify definition; use a Modelicasystem instance as argument
1 parent 93b7bac commit a2b105e

1 file changed

Lines changed: 15 additions & 25 deletions

File tree

OMPython/ModelicaSystem.py

Lines changed: 15 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,15 @@ def get_session(self) -> OMCSession:
464464
"""
465465
return self._session
466466

467+
def get_model_name(self) -> str:
468+
"""
469+
Return the defined model name.
470+
"""
471+
if not isinstance(self._model_name, str):
472+
raise ModelicaSystemError("No model name defined!")
473+
474+
return self._model_name
475+
467476
def set_command_line_options(self, command_line_option: str):
468477
"""
469478
Set the provided command line option via OMC setCommandLineOptions().
@@ -1960,15 +1969,8 @@ def run_doe():
19601969

19611970
def __init__(
19621971
self,
1963-
# data to be used for ModelicaSystem
1964-
model_file: Optional[str | os.PathLike] = None,
1965-
model_name: Optional[str] = None,
1966-
libraries: Optional[list[str | tuple[str, str]]] = None,
1967-
command_line_options: Optional[list[str]] = None,
1968-
variable_filter: Optional[str] = None,
1969-
work_directory: Optional[str | os.PathLike] = None,
1970-
omhome: Optional[str] = None,
1971-
session: Optional[OMCSession] = None,
1972+
# ModelicaSystem definition to use
1973+
mod: ModelicaSystem,
19721974
# simulation specific input
19731975
# TODO: add more settings (simulation options, input options, ...)
19741976
simargs: Optional[dict[str, Optional[str | dict[str, str] | numbers.Number]]] = None,
@@ -1981,23 +1983,11 @@ def __init__(
19811983
ModelicaSystem.simulate(). Additionally, the path to store the result files is needed (= resultpath) as well as
19821984
a list of parameters to vary for the Doe (= parameters). All possible combinations are considered.
19831985
"""
1984-
if model_name is None:
1985-
raise ModelicaSystemError("No model name provided!")
1986-
1987-
self._mod = ModelicaSystem(
1988-
command_line_options=command_line_options,
1989-
work_directory=work_directory,
1990-
omhome=omhome,
1991-
session=session,
1992-
)
1993-
self._mod.model(
1994-
model_file=model_file,
1995-
model_name=model_name,
1996-
libraries=libraries,
1997-
variable_filter=variable_filter,
1998-
)
1986+
if not isinstance(mod, ModelicaSystem):
1987+
raise ModelicaSystemError("Missing definition of ModelicaSystem!")
19991988

2000-
self._model_name = model_name
1989+
self._mod = mod
1990+
self._model_name = mod.get_model_name()
20011991

20021992
self._simargs = simargs
20031993

0 commit comments

Comments
 (0)