??? [ModelicaSystem] remove verbose - use logger.debug

Author: syntron

OMPython/ModelicaSystem.py

@@ -130,7 +130,6 @@ def __init__(
             commandLineOptions: Optional[str] = None,
             variableFilter: Optional[str] = None,
             customBuildDirectory: Optional[str | os.PathLike] = None,
-            verbose: bool = True,
             omhome: Optional[str] = None,
             session: Optional[OMCSessionBase] = None
             ):
@@ -157,7 +156,6 @@ def __init__(
             customBuildDirectory: Path to a directory to be used for temporary
               files like the model executable. If left unspecified, a tmp
               directory will be created.
-            verbose: If True, enable verbose logging.
             omhome: OPENMODELICAHOME value to be used when creating the OMC
               session.
             session: OMC session to be used. If unspecified, a new session
@@ -187,8 +185,6 @@ def __init__(
         self.linearstates = []  # linearization  states list
         self.tempdir = ""
 
-        self._verbose = verbose
-
         if session is not None:
             if not isinstance(session, OMCSessionZMQ):
                 raise ModelicaSystemError("Invalid session data provided!")
@@ -314,12 +310,13 @@ def _run_cmd(self, cmd: list, timeout: Optional[int] = None):
                                     timeout=timeout)
             stdout = cmdres.stdout.strip()
             stderr = cmdres.stderr.strip()
+
+            logger.debug("OM output for command %s:\n%s", cmd, stdout)
+
             if cmdres.returncode != 0:
                 raise ModelicaSystemError(f"Error running command {cmd}: nonzero return code")
             if stderr:
                 raise ModelicaSystemError(f"Error running command {cmd}: {stderr}")
-            if self._verbose and stdout:
-                logger.info("OM output for command %s:\n%s", cmd, stdout)
         except subprocess.TimeoutExpired:
             raise ModelicaSystemError(f"Timeout running command {repr(cmd)}")
         except Exception as ex:
@@ -335,8 +332,7 @@ def buildModel(self, variableFilter=None):
             varFilter = 'variableFilter=".*"'
         logger.debug("varFilter=%s", varFilter)
         buildModelResult = self.requestApi("buildModel", self.modelName, properties=varFilter)
-        if self._verbose:
-            logger.info("OM model build result: %s", buildModelResult)
+        logger.debug("OM model build result: %s", buildModelResult)
 
         self.xmlFile = pathlib.Path(buildModelResult[0]).parent / buildModelResult[1]
         self.xmlparse()
@@ -346,6 +342,9 @@ def sendExpression(self, expr, parsed=True):
             retval = self.getconn.sendExpression(expr, parsed)
         except OMCSessionException as ex:
             raise ModelicaSystemError(f"Error executing {repr(expr)}") from ex
+
+        logger.debug(f"Result of executing {repr(expr)}: {repr(retval)}")
+
         return retval
 
     # request to OMC
@@ -838,12 +837,10 @@ def setParameters(self, pvals):  # 14
     def isParameterChangeable(self, name, value):
         q = self.getQuantities(name)
         if q[0]["changeable"] == "false":
-            if self._verbose:
-                logger.info("setParameters() failed : It is not possible to set "
-                            f'the following signal "{name}", It seems to be structural, final, '
-                            "protected or evaluated or has a non-constant binding, use sendExpression("
-                            f"setParameterValue({self.modelName}, {name}, {value}), "
-                            "parsed=false) and rebuild the model using buildModel() API")
+            logger.verbose(f"setParameters() failed : It is not possible to set the following signal {repr(name)}. "
+                           "It seems to be structural, final, protected or evaluated or has a non-constant binding, "
+                           f"use sendExpression(\"setParameterValue({self.modelName}, {name}, {value})\", "
+                           "parsed=False) and rebuild the model using buildModel() API")
             return False
         return True