Skip to content

Commit b7c7fe6

Browse files
committed
fix issues with more incorrectly escaped values
1 parent f0cbe05 commit b7c7fe6

7 files changed

Lines changed: 11 additions & 11 deletions

File tree

  • modules/openapi-generator/src/main/resources/kotlin-client/libraries
  • samples/client/echo_api
    • kotlin-jvm-okhttp/src/main/kotlin/org/openapitools/client/apis
    • kotlin-jvm-spring-3-restclient/src/main/kotlin/org/openapitools/client/apis
    • kotlin-jvm-spring-3-webclient/src/main/kotlin/org/openapitools/client/apis

modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-okhttp/api.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ import {{packageName}}.infrastructure.Serializer
264264

265265
return RequestConfig(
266266
method = RequestMethod.{{httpMethod}},
267-
path = "{{{path}}}"{{#pathParams}}.replace("{"+"{{#lambda.escapeDollar}}{{baseName}}{{/lambda.escapeDollar}}"+"}", encodeURIComponent({{#isContainer}}{{paramName}}.joinToString(","){{/isContainer}}{{^isContainer}}{{{paramName}}}{{#isEnum}}{{^required}}?{{/required}}.value{{/isEnum}}.toString(){{/isContainer}})){{/pathParams}},
267+
path = "{{#lambda.escapeInNormalString}}{{{path}}}{{/lambda.escapeInNormalString}}"{{#pathParams}}.replace("{"+"{{#lambda.escapeDollar}}{{baseName}}{{/lambda.escapeDollar}}"+"}", encodeURIComponent({{#isContainer}}{{paramName}}.joinToString(","){{/isContainer}}{{^isContainer}}{{{paramName}}}{{#isEnum}}{{^required}}?{{/required}}.value{{/isEnum}}.toString(){{/isContainer}})){{/pathParams}},
268268
query = localVariableQuery,
269269
headers = localVariableHeaders,
270270
requiresAuthentication = {{#hasAuthMethods}}true{{/hasAuthMethods}}{{^hasAuthMethods}}false{{/hasAuthMethods}},

modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-restclient/api.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,13 @@ import {{packageName}}.infrastructure.*
127127

128128
val params = mutableMapOf<String, Any>(
129129
{{#pathParams}}
130-
"{{baseName}}" to {{#isContainer}}{{paramName}}.joinToString(","){{/isContainer}}{{^isContainer}}{{{paramName}}}{{#isEnum}}{{^required}}?{{/required}}.value{{/isEnum}}{{/isContainer}},
130+
"{{#lambda.escapeInNormalString}}{{baseName}}{{/lambda.escapeInNormalString}}" to {{#isContainer}}{{paramName}}.joinToString(","){{/isContainer}}{{^isContainer}}{{{paramName}}}{{#isEnum}}{{^required}}?{{/required}}.value{{/isEnum}}{{/isContainer}},
131131
{{/pathParams}}
132132
)
133133

134134
return RequestConfig(
135135
method = RequestMethod.{{httpMethod}},
136-
path = "{{{path}}}",
136+
path = "{{#lambda.escapeInNormalString}}{{{path}}}{{/lambda.escapeInNormalString}}",
137137
params = params,
138138
query = localVariableQuery,
139139
headers = localVariableHeaders,

modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-spring-webclient/api.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,13 @@ import {{packageName}}.infrastructure.*
129129

130130
val params = mutableMapOf<String, Any>(
131131
{{#pathParams}}
132-
"{{baseName}}" to {{#isContainer}}{{paramName}}.joinToString(","){{/isContainer}}{{^isContainer}}{{{paramName}}}{{#isEnum}}{{^required}}?{{/required}}.value{{/isEnum}}{{/isContainer}},
132+
"{{#lambda.escapeInNormalString}}{{baseName}}{{/lambda.escapeInNormalString}}" to {{#isContainer}}{{paramName}}.joinToString(","){{/isContainer}}{{^isContainer}}{{{paramName}}}{{#isEnum}}{{^required}}?{{/required}}.value{{/isEnum}}{{/isContainer}},
133133
{{/pathParams}}
134134
)
135135

136136
return RequestConfig(
137137
method = RequestMethod.{{httpMethod}},
138-
path = "{{{path}}}",
138+
path = "{{#lambda.escapeInNormalString}}{{{path}}}{{/lambda.escapeInNormalString}}",
139139
params = params,
140140
query = localVariableQuery,
141141
headers = localVariableHeaders,

modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-volley/api.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ import {{packageName}}.infrastructure.CollectionFormats.*
6363
// to make it easy to override with your own.
6464

6565
// create path and map variables
66-
val path = "{{{path}}}"{{#pathParams}}.replace("{" + "{{baseName}}" + "}", {{#isContainer}}{{paramName}}.joinToString(","){{/isContainer}}{{^isContainer}}IRequestFactory.escapeString({{{paramName}}}.toString()){{/isContainer}}){{/pathParams}}
66+
val path = "{{#lambda.escapeInNormalString}}{{{path}}}{{/lambda.escapeInNormalString}}"{{#pathParams}}.replace("{" + "{{#lambda.escapeInNormalString}}{{baseName}}{{/lambda.escapeInNormalString}}" + "}", {{#isContainer}}{{paramName}}.joinToString(","){{/isContainer}}{{^isContainer}}IRequestFactory.escapeString({{{paramName}}}.toString()){{/isContainer}}){{/pathParams}}
6767

6868
val formParams = mapOf<String, String>({{^formParams}}){{/formParams}}{{#formParams}}
6969
"{{baseName}}" to IRequestFactory.parameterToString({{paramName}}){{^-last}},{{/-last}}{{#-last}}

samples/client/echo_api/kotlin-jvm-okhttp/src/main/kotlin/org/openapitools/client/apis/EchoApi.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ open class EchoApi(basePath: kotlin.String = defaultBasePath, client: Call.Facto
125125

126126
return RequestConfig(
127127
method = RequestMethod.GET,
128-
path = "/echo/string-escaping/{$paramName}".replace("{"+"\$paramName"+"}", encodeURIComponent(dollarParamName.toString())),
128+
path = "/echo/string-escaping/{\$paramName}".replace("{"+"\$paramName"+"}", encodeURIComponent(dollarParamName.toString())),
129129
query = localVariableQuery,
130130
headers = localVariableHeaders,
131131
requiresAuthentication = false,

samples/client/echo_api/kotlin-jvm-spring-3-restclient/src/main/kotlin/org/openapitools/client/apis/EchoApi.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,12 @@ open class EchoApi(client: RestClient) : ApiClient(client) {
7070
localVariableHeaders["Accept"] = "text/plain"
7171

7272
val params = mutableMapOf<String, Any>(
73-
"$paramName" to dollarParamName,
73+
"\$paramName" to dollarParamName,
7474
)
7575

7676
return RequestConfig(
7777
method = RequestMethod.GET,
78-
path = "/echo/string-escaping/{$paramName}",
78+
path = "/echo/string-escaping/{\$paramName}",
7979
params = params,
8080
query = localVariableQuery,
8181
headers = localVariableHeaders,

samples/client/echo_api/kotlin-jvm-spring-3-webclient/src/main/kotlin/org/openapitools/client/apis/EchoApi.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@ open class EchoApi(client: WebClient) : ApiClient(client) {
7474
localVariableHeaders["Accept"] = "text/plain"
7575

7676
val params = mutableMapOf<String, Any>(
77-
"$paramName" to dollarParamName,
77+
"\$paramName" to dollarParamName,
7878
)
7979

8080
return RequestConfig(
8181
method = RequestMethod.GET,
82-
path = "/echo/string-escaping/{$paramName}",
82+
path = "/echo/string-escaping/{\$paramName}",
8383
params = params,
8484
query = localVariableQuery,
8585
headers = localVariableHeaders,

0 commit comments

Comments
 (0)