Skip to content

Commit 439645b

Browse files
fix: add packageManager back (pnpm v10 auto-adds it during install)
pnpm v10.33.0 auto-writes packageManager to package.json during install, which broke vp check. Pin it in the repo so the quality job sees a stable file. Test job strips it before setup-js runs.
1 parent 7d338aa commit 439645b

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,14 @@ jobs:
1818
- uses: actions/checkout@v4
1919

2020
- uses: pnpm/action-setup@v4
21-
with:
22-
version: 10
2321

2422
- uses: voidzero-dev/setup-vp@v1
2523
with:
2624
node-version: "24"
2725
cache: true
2826

2927
- name: Format check
30-
run: |
31-
vp check || (echo "--- vp check --fix diff ---" && vp check --fix && git diff && exit 1)
28+
run: vp check
3229

3330
- name: Lint
3431
run: vp lint
@@ -51,8 +48,11 @@ jobs:
5148
steps:
5249
- uses: actions/checkout@v4
5350

54-
- name: Remove lockfile
55-
run: rm pnpm-lock.yaml
51+
- name: Remove lockfile and packageManager field
52+
run: |
53+
rm pnpm-lock.yaml
54+
node -e "const p=require('./package.json'); delete p.packageManager; require('fs').writeFileSync('package.json', JSON.stringify(p, null, 2) + '\n')"
55+
shell: bash
5656

5757
- name: Install panam
5858
run: npm i -g panam-cli

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,5 +53,6 @@
5353
},
5454
"engines": {
5555
"node": ">=24.0.0"
56-
}
56+
},
57+
"packageManager": "pnpm@10.33.0"
5758
}

0 commit comments

Comments
 (0)