Skip to content

Commit 35762b1

Browse files
committed
chore(bootstrap): drop workflow-driven CodeQL — default setup is the SSoT (RAN-46)
The codeql.yml workflow added in 638fda7 conflicts with the repo-level CodeQL default setup that was already enabled for `java-kotlin`, `javascript-typescript`, and `actions`. GitHub Code-Scanning rejects duplicate SARIF uploads for the same language with a "configuration error" (see PR #74's failed `Analyze (javascript-typescript)` run 24928083508). Default setup already covers everything the workflow added (multi-language analysis, SARIF in the Security tab, push + PR + scheduled runs) and is a managed GitHub feature that auto-updates. Keeping the workflow buys us nothing here and breaks every PR with a stuck failed check. Adjustments: - delete .github/workflows/codeql.yml - .bestpractices.json: point `code_scanning` evidence at the default-setup repo setting instead of the deleted workflow - engineering-standards.md §9: document the decision and why default setup won Refs RAN-46 AC #4. Default-setup is being kept enabled per @ceo's post-merge sequence (item #3).
1 parent 0b03459 commit 35762b1

3 files changed

Lines changed: 2 additions & 82 deletions

File tree

.bestpractices.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"license_file": "LICENSE",
2626
"build_reproducible": "mvn -B -ntp clean verify",
2727
"ci_workflow": ".github/workflows/ci-java.yml",
28-
"code_scanning": ".github/workflows/codeql.yml",
28+
"code_scanning": "GitHub repo setting (CodeQL default setup, java-kotlin + javascript-typescript + actions). Workflow-driven CodeQL was tried in PR #74 but conflicts with default setup at SARIF upload — keeping default setup as the SSoT.",
2929
"supply_chain_scorecard": ".github/workflows/scorecard.yml",
3030
"dependency_updates": ".github/dependabot.yml",
3131
"signed_commits": "scripts/setup-git-signed.sh",

.github/workflows/codeql.yml

Lines changed: 0 additions & 81 deletions
This file was deleted.

shared/runbooks/engineering-standards.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,3 +110,4 @@ Ground rules:
110110
- `/home/dev/.claude/rules/*.md` — global engineering rules (parent SSoT).
111111
- `pom.xml` — quality-gate plugin wiring (`jacoco`, `spotbugs`, `dependency-check`, `central-publishing`).
112112
- `.github/workflows/` — CI / release / security automations.
113+
- **CodeQL** — handled by GitHub repo-level **CodeQL default setup** (java-kotlin + javascript-typescript + actions), not a workflow file. A workflow-driven CodeQL was attempted in PR #74 and removed because GitHub rejects duplicate SARIF uploads when default setup is also enabled for the same language. Configuration lives under repo Settings → Code security → Code scanning.

0 commit comments

Comments
 (0)