You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(sonar): direct undefined check + S3776 bucket in bulk-accept
After PR #14 merged, four typescript:S7741 smells appeared on main —
a side effect of `typeof globalThis.window === "undefined"` (carried
over verbatim from the original `typeof window` SSR guards). Now that
we go through globalThis, the property access yields undefined safely
without typeof, so the typeof is genuinely redundant. Replaced with
direct `globalThis.window === undefined` in 4 sites.
Also adds a go:S3776 / typescript:S3776 bucket to the bulk-accept
workflow. Remaining occurrences are HTTP handlers / tailers / engines
where complexity is breadth of cases (auth, decode, validate,
dispatch, error) rather than nesting — extracting helpers used once
would add indirection without reducing reader load. Accepted as
project-wide judgement call rather than per-function.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
0 commit comments