Skip to content

Commit a01f234

Browse files
aksOpsclaude
andauthored
ci: pass -tags sqlite_fts5 to go test and release binary builds (#3)
mattn/go-sqlite3 only compiles FTS5 support when the sqlite_fts5 build tag is set. internal/serve/store's schema uses CREATE VIRTUAL TABLE … USING fts5(…) which fails at runtime with "no such module: fts5" without the tag. The release-on-main run that followed the UI-build fix (24950003140) made it past `make ui` and then blew up on ~25 store/serve tests with this error. Two release.yml steps were missing the tag: - "Run tests" → go test -tags sqlite_fts5 ./... - cross-compile loop → go build -trimpath -tags sqlite_fts5 … Side note: v0.1.0 / v0.1.1 binaries (last successful releases) were built without this tag, so they panic in OpenCostStore on first boot. Once this lands, the next release tag will be the first usable one since the FTS5 feature shipped. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 04dea43 commit a01f234

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,12 @@ jobs:
6565
run: make ui
6666

6767
- name: Run tests
68-
run: go test ./...
68+
# sqlite_fts5: mattn/go-sqlite3 only compiles FTS5 in when this
69+
# tag is set. internal/serve/store's schema uses
70+
# `CREATE VIRTUAL TABLE … USING fts5(…)` — without the tag,
71+
# OpenCostStore() fails at runtime with "no such module: fts5"
72+
# and ~25 store/serve tests blow up.
73+
run: go test -tags sqlite_fts5 ./...
6974

7075
- name: Determine bump level
7176
id: level
@@ -201,8 +206,10 @@ jobs:
201206
mkdir -p "dist/${stage}"
202207
203208
echo "→ building ${target}"
209+
# -tags sqlite_fts5: see "Run tests" step. Released binaries
210+
# without this tag panic at boot in OpenCostStore.
204211
CGO_ENABLED=0 GOOS="$goos" GOARCH="$goarch" \
205-
go build -trimpath -ldflags "$LDFLAGS" \
212+
go build -trimpath -tags sqlite_fts5 -ldflags "$LDFLAGS" \
206213
-o "dist/${stage}/ctm" \
207214
./
208215

0 commit comments

Comments
 (0)