Testing the workflow added for end to end tests (#28)

charithaT07 · web-flow · commit 40dbccea5463 · 2026-01-07T15:16:15.000+05:30
diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml
@@ -1,9 +1,9 @@
 name: e2e tests
 
 on:
-  # Nightly workflow - Run E2E tests on a schedule
+  # Nightly workflow - Run at 2 AM UTC daily
   schedule:
-    - cron: '0 2 * * *'  # Run at 2 AM UTC daily
+    - cron: '0 2 * * *'
   # Post-merge - Run after changes are merged to main
   push:
     branches: [main]
@@ -30,31 +30,14 @@ on:
         description: 'SFCC Sandbox API Host (optional, defaults to var)'
         required: false
         type: string
-      node_version:
-        description: 'Node.js version to test with'
-        required: false
-        default: 'lts/*'
-        type: choice
-        options:
-          - 'lts/-1'
-          - 'lts/*'
-          - 'latest'
-      os:
-        description: 'Operating system to test on'
-        required: false
-        default: 'ubuntu-latest'
-        type: choice
-        options:
-          - 'ubuntu-latest'
-          - 'windows-latest'
 jobs:
   e2e-tests:
     strategy:
       matrix:
-        node_version: [22.x, 24.x]
+        node-version: [22.x, 24.x]
     runs-on: ubuntu-latest
     environment: e2e-dev
-    timeout-minutes: 10  # E2E tests can take longer
+    timeout-minutes: 25
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
@@ -69,11 +52,11 @@ jobs:
           SFCC_ACCOUNT_MANAGER_HOST: ${{ vars.SFCC_ACCOUNT_MANAGER_HOST }}
           SFCC_SANDBOX_API_HOST: ${{ vars.SFCC_SANDBOX_API_HOST }}
         run: |
-          if [ -n "$SFCC_CLIENT_ID" ] && [ -n "$SFCC_CLIENT_SECRET" ] && [ -n "$TEST_REALM" ] && [ -n "SFCC_ACCOUNT_MANAGER_HOST" ] && [ -n "SFCC_SANDBOX_API_HOST" ]; then
+          if [ -n "$SFCC_CLIENT_ID" ] && [ -n "$SFCC_CLIENT_SECRET" ] && [ -n "$TEST_REALM" ] && [ -n "$SFCC_ACCOUNT_MANAGER_HOST" ] && [ -n "$SFCC_SANDBOX_API_HOST" ]; then
             echo "has-secrets=true" >> $GITHUB_OUTPUT
           else
             echo "has-secrets=false" >> $GITHUB_OUTPUT
-            echo "E2E tests skipped - missing required variables:" >> $GITHUB_STEP_SUMMARY
+            echo " E2E tests skipped - missing required variables:" >> $GITHUB_STEP_SUMMARY
             echo "  - SFCC_CLIENT_ID (var): ${SFCC_CLIENT_ID:+✓}" >> $GITHUB_STEP_SUMMARY
             echo "  - TEST_REALM (var): ${TEST_REALM:+✓}" >> $GITHUB_STEP_SUMMARY
             echo "  - SFCC_ACCOUNT_MANAGER_HOST (var): ${SFCC_ACCOUNT_MANAGER_HOST:+✓}" >> $GITHUB_STEP_SUMMARY
@@ -106,8 +89,9 @@ jobs:
       - name: Run E2E Tests
         if: steps.check-secrets.outputs.has-secrets == 'true'
         id: e2e-test
+        working-directory: packages/b2c-cli
         env:
-          # Required environment variables for Commerce Cloud integration
+          # Required environment variables
           SFCC_CLIENT_ID: ${{ inputs.sfcc_client_id || vars.SFCC_CLIENT_ID }}
           SFCC_CLIENT_SECRET: ${{ inputs.sfcc_client_secret || secrets.SFCC_CLIENT_SECRET }}
           SFCC_ACCOUNT_MANAGER_HOST: ${{ inputs.sfcc_account_manager_host || vars.SFCC_ACCOUNT_MANAGER_HOST }}
@@ -118,6 +102,52 @@ jobs:
           SFCC_LOG_LEVEL: silent
         run: |
           echo "Running E2E tests with realm: ${TEST_REALM}"
+          echo "Node version: $(node --version)"
           
-          # Run E2E tests with JSON output for parsing
-          pnpm --filter @salesforce/b2c-cli run test:e2e
+          # Run E2E tests with JSON reporter for test results
+          pnpm run test:e2e && pnpm run lint
+
+      - name: E2E Test Report
+        uses: dorny/test-reporter@fe45e9537387dac839af0d33ba56eed8e24189e8  # v2.3.0
+        if: always() && steps.e2e-test.conclusion != 'cancelled' && steps.check-secrets.outputs.has-secrets == 'true'
+        with:
+          name: E2E Test Results (Node ${{ matrix.node-version }})
+          path: 'packages/b2c-cli/test-results.json'
+          reporter: mocha-json
+
+      - name: Upload E2E Test Results
+        if: always() && steps.e2e-test.conclusion != 'cancelled' && steps.check-secrets.outputs.has-secrets == 'true'
+        uses: actions/upload-artifact@v4
+        with:
+          name: e2e-test-results-node-${{ matrix.node-version }}-${{ github.run_number }}
+          path: packages/b2c-cli/test-results.json
+          retention-days: 30
+
+      - name: Notify on Failure
+        if: failure() && (github.event_name == 'schedule' || github.event_name == 'push') && steps.check-secrets.outputs.has-secrets == 'true'
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const issue = {
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              title: `CLI E2E Tests Failed - ${new Date().toISOString().split('T')[0]}`,
+              body: `## CLI E2E Test Failure
+              
+              The CLI E2E tests have failed. Please investigate.
+              
+              **Workflow:** ${context.workflow}
+              **Run:** ${context.runNumber}
+              **Commit:** ${context.sha}
+              **Event:** ${context.eventName}
+              **Node Version:** ${{ matrix.node-version }}
+              
+              [View workflow run](${context.payload.repository.html_url}/actions/runs/${context.runId})
+              `,
+              labels: ['bug', 'e2e-failure', 'cli', 'needs-investigation']
+            };
+            
+            // Only create issue for scheduled runs to avoid spam
+            if (context.eventName === 'schedule') {
+              github.rest.issues.create(issue);
+            }
diff --git a/packages/b2c-cli/package.json b/packages/b2c-cli/package.json
@@ -131,7 +131,7 @@
     "test": "c8 env OCLIF_TEST_ROOT=. mocha --forbid-only --exclude \"test/functional/e2e/**\" \"test/**/*.test.ts\"",
     "test:ci": "c8 env OCLIF_TEST_ROOT=. mocha --forbid-only --exclude \"test/functional/e2e/**\" --reporter json --reporter-option output=test-results.json \"test/**/*.test.ts\"",
     "test:unit": "env OCLIF_TEST_ROOT=. mocha --forbid-only --exclude \"test/functional/e2e/**\" \"test/**/*.test.ts\"",
-    "test:e2e": "env OCLIF_TEST_ROOT=. mocha --forbid-only \"test/functional/e2e/**/*.test.ts\"",
+    "test:e2e": "env OCLIF_TEST_ROOT=. mocha --forbid-only --reporter json --reporter-option output=test-results.json \"test/functional/e2e/**/*.test.ts\"",
     "coverage": "c8 report",
     "version": "oclif readme && git add README.md",
     "dev": "node ./bin/dev.js"
diff --git a/packages/b2c-cli/test/functional/e2e/ods-lifecycle.test.ts b/packages/b2c-cli/test/functional/e2e/ods-lifecycle.test.ts
@@ -27,7 +27,10 @@ const __dirname = path.dirname(__filename);
  */
 describe('ODS Lifecycle E2E Tests', function () {
   // Timeout for entire test suite
-  this.timeout(360_000); // 6 minutes
+  this.timeout(900_000); // 15 minutes
+
+  // Retry transient failures up to 2 times
+  this.retries(2);
 
   // Test configuration (paths)
   const CLI_BIN = path.resolve(__dirname, '../../../bin/run.js');
@@ -74,8 +77,10 @@ describe('ODS Lifecycle E2E Tests', function () {
 
   describe('Step 1: Create Sandbox', function () {
     it('should create a new sandbox with permissions and wait for readiness', async function () {
-      // --wait can take 5-10 minutes, so increase timeout for this test
-      this.timeout(600_000); // 6 minutes
+      this.timeout(720_000); // 12 minutes
+
+      // Retry up to 3 times for transient failures (API timing issues, rate limits, etc.)
+      this.retries(3);
 
       const result = await runCLI([
         'ods',
@@ -136,6 +141,9 @@ describe('ODS Lifecycle E2E Tests', function () {
 
   describe('Step 3: Deploy Code', function () {
     it('should deploy test cartridge to the sandbox', async function () {
+      // Retry for transient network/deployment issues
+      this.retries(2);
+
       // Skip deploy if we don't have a valid sandbox
       if (!sandboxId || !serverHostname) {
         this.skip();
