Commit 52c91db
committed
Fix test isolation, remove fake timers, cleanup low-value command tests
Test Isolation:
- Add `credentialsFile` parameter to ResolveConfigOptions and LoadConfigOptions
- Update MobifySource to use credentialsFile when provided (overrides ~/.mobify)
- Add --credentials-file flag with MRT_CREDENTIALS_FILE env var to MrtCommand
- Add config-isolation.ts helper to clear SFCC_*/MRT_* env vars for tests
Performance:
- Replace fake timers with pollInterval option in site-archive tests
- Fake timers conflict with MSW v2's microtask queue
- Remove @sinonjs/fake-timers dev dependency
Command Test Cleanup:
- Delete cartridge-command.test.ts (100% trivial delegation tests)
- Simplify base-command.test.ts (keep getExtraParams, catch tests)
- Simplify instance-command.test.ts (keep requireX, context tests)
- Simplify mrt-command.test.ts (keep requireMrtCredentials only)
- Simplify oauth-command.test.ts (keep parseAuthMethods, requireOAuthCredentials)
- Simplify ods-command.test.ts (keep odsClient lazy init tests)
Documentation:
- Update testing skill with config isolation, pollInterval patterns
- Add command test guidelines (what to test vs avoid)
- Remove general knowledge content (basic Mocha/Chai patterns)1 parent 2f35511 commit 52c91db
16 files changed
Lines changed: 329 additions & 1532 deletions
File tree
- .claude/skills/testing
- packages/b2c-tooling-sdk
- src
- cli
- config
- sources
- test
- cli
- config
- helpers
- operations/jobs
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
244 | 244 | | |
245 | 245 | | |
246 | 246 | | |
247 | | - | |
248 | 247 | | |
249 | 248 | | |
| 249 | + | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
110 | 112 | | |
111 | 113 | | |
112 | 114 | | |
| 115 | + | |
113 | 116 | | |
114 | 117 | | |
115 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
58 | 62 | | |
59 | 63 | | |
60 | 64 | | |
61 | 65 | | |
| 66 | + | |
62 | 67 | | |
63 | 68 | | |
64 | 69 | | |
65 | 70 | | |
66 | 71 | | |
| 72 | + | |
67 | 73 | | |
68 | 74 | | |
69 | 75 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| 126 | + | |
| 127 | + | |
126 | 128 | | |
127 | 129 | | |
128 | 130 | | |
| |||
0 commit comments