Fix lint errors and test assertion

- Reorder class members per perfectionist rules
- Fix union type ordering (null before string[])
- Remove unnecessary length check in Array.some()
- Fix test assertion to use lowercase 'apiFamily'

Author: clavery

packages/b2c-cli/src/commands/scapi/schemas/get.ts

@@ -32,6 +32,21 @@ interface GetOutput {
  * Use --expand-all to get the full, unmodified schema.
  */
 export default class ScapiSchemasGet extends ScapiSchemasCommand<typeof ScapiSchemasGet> {
+  static args = {
+    apiFamily: Args.string({
+      description: t('args.apiFamily.description', 'API family (e.g., shopper, admin)'),
+      required: true,
+    }),
+    apiName: Args.string({
+      description: t('args.apiName.description', 'API name (e.g., products, orders)'),
+      required: true,
+    }),
+    apiVersion: Args.string({
+      description: t('args.apiVersion.description', 'API version (e.g., v1)'),
+      required: true,
+    }),
+  };
+
   static description = t(
     'commands.scapi.schemas.get.description',
     'Get a specific SCAPI schema with optional selective expansion',
@@ -56,21 +71,6 @@ export default class ScapiSchemasGet extends ScapiSchemasCommand<typeof ScapiSch
     '<%= config.bin %> <%= command.id %> shopper products v1 --tenant-id f_ecom_zzxy_prd --json',
   ];
 
-  static args = {
-    apiFamily: Args.string({
-      description: t('args.apiFamily.description', 'API family (e.g., shopper, admin)'),
-      required: true,
-    }),
-    apiName: Args.string({
-      description: t('args.apiName.description', 'API name (e.g., products, orders)'),
-      required: true,
-    }),
-    apiVersion: Args.string({
-      description: t('args.apiVersion.description', 'API version (e.g., v1)'),
-      required: true,
-    }),
-  };
-
   static flags = {
     ...ScapiSchemasCommand.baseFlags,
 
@@ -127,7 +127,7 @@ export default class ScapiSchemasGet extends ScapiSchemasCommand<typeof ScapiSch
     }),
   };
 
-  async run(): Promise<GetOutput | string[] | null> {
+  async run(): Promise<GetOutput | null | string[]> {
     this.requireOAuthCredentials();
 
     const {apiFamily, apiName, apiVersion} = this.args;
@@ -364,7 +364,7 @@ export default class ScapiSchemasGet extends ScapiSchemasCommand<typeof ScapiSch
           for (const line of valueLines) {
             lines.push(`${indentStr}  ${line}`);
           }
-        } else if (Array.isArray(value) && value.length > 0 && value.some((item) => typeof item === 'object')) {
+        } else if (Array.isArray(value) && value.some((item) => typeof item === 'object')) {
           // Array with objects - put on next line
           lines.push(`${indentStr}${key}:`);
           const valueLines = serializedValue.split('\n');

packages/b2c-cli/src/utils/scapi/schemas.ts

@@ -29,6 +29,14 @@ export abstract class ScapiSchemasCommand<T extends typeof Command> extends OAut
     }),
   };
 
+  /**
+   * Get the organization ID from the tenant-id flag.
+   */
+  protected getOrganizationId(): string {
+    const tenantId = (this.flags as Record<string, string>)['tenant-id'];
+    return toOrganizationId(tenantId);
+  }
+
   /**
    * Get the SCAPI Schemas client, ensuring short code is configured.
    */
@@ -48,12 +56,4 @@ export abstract class ScapiSchemasCommand<T extends typeof Command> extends OAut
     const oauthStrategy = this.getOAuthStrategy();
     return createScapiSchemasClient({shortCode, tenantId}, oauthStrategy);
   }
-
-  /**
-   * Get the organization ID from the tenant-id flag.
-   */
-  protected getOrganizationId(): string {
-    const tenantId = (this.flags as Record<string, string>)['tenant-id'];
-    return toOrganizationId(tenantId);
-  }
 }

packages/b2c-cli/test/commands/scapi/schemas/get.test.ts

@@ -21,7 +21,7 @@ describe('scapi schemas get', () => {
   it('requires apiFamily argument', async () => {
     const {error} = await runCommand('scapi schemas get --tenant-id f_ecom_zzxy_prd');
     expect(error).to.not.be.undefined;
-    expect(error?.message).to.include('APIFAMILY');
+    expect(error?.message).to.include('apiFamily');
   });
 
   it('shows expand flags in help', async () => {