Register extra params middleware in global registry

The extra params (--extra-query, --extra-body, --extra-headers) were being
parsed but never applied to requests. This fix registers the extra params
middleware in the global middleware registry during BaseCommand.init(),
so it applies to ALL HTTP clients (WebDAV, OCAPI, SLAS, ODS, MRT, Custom APIs).

Author: clavery

packages/b2c-tooling-sdk/src/cli/base-command.ts

@@ -14,7 +14,7 @@ import type {
 } from './hooks.js';
 import {setLanguage} from '../i18n/index.js';
 import {configureLogger, getLogger, type LogLevel, type Logger} from '../logging/index.js';
-import type {ExtraParamsConfig} from '../clients/middleware.js';
+import {createExtraParamsMiddleware, type ExtraParamsConfig} from '../clients/middleware.js';
 import type {ConfigSource} from '../config/types.js';
 import {globalMiddlewareRegistry} from '../clients/middleware-registry.js';
 
@@ -122,6 +122,10 @@ export abstract class BaseCommand<T extends typeof Command> extends Command {
 
     this.configureLogging();
 
+    // Register extra params middleware (from --extra-query, --extra-body, --extra-headers flags)
+    // This must happen before any API clients are created
+    this.registerExtraParamsMiddleware();
+
     // Collect middleware from plugins before any API clients are created
     await this.collectPluginHttpMiddleware();
 
@@ -357,4 +361,20 @@ export abstract class BaseCommand<T extends typeof Command> extends Command {
 
     return config;
   }
+
+  /**
+   * Register extra params (query, body, headers) as global middleware.
+   * This applies to ALL HTTP clients created during command execution.
+   */
+  private registerExtraParamsMiddleware(): void {
+    const extraParams = this.getExtraParams();
+    if (!extraParams) return;
+
+    globalMiddlewareRegistry.register({
+      name: 'cli-extra-params',
+      getMiddleware() {
+        return createExtraParamsMiddleware(extraParams);
+      },
+    });
+  }
 }

packages/b2c-tooling-sdk/test/cli/base-command.test.ts

@@ -401,23 +401,16 @@ describe('cli/base-command', () => {
         metadata: {},
       })) as typeof cmd.parse;
 
-      await cmd.init();
-      let errorCalled = false;
-      const originalError = cmd.error.bind(command);
-      cmd.error = () => {
-        errorCalled = true;
-        throw new Error('Expected error');
-      };
-
+      // Error is thrown during init() when registerExtraParamsMiddleware() calls getExtraParams()
+      let errorThrown = false;
       try {
-        command.testGetExtraParams();
-      } catch {
-        // Expected
+        await cmd.init();
+      } catch (err) {
+        errorThrown = true;
+        expect((err as Error).message).to.include('Invalid JSON for --extra-query');
       }
 
-      expect(errorCalled).to.be.true;
-
-      cmd.error = originalError;
+      expect(errorThrown).to.be.true;
       cmd.parse = originalParse;
     });
 
@@ -430,23 +423,16 @@ describe('cli/base-command', () => {
         metadata: {},
       })) as typeof cmd.parse;
 
-      await cmd.init();
-      let errorCalled = false;
-      const originalError = cmd.error.bind(command);
-      cmd.error = () => {
-        errorCalled = true;
-        throw new Error('Expected error');
-      };
-
+      // Error is thrown during init() when registerExtraParamsMiddleware() calls getExtraParams()
+      let errorThrown = false;
       try {
-        command.testGetExtraParams();
-      } catch {
-        // Expected
+        await cmd.init();
+      } catch (err) {
+        errorThrown = true;
+        expect((err as Error).message).to.include('Invalid JSON for --extra-body');
       }
 
-      expect(errorCalled).to.be.true;
-
-      cmd.error = originalError;
+      expect(errorThrown).to.be.true;
       cmd.parse = originalParse;
     });
 
@@ -497,23 +483,16 @@ describe('cli/base-command', () => {
         metadata: {},
       })) as typeof cmd.parse;
 
-      await cmd.init();
-      let errorCalled = false;
-      const originalError = cmd.error.bind(command);
-      cmd.error = () => {
-        errorCalled = true;
-        throw new Error('Expected error');
-      };
-
+      // Error is thrown during init() when registerExtraParamsMiddleware() calls getExtraParams()
+      let errorThrown = false;
       try {
-        command.testGetExtraParams();
-      } catch {
-        // Expected
+        await cmd.init();
+      } catch (err) {
+        errorThrown = true;
+        expect((err as Error).message).to.include('Invalid JSON for --extra-headers');
       }
 
-      expect(errorCalled).to.be.true;
-
-      cmd.error = originalError;
+      expect(errorThrown).to.be.true;
       cmd.parse = originalParse;
     });
   });