[mode] Mode format returns mode count, not the actual mode

[FlamingKetchup]

It seems that the mode format returns how many times the mode appears, not the actual mode itself

SemanticResultFormats/formats/math/SRF_Math.php

Line 187 in 42c2690

$array_counted_values = array_count_values( $array_temp );

SemanticResultFormats/formats/math/SRF_Math.php

Line 189 in 42c2690

$max = max( $array_counted_values );

SemanticResultFormats/formats/math/SRF_Math.php

Line 201 in 42c2690

return $max;

array_count_values gives counts as values, and max gets the max value, meaning $max is a count, not the most common property value

It seems the unit test even expects the count instead of the actual mode

SemanticResultFormats/tests/phpunit/Integration/JSONScript/TestCases/math-01.json

Lines 309 to 313 in 42c2690

	"about": "#18 format=mode",
	"subject": "Example/Math/Q.19",
	"assert-output": {
	"to-contain": [
	"1"

SemanticResultFormats/tests/phpunit/Integration/JSONScript/TestCases/math-01.json

Lines 94 to 95 in 42c2690

	"page": "Example/Math/Q.19",
	"contents": "{{#show: Example/Math/2 |?Has number|format=mode }}"

SemanticResultFormats/tests/phpunit/Integration/JSONScript/TestCases/math-01.json

Lines 14 to 15 in 42c2690

	"page": "Example/Math/2",
	"contents": "[[Has number::333]]"

The mode should be 333, the only number, but instead it expects and gets how many times 333 occurs

[FlamingKetchup]

Of course this has the issue that the actual mode can be zero, but the format defaults to zero if there's no actual mode. I think it makes more sense to not give a query result, and that way it instead defaults to the Default parameter of the query. It would also be nice if it wasn't restricted to numerical properties.