fix: use ClientError for non-JSON 2xx; document HTTPError.__str__ format change

Copilot · OhYee · web-flow · commit 24e74fc3f708 · 2026-04-30T07:06:24.000Z
Agent-Logs-Url: https://github.com/Serverless-Devs/agentrun-sdk-python/sessions/521d41f7-af5d-44a2-9ba2-b04863849851 Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -14,6 +14,11 @@
   `message`.
 - Existing code that checked returned dictionaries for `code` and `requestId`
   must migrate to `try` / `except ClientError` / `except ServerError`.
+- `HTTPError.__str__()` output format has changed. The old format unconditionally
+  included `"Request ID: None. Details: {}"` even when those fields were empty.
+  The new format only includes non-empty fields and uses `". "` as separator.
+  Code that parses this string representation (e.g. log parsers or test assertions
+  on `str(error)`) must be updated.
 
 ### Migration
 
diff --git a/agentrun/sandbox/api/__sandbox_data_async_template.py b/agentrun/sandbox/api/__sandbox_data_async_template.py
@@ -128,7 +128,7 @@ def _parse_success_response(response: httpx.Response) -> Dict[str, Any]:
         except ValueError as e:
             error_msg = f"Failed to parse JSON response: {e}"
             logger.error(error_msg)
-            raise ServerError(
+            raise ClientError(
                 status_code=response.status_code,
                 message=error_msg,
                 response_body=response.text,
diff --git a/agentrun/sandbox/api/sandbox_data.py b/agentrun/sandbox/api/sandbox_data.py
@@ -138,7 +138,7 @@ def _parse_success_response(response: httpx.Response) -> Dict[str, Any]:
         except ValueError as e:
             error_msg = f"Failed to parse JSON response: {e}"
             logger.error(error_msg)
-            raise ServerError(
+            raise ClientError(
                 status_code=response.status_code,
                 message=error_msg,
                 response_body=response.text,
diff --git a/tests/unittests/sandbox/api/test_sandbox_data.py b/tests/unittests/sandbox/api/test_sandbox_data.py
@@ -224,13 +224,13 @@ def test_sync_success_code_body_is_not_treated_as_error(self):
         assert result == body
 
     @respx.mock
-    def test_sync_success_non_json_body_raises_server_error(self):
+    def test_sync_success_non_json_body_raises_client_error(self):
         api = self.make_api()
         respx.get(f"{DATA_ENDPOINT}/sandboxes/sb-1/health").mock(
             return_value=httpx.Response(200, text="<html>ok</html>")
         )
 
-        with pytest.raises(ServerError) as exc_info:
+        with pytest.raises(ClientError) as exc_info:
             api.get("/health")
 
         error = exc_info.value
