Skip to content

Commit c2b00c1

Browse files
committed
Lint tests
1 parent 770922c commit c2b00c1

10 files changed

Lines changed: 38 additions & 21 deletions

tests/test-attributable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ describe('Attributable', function () {
4545

4646
var result = api.attribute(1, 'some', {token: 'token-aaaa'});
4747

48-
return result.then(function (response) {
48+
return result.then(function () {
49+
/* jshint expr: true */
4950
expect(mock.isDone()).to.be.true;
5051
});
5152
});
@@ -59,7 +60,8 @@ describe('Attributable', function () {
5960

6061
var result = api.attribute(1, 'some', {key: 'key-cccc'});
6162

62-
return result.then(function (response) {
63+
return result.then(function () {
64+
/* jshint expr: true */
6365
expect(mock.isDone()).to.be.true;
6466
});
6567
});

tests/test-deletable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ describe('Deletable', function () {
4545

4646
var result = api.delete(1, {token: 'token-aaaa'});
4747

48-
return result.then(function (response) {
48+
return result.then(function () {
49+
/* jshint expr: true */
4950
expect(mock.isDone()).to.be.true;
5051
});
5152
});
@@ -59,7 +60,8 @@ describe('Deletable', function () {
5960

6061
var result = api.delete(1, {key: 'key-cccc'});
6162

62-
return result.then(function (response) {
63+
return result.then(function () {
64+
/* jshint expr: true */
6365
expect(mock.isDone()).to.be.true;
6466
});
6567
});

tests/test-editable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,8 @@ describe('Editable', function () {
130130

131131
var result = api.edit(ref, request, query, {token: 'token-aaaa'});
132132

133-
return result.then(function (response) {
133+
return result.then(function () {
134+
/* jshint expr: true */
134135
expect(mock.isDone()).to.be.true;
135136
});
136137
});
@@ -154,7 +155,8 @@ describe('Editable', function () {
154155

155156
var result = api.edit(ref, request, query, {key: 'key-cccc'});
156157

157-
return result.then(function (response) {
158+
return result.then(function () {
159+
/* jshint expr: true */
158160
expect(mock.isDone()).to.be.true;
159161
});
160162
});

tests/test-endpoint.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
'use strict';
33

44
var expect = require('chai').expect
5-
, EventEmitter = require('events')
65
, nock = require('nock')
76
;
87

@@ -90,7 +89,7 @@ describe('Endpoint', function () {
9089

9190
var test_endpoint = Object.create({}, {test: test_endpoint_descriptor});
9291

93-
var scope = nock('http://localhost:8080')
92+
nock('http://localhost:8080')
9493
.get('/test')
9594
.matchHeader('x-auth-token', 'token-aaaa')
9695
.reply(200, {});
@@ -135,7 +134,7 @@ describe('Endpoint', function () {
135134

136135
var test_endpoint = Object.create({}, {test: test_endpoint_descriptor});
137136

138-
var scope = nock('http://localhost:8080')
137+
nock('http://localhost:8080')
139138
.get('/test')
140139
.matchHeader('st2-api-key', 'key-cccc')
141140
.reply(200, {});

tests/test-enumerable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ describe('Enumerable', function () {
6363

6464
var result = api.listAll({ a: 'b' }, {token: 'token-aaaa'});
6565

66-
return result.then(function (response) {
66+
return result.then(function () {
67+
/* jshint expr: true */
6768
expect(mock.isDone()).to.be.true;
6869
});
6970
});
@@ -78,7 +79,8 @@ describe('Enumerable', function () {
7879

7980
var result = api.listAll({ a: 'b' }, {key: 'key-cccc'});
8081

81-
return result.then(function (response) {
82+
return result.then(function () {
83+
/* jshint expr: true */
8284
expect(mock.isDone()).to.be.true;
8385
});
8486
});

tests/test-paginatable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,8 @@ describe('Paginatable', function () {
151151

152152
var result = api.listPage(5, { a: 'b', limit: 100 }, {token: 'token-aaaa'});
153153

154-
return result.then(function (response) {
154+
return result.then(function () {
155+
/* jshint expr: true */
155156
expect(mock.isDone()).to.be.true;
156157
});
157158
});
@@ -166,7 +167,8 @@ describe('Paginatable', function () {
166167

167168
var result = api.listPage(5, { a: 'b', limit: 100 }, {key: 'key-cccc'});
168169

169-
return result.then(function (response) {
170+
return result.then(function () {
171+
/* jshint expr: true */
170172
expect(mock.isDone()).to.be.true;
171173
});
172174
});

tests/test-readable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ describe('Readable', function () {
4545

4646
var result = api.get(1, {a: 'b'}, {token: 'token-aaaa'});
4747

48-
result.then(function (response) {
48+
result.then(function () {
49+
/* jshint expr: true */
4950
expect(mock.isDone()).to.be.true;
5051
});
5152
});
@@ -59,7 +60,8 @@ describe('Readable', function () {
5960

6061
var result = api.get(1, {a: 'b'}, {key: 'key-cccc'});
6162

62-
result.then(function (response) {
63+
result.then(function () {
64+
/* jshint expr: true */
6365
expect(mock.isDone()).to.be.true;
6466
});
6567
});

tests/test-repeatable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ describe('Repeatable', function () {
5555

5656
var result = api.repeat(id, request, 'test', {token: 'token-aaaa'});
5757

58-
return result.then(function (response) {
58+
return result.then(function () {
59+
/* jshint expr: true */
5960
expect(mock.isDone()).to.be.true;
6061
});
6162
});
@@ -72,7 +73,8 @@ describe('Repeatable', function () {
7273

7374
var result = api.repeat(id, request, 'test', {key: 'key-cccc'});
7475

75-
return result.then(function (response) {
76+
return result.then(function () {
77+
/* jshint expr: true */
7678
expect(mock.isDone()).to.be.true;
7779
});
7880
});

tests/test-schedulable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ describe('Schedulable', function () {
5353

5454
var result = api.schedule({}, 'test', {token: 'token-aaaa'});
5555

56-
return result.then(function (response) {
56+
return result.then(function () {
57+
/* jshint expr: true */
5758
expect(mock.isDone()).to.be.true;
5859
});
5960
});
@@ -69,7 +70,8 @@ describe('Schedulable', function () {
6970

7071
var result = api.schedule({}, 'test', {key: 'key-cccc'});
7172

72-
return result.then(function (response) {
73+
return result.then(function () {
74+
/* jshint expr: true */
7375
expect(mock.isDone()).to.be.true;
7476
});
7577
});

tests/test-writable.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ describe('Writable', function () {
5353

5454
var result = api.create(request, {token: 'token-aaaa'});
5555

56-
return result.then(function (response) {
56+
return result.then(function () {
57+
/* jshint expr: true */
5758
expect(mock.isDone()).to.be.true;
5859
});
5960
});
@@ -69,7 +70,8 @@ describe('Writable', function () {
6970

7071
var result = api.create(request, {key: 'key-cccc'});
7172

72-
return result.then(function (response) {
73+
return result.then(function () {
74+
/* jshint expr: true */
7375
expect(mock.isDone()).to.be.true;
7476
});
7577
});

0 commit comments

Comments
 (0)