Pass maps by reference to avoid copy

CURA-13049

Author: wawanbreton

include/cura-formulae-engine/ast/ast.h

@@ -55,7 +55,7 @@ class EnvironmentMap : public Environment
 
     void set(const std::string& key, const eval::Value& value) noexcept;
 
-    void add(const std::unordered_map<std::string, eval::Value> values);
+    void add(const std::unordered_map<std::string, eval::Value>& values);
 
     [[nodiscard]] EnvironmentMap clone() const noexcept;
 };
@@ -106,7 +106,7 @@ class LocalEnvironment : public ChainableEnvironment
 
     void set(const std::string& key, const eval::Value& value);
 
-    void add(const std::unordered_map<std::string, eval::Value> values);
+    void add(const std::unordered_map<std::string, eval::Value>& values);
 };
 
 } // namespace CuraFormulaeEngine::env

src/ast/ast.cpp

@@ -33,7 +33,7 @@ void EnvironmentMap::set(const std::string& key, const eval::Value& value) noexc
     environment_.insert_or_assign(key, value);
 }
 
-void EnvironmentMap::add(const std::unordered_map<std::string, eval::Value> values)
+void EnvironmentMap::add(const std::unordered_map<std::string, eval::Value>& values)
 {
     environment_.insert(values.begin(), values.end());
 }
@@ -63,7 +63,7 @@ void LocalEnvironment::set(const std::string& key, const eval::Value& value)
     local_environment_.set(key, value);
 }
 
-void LocalEnvironment::add(const std::unordered_map<std::string, eval::Value> values)
+void LocalEnvironment::add(const std::unordered_map<std::string, eval::Value>& values)
 {
     local_environment_.add(values);
 }