From 03bab4c557d6bafdfe6f3718e81177f001d4e2e9 Mon Sep 17 00:00:00 2001 From: Erwan MATHIEU Date: Tue, 21 Apr 2026 11:16:32 +0200 Subject: [PATCH 1/6] Allow downloading an extra artifact before packaging NP-1311 --- .github/workflows/npm-package.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/npm-package.yml b/.github/workflows/npm-package.yml index 115a6542..ab9dae36 100644 --- a/.github/workflows/npm-package.yml +++ b/.github/workflows/npm-package.yml @@ -17,6 +17,11 @@ on: default: "" type: string + extra_artifact: + required: false + default: "" + type: string + jobs: publish-npm: runs-on: ubuntu-latest @@ -37,6 +42,12 @@ jobs: - name: Install TypeScript 5.6.2 run: npm install -g typescript@5.6.2 + - name: Download extra artifact + if: ${{ extra_artifact != '' }} + uses: actions/download-artifact@v8 + with: + name: ${{ extra_artifact }} + - name: Gather/build the packages run: conan install --requires "${{ inputs.package_version_full }}" -pr:h cura_wasm.jinja -g npm --build=missing --update ${{ inputs.conan_extra_args }} -of . @@ -46,7 +57,6 @@ jobs: registry-url: 'https://npm.pkg.github.com' scope: '@ultimaker' - - name: Publish to GitHub Packages run: | npm publish From 06c16cfd048db34e72c8c315ed01396f7db3e2f5 Mon Sep 17 00:00:00 2001 From: Erwan MATHIEU Date: Tue, 21 Apr 2026 11:23:29 +0200 Subject: [PATCH 2/6] Fix workflow NP-1311 --- .github/workflows/npm-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/npm-package.yml b/.github/workflows/npm-package.yml index ab9dae36..74fd1e0c 100644 --- a/.github/workflows/npm-package.yml +++ b/.github/workflows/npm-package.yml @@ -43,7 +43,7 @@ jobs: run: npm install -g typescript@5.6.2 - name: Download extra artifact - if: ${{ extra_artifact != '' }} + if: ${{ inputs.extra_artifact != '' }} uses: actions/download-artifact@v8 with: name: ${{ extra_artifact }} From 045880ac08ad9963fd2e0e50ec9560e55c07c6ce Mon Sep 17 00:00:00 2001 From: Erwan MATHIEU Date: Tue, 21 Apr 2026 11:25:46 +0200 Subject: [PATCH 3/6] Fix workflow again NP-1311 --- .github/workflows/npm-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/npm-package.yml b/.github/workflows/npm-package.yml index 74fd1e0c..3bf224d0 100644 --- a/.github/workflows/npm-package.yml +++ b/.github/workflows/npm-package.yml @@ -46,7 +46,7 @@ jobs: if: ${{ inputs.extra_artifact != '' }} uses: actions/download-artifact@v8 with: - name: ${{ extra_artifact }} + name: ${{ inputs.extra_artifact }} - name: Gather/build the packages run: conan install --requires "${{ inputs.package_version_full }}" -pr:h cura_wasm.jinja -g npm --build=missing --update ${{ inputs.conan_extra_args }} -of . From 00d0e3c71f5d343603547e80eed8c9b43191c211 Mon Sep 17 00:00:00 2001 From: Erwan MATHIEU Date: Tue, 21 Apr 2026 13:30:46 +0200 Subject: [PATCH 4/6] Add argument to set artifact download path NP-1311 --- .github/workflows/npm-package.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/npm-package.yml b/.github/workflows/npm-package.yml index 3bf224d0..e2a855cb 100644 --- a/.github/workflows/npm-package.yml +++ b/.github/workflows/npm-package.yml @@ -22,6 +22,11 @@ on: default: "" type: string + extra_artifact_destination: + required: false + default: "." + type: string + jobs: publish-npm: runs-on: ubuntu-latest @@ -47,6 +52,7 @@ jobs: uses: actions/download-artifact@v8 with: name: ${{ inputs.extra_artifact }} + path: ${{ inputs.extra_artifact_destination }} - name: Gather/build the packages run: conan install --requires "${{ inputs.package_version_full }}" -pr:h cura_wasm.jinja -g npm --build=missing --update ${{ inputs.conan_extra_args }} -of . From 0a583c929879a676890675755ac4de7fbfaa4f95 Mon Sep 17 00:00:00 2001 From: Erwan MATHIEU Date: Tue, 21 Apr 2026 14:53:19 +0200 Subject: [PATCH 5/6] Display local files NP-1311 --- .github/workflows/npm-package.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/npm-package.yml b/.github/workflows/npm-package.yml index e2a855cb..849dfeb7 100644 --- a/.github/workflows/npm-package.yml +++ b/.github/workflows/npm-package.yml @@ -57,6 +57,9 @@ jobs: - name: Gather/build the packages run: conan install --requires "${{ inputs.package_version_full }}" -pr:h cura_wasm.jinja -g npm --build=missing --update ${{ inputs.conan_extra_args }} -of . + - name: Display the local files + run: ls * + - name: Use Node.js uses: actions/setup-node@v4 with: From 0e3c94b8010f19cdb311a6e0924b8aaae5419ec5 Mon Sep 17 00:00:00 2001 From: Erwan MATHIEU Date: Wed, 22 Apr 2026 12:17:40 +0200 Subject: [PATCH 6/6] Remove debug code NP-1311 --- .github/workflows/npm-package.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/npm-package.yml b/.github/workflows/npm-package.yml index 849dfeb7..e2a855cb 100644 --- a/.github/workflows/npm-package.yml +++ b/.github/workflows/npm-package.yml @@ -57,9 +57,6 @@ jobs: - name: Gather/build the packages run: conan install --requires "${{ inputs.package_version_full }}" -pr:h cura_wasm.jinja -g npm --build=missing --update ${{ inputs.conan_extra_args }} -of . - - name: Display the local files - run: ls * - - name: Use Node.js uses: actions/setup-node@v4 with: