Use importer pool for DynamicMessageFactory

HellAholic · HellAholic · commit 95653aacb785 · 2026-03-18T14:18:45.000+01:00
Construct the DynamicMessageFactory with the importer's DescriptorPool (d-&gt;importer-&gt;pool()) instead of the default pool. This ensures dynamically created protobuf messages use the same descriptor pool as the importer, preventing descriptor resolution issues when registering message types.
diff --git a/src/MessageTypeStore.cpp b/src/MessageTypeStore.cpp
@@ -179,7 +179,7 @@ bool Arcus::MessageTypeStore::registerAllMessageTypes(const std::string& file_na
 
     if (! d->message_factory)
     {
-        d->message_factory = std::make_shared<google::protobuf::DynamicMessageFactory>();
+        d->message_factory = std::make_shared<google::protobuf::DynamicMessageFactory>(d->importer->pool());
     }
 
     for (int i = 0; i < descriptor->message_type_count(); ++i)

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ bool Arcus::MessageTypeStore::registerAllMessageTypes(const std::string& file_na`
`179`	`179`
`180`	`180`	`if (! d->message_factory)`
`181`	`181`	`{`
`182`		`- d->message_factory = std::make_shared<google::protobuf::DynamicMessageFactory>();`
	`182`	`+ d->message_factory = std::make_shared<google::protobuf::DynamicMessageFactory>(d->importer->pool());`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`for (int i = 0; i < descriptor->message_type_count(); ++i)`