Force true (#849)

* aio app build --force-build default to true
* Force build during deploy

Author: purplecabbage

src/commands/app/build.js

@@ -167,8 +167,8 @@ Build.flags = {
     allowNo: true
   }),
   'force-build': Flags.boolean({
-    description: '[default: false] Force a build even if one already exists',
-    default: false,
+    description: '[default: true] Force a build even if one already exists',
+    default: true,
     allowNo: true
   }),
   'content-hash': Flags.boolean({

src/commands/app/deploy.js

@@ -328,7 +328,7 @@ Deploy.flags = {
   'force-build': Flags.boolean({
     description: '[default: true] Force a build even if one already exists',
     exclusive: ['no-build'], // no-build
-    default: false,
+    default: true,
     allowNo: true
   }),
   'content-hash': Flags.boolean({

test/commands/app/build.test.js

@@ -182,7 +182,7 @@ test('flags', async () => {
 
   expect(typeof TheCommand.flags['force-build']).toBe('object')
   expect(typeof TheCommand.flags['force-build'].description).toBe('string')
-  expect(TheCommand.flags['force-build'].default).toEqual(false)
+  expect(TheCommand.flags['force-build'].default).toEqual(true)
   expect(TheCommand.flags['force-build'].allowNo).toEqual(true)
 
   expect(typeof TheCommand.flags['content-hash']).toBe('object')
@@ -327,7 +327,7 @@ describe('run', () => {
     expect(spinner.succeed).toHaveBeenCalledWith(expect.stringContaining('Built 3 action(s) for \'application\''))
     expect(command.error).toHaveBeenCalledTimes(0)
     expect(mockRuntimeLib.buildActions).toHaveBeenCalledTimes(1)
-    expect(mockRuntimeLib.buildActions).toHaveBeenCalledWith(appConfig.application, ['a', 'b', 'c'], false)
+    expect(mockRuntimeLib.buildActions).toHaveBeenCalledWith(appConfig.application, ['a', 'b', 'c'], true)
     expect(mockWebLib.bundle).toHaveBeenCalledTimes(0)
   })
 

test/commands/app/deploy.test.js

@@ -226,7 +226,7 @@ test('flags', async () => {
 
   expect(typeof TheCommand.flags['force-build']).toBe('object')
   expect(typeof TheCommand.flags['force-build'].description).toBe('string')
-  expect(TheCommand.flags['force-build'].default).toEqual(false)
+  expect(TheCommand.flags['force-build'].default).toEqual(true)
   expect(TheCommand.flags['force-build'].allowNo).toEqual(true)
 
   expect(typeof TheCommand.flags['content-hash']).toBe('object')
@@ -327,7 +327,7 @@ describe('run', () => {
     expect(command.buildOneExt).toHaveBeenCalledTimes(1)
     expect(command.buildOneExt).toHaveBeenCalledWith('application',
       appConfig.application,
-      expect.objectContaining({ 'force-build': false, verbose: true }),
+      expect.objectContaining({ verbose: true, 'force-build': true }),
       expect.anything())
   })
 
@@ -343,7 +343,7 @@ describe('run', () => {
     expect(command.buildOneExt).toHaveBeenCalledTimes(1)
     expect(command.buildOneExt).toHaveBeenCalledWith('application',
       appConfig.application,
-      expect.objectContaining({ 'force-build': false, 'web-assets': false }),
+      expect.objectContaining({ 'web-assets': false, 'force-build': true }),
       expect.anything())
   })
 
@@ -413,7 +413,7 @@ describe('run', () => {
 
     expect(command.buildOneExt).toHaveBeenCalledWith('application',
       appConfig.application,
-      expect.objectContaining({ 'force-build': false, 'web-assets': false, action: ['a', 'b', 'c'] }),
+      expect.objectContaining({ 'web-assets': false, action: ['a', 'b', 'c'], 'force-build': true }),
       expect.anything())
     expect(mockRuntimeLib.deployActions).toHaveBeenCalledWith(appConfig.application, {
       filterEntities: { actions: ['a', 'b', 'c'] },
@@ -435,7 +435,7 @@ describe('run', () => {
 
     expect(command.buildOneExt).toHaveBeenCalledWith('application',
       appConfig.application,
-      expect.objectContaining({ 'force-build': false, 'web-assets': false, action: ['c'] }),
+      expect.objectContaining({ 'web-assets': false, action: ['c'], 'force-build': true }),
       expect.anything())
     expect(mockRuntimeLib.deployActions).toHaveBeenCalledWith(appConfig.application, {
       filterEntities: { actions: ['c'] },
@@ -458,7 +458,7 @@ describe('run', () => {
     expect(command.buildOneExt).toHaveBeenCalledTimes(1)
     expect(command.buildOneExt).toHaveBeenCalledWith('application',
       appConfig.application,
-      expect.objectContaining({ 'force-build': false, 'web-assets': false }),
+      expect.objectContaining({ 'web-assets': false, 'force-build': true }),
       expect.anything())
   })
 
@@ -485,7 +485,7 @@ describe('run', () => {
     expect(command.buildOneExt).toHaveBeenCalledTimes(1)
     expect(command.buildOneExt).toHaveBeenCalledWith('application',
       appConfig.application,
-      expect.objectContaining({ 'force-build': false, actions: false }),
+      expect.objectContaining({ actions: false, 'force-build': true }),
       expect.anything())
   })
 
@@ -503,7 +503,7 @@ describe('run', () => {
     expect(command.buildOneExt).toHaveBeenCalledTimes(1)
     expect(command.buildOneExt).toHaveBeenCalledWith('application',
       appConfig.application,
-      expect.objectContaining({ 'force-build': false, actions: false }),
+      expect.objectContaining({ actions: false, 'force-build': true }),
       expect.anything())
   })
 
@@ -520,7 +520,7 @@ describe('run', () => {
     expect(command.buildOneExt).toHaveBeenCalledTimes(1)
     expect(command.buildOneExt).toHaveBeenCalledWith('application',
       appConfig.application,
-      expect.objectContaining({ 'force-build': false }),
+      expect.objectContaining({ 'force-build': true }),
       expect.anything())
   })