From 20beed3d894da07d747efc6ea5dd0375790e7cd6 Mon Sep 17 00:00:00 2001 From: Jesse MacFadyen Date: Wed, 14 May 2025 12:27:49 -0700 Subject: [PATCH] nit: added comment for clarity --- src/commands/app/build.js | 2 ++ src/lib/app-helper.js | 2 ++ src/lib/run-dev.js | 4 +++- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/commands/app/build.js b/src/commands/app/build.js index 1b3b4b50..3e07c0d9 100644 --- a/src/commands/app/build.js +++ b/src/commands/app/build.js @@ -102,6 +102,8 @@ class Build extends BaseCommand { if (flags['web-assets']) { if (config.app.hasFrontend && (flags['force-build'] || !fs.existsSync(config.web.distProd))) { if (config.app.hasBackend) { + // note: 3rd arg, _isLocalDev is not used in RuntimeLib + // there is no such thing as --local anymore const urls = RuntimeLib.utils.getActionUrls(config, false, false, true) await writeConfig(config.web.injectedConfig, urls) } diff --git a/src/lib/app-helper.js b/src/lib/app-helper.js index 4b236e90..7b0cdd9b 100644 --- a/src/lib/app-helper.js +++ b/src/lib/app-helper.js @@ -391,6 +391,8 @@ function buildExtensionPointPayloadWoMetadata (extConfigs) { endpointsPayload[extPointName] = {} let actionUrls = {} if (extPointConfig.app.hasBackend) { + // note: 3rd arg, _isLocalDev is not used in RuntimeLib + // there is no such thing as --local anymore actionUrls = RuntimeLib.utils.getActionUrls(extPointConfig, false, false) } Object.entries(extPointConfig.operations) diff --git a/src/lib/run-dev.js b/src/lib/run-dev.js index 5205a89b..a76d8fe1 100644 --- a/src/lib/run-dev.js +++ b/src/lib/run-dev.js @@ -85,7 +85,9 @@ async function runDev (config, dataDir, options = {}, log = () => {}, inprocHook // note the condition: we still write backend urls EVEN if skipActions is set // the urls will always point to remotely deployed actions if skipActions is set log('injecting backend urls into frontend config') - urls = rtLibUtils.getActionUrls(devConfig, true, !skipActions, true) + // note: 3rd arg, _isLocalDev is not used in RuntimeLib + // there is no such thing as --local anymore + urls = rtLibUtils.getActionUrls(devConfig, false, false, true) } utils.writeConfig(devConfig.web.injectedConfig, urls)