This repository was archived by the owner on May 29, 2019. It is now read-only.
Added an accessibility feature for tabs directive by switching tabs through keyboard#2304
Closed
justin-john wants to merge 4 commits intoangular-ui:masterfrom
Closed
Added an accessibility feature for tabs directive by switching tabs through keyboard#2304justin-john wants to merge 4 commits intoangular-ui:masterfrom
justin-john wants to merge 4 commits intoangular-ui:masterfrom
Conversation
Contributor
|
@justin-john I disagree with selecting (activating) the tab when it gets the focus. That is not how keyboard-accessible tab navigation is supposed to work. If you leave off the ng-focus and just have an empty href, then it works as expected -- you use the tab key to focus a tab, and the enter key to select/activate it. I have created a separate PR with just the empty href here: #2870 |
Author
|
@blah238 Ok. Go ahead. |
Contributor
|
Thank you! |
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
Fixes angular-ui#2226 Fixes angular-ui#2290 Closes angular-ui#2870 Closes angular-ui#2304
stevecavanagh
pushed a commit
to stevecavanagh/bootstrap
that referenced
this pull request
Dec 2, 2015
Fixes angular-ui#2226 Fixes angular-ui#2290 Closes angular-ui#2870 Closes angular-ui#2304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now, UI module
ui.bootstrap.tabs(tabs directive) doesn't have tab switching through keyboard(TabKey).This pull request will add an accessibility feature to tabs directive with switching tabs using
Tabkey of keyboard.