This repository was archived by the owner on May 29, 2019. It is now read-only.
Make toggling accordion groups keyboard accessible#2869
Closed
blah238 wants to merge 1 commit intoangular-ui:masterfrom
Closed
Make toggling accordion groups keyboard accessible#2869blah238 wants to merge 1 commit intoangular-ui:masterfrom
blah238 wants to merge 1 commit intoangular-ui:masterfrom
Conversation
|
This solves the accessibility issue and doesn't mess up the routing. You get my blessing for merging 👍 |
Contributor
|
Excellent. Looks good to me. Thanks! |
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
|
Note that If you have a button or something with "ng-click" inside "accordion-heading". Then the URL will change when clicking on the button unless you do $event.preventDefault(). Since you didn't need to stop the event before, this can introduce new behaviour on websites. |
|
I just noticed that this workaround doesn't work for IE9-10 in terms of accessibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://plnkr.co/edit/Ih2u4SymbKkC4pdwbDMi