This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(tooltip): evaluate appendToBody on init#2921
Closed
chrisirhc wants to merge 1 commit intoangular-ui:masterfrom
Closed
fix(tooltip): evaluate appendToBody on init#2921chrisirhc wants to merge 1 commit intoangular-ui:masterfrom
chrisirhc wants to merge 1 commit intoangular-ui:masterfrom
Conversation
This wasn't working properly with the location change code (lines 305-314) because the observe call happens asynchronously after the linking function has completed. Hence, the locationChangeSuccess wasn't being set up unless the global tooltip option's appendToBody option was set to true.
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
This wasn't working properly with the location change code (lines 305-314) because the observe call happens asynchronously after the linking function has completed. Hence, the locationChangeSuccess wasn't being set up unless the global tooltip option's appendToBody option was set to true. Closes angular-ui#2921
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wasn't working properly with the location change code
(lines 305-314) because the observe call happens asynchronously after
the linking function has completed.
Hence, the locationChangeSuccess wasn't being set up unless the global
tooltip option's appendToBody option was set to true.