Skip to content

Commit 2cb0aad

Browse files
committed
fix: dropped official support for python 3.8
1 parent 3b4fc6d commit 2cb0aad

8 files changed

Lines changed: 12 additions & 14 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515

1616
strategy:
1717
matrix:
18-
python-version: ["3", "3.8", "3.9", "3.10", "3.11", "3.12"]
18+
python-version: ["3", "3.9", "3.10", "3.11", "3.12"]
1919

2020
steps:
2121
- uses: actions/checkout@master
@@ -37,7 +37,7 @@ jobs:
3737
- name: Set up Python ${{ matrix.python-version }}
3838
uses: actions/setup-python@master
3939
with:
40-
python-version: 3.8
40+
python-version: 3.9
4141
- name: Install Python dependencies
4242
run: ./__tests__/setup-pip.sh
4343
- name: Build Docs
@@ -64,7 +64,7 @@ jobs:
6464
- name: Set up Python ${{ matrix.python-version }}
6565
uses: actions/setup-python@master
6666
with:
67-
python-version: 3.8
67+
python-version: 3.9
6868
- name: Build Python distribution
6969
run: |
7070
pip install wheel

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212

1313
strategy:
1414
matrix:
15-
python-version: ["3", "3.8", "3.9", "3.10", "3.11", "3.12"]
15+
python-version: ["3", "3.9", "3.10", "3.11", "3.12"]
1616

1717
steps:
1818
- uses: actions/checkout@main

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ $ tree .
189189

190190
## Supported Versions
191191

192-
- Python 3.8, 3.9, 3.10, 3.11, 3.12
192+
- Python 3.9, 3.10, 3.11, 3.12
193193
- [Mkdocs] 1.0.4 and above.
194194

195195
## Changelog

__tests__/test-local.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,10 @@ echo "Running E2E tests via Bats in Docker (python:$1) -------->"
2323
docker run -it -w /workspace -v $(pwd):/workspace mkdocs-monorepo-test-runner:$1
2424
}
2525

26-
if [[ ! -z "$PYTHON_37_ONLY" ]]; then
27-
docker_run_integration_tests "3.7-slim"
26+
if [[ ! -z "$PYTHON_39_ONLY" ]]; then
27+
docker_run_integration_tests "3.9-slim"
2828
else
2929
docker_run_integration_tests "3-slim"
30-
docker_run_integration_tests "3.7-slim"
31-
docker_run_integration_tests "3.8-slim"
3230
docker_run_integration_tests "3.9-slim"
3331
docker_run_integration_tests "3.10-slim"
3432
docker_run_integration_tests "3.11-slim"

docs/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
- Remove use of warning_filter (deprecated) [#108]
99
- add support for monorepos with symlink folders [#122]
1010
- Fix edit URL for included projects with nested site_name [#128]
11+
- Dropped official support for Python 3.8
1112

1213
## 1.1.0
1314

docs/CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,10 @@ The command below will use Docker to run our test suites in numerous Python vers
145145
$ ./__tests__/test-local.sh
146146
```
147147

148-
For faster tests, you can opt to run in Python 3.7 rather than all supported Python versions:
148+
For faster tests, you can opt to run in Python 3.9 rather than all supported Python versions:
149149

150150
```terminal
151-
$ PYTHON_37_ONLY=1 ./__tests__/test-local.sh
151+
$ PYTHON_39_ONLY=1 ./__tests__/test-local.sh
152152
```
153153

154154
[GitHub Actions] will always execute tests a little faster (due to parallelization) when you push your branch. Due to this, you can choose to opt of running them locally if you wish!

docs/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ $ tree .
116116

117117
## Supported Versions
118118

119-
- Python 3 — 3.7, 3.8, 3.9, 3.10, 3.11
119+
- Python 3 — 3.9, 3.10, 3.11
120120
- [Mkdocs] 1.0.4 and above.
121121

122122
## License

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,14 @@
1414
author="Bilawal Hameed",
1515
author_email="bil@spotify.com",
1616
license="Apache-2.0",
17-
python_requires=">=3",
17+
python_requires=">=3.9",
1818
install_requires=["mkdocs>=1.0.4", "python-slugify>=4.0.1"],
1919
classifiers=[
2020
"Development Status :: 5 - Production/Stable",
2121
"Intended Audience :: Developers",
2222
"Intended Audience :: Information Technology",
2323
"Programming Language :: Python",
2424
"Programming Language :: Python :: 3 :: Only",
25-
"Programming Language :: Python :: 3.8",
2625
"Programming Language :: Python :: 3.9",
2726
"Programming Language :: Python :: 3.10",
2827
"Programming Language :: Python :: 3.11",

0 commit comments

Comments
 (0)