Commit d81b758
bcode
ci(release): resolve tag SHA explicitly for workflow_dispatch correctness
Cubic review on PR #40: \GITHUB_SHA\ is the SHA of the ref that triggered
the workflow, not necessarily the selected tag's commit. For push: tags
they're equivalent, but for workflow_dispatch with inputs.tag, GITHUB_SHA
is the dispatch ref's HEAD (typically main) — letting any feature-branch
tag pass the ancestry check trivially.
Fix: resolve refs/tags/\^{commit} via git rev-parse and ancestry-
check that. Fails loudly with an actionable message if the tag doesn't
exist yet (the workflow_dispatch path's failure mode for a fresh tag
should be 'create the tag deliberately first', not 'silently tag at
checkout HEAD').1 parent 6ce5840 commit d81b758
1 file changed
Lines changed: 14 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
72 | 80 | | |
73 | 81 | | |
74 | | - | |
75 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
76 | 88 | | |
77 | 89 | | |
78 | 90 | | |
| |||
0 commit comments