Merge pull request #173 from buildkite-plugins/toote_test_revamp

Test revamp & dependency update

Author: pzeballos

.buildkite/pipeline.yml

@@ -1,17 +1,17 @@
 steps:
   - label: ":bash: Plugin"
     plugins:
-      docker-compose#v3.9.0:
+      docker-compose#v4.2.0:
         run: plugin
   - label: ":ruby: Ruby"
     plugins:
-      docker-compose#v3.9.0:
+      docker-compose#v4.2.0:
         run: ruby
   - label: "✨ Lint"
     plugins:
       plugin-linter#v3.0.0:
         id: junit-annotate
   - label: ":bash: Shellcheck"
     plugins:
-      shellcheck#v1.2.0:
+      shellcheck#v1.3.0:
         files: hooks/*

docker-compose.yml

@@ -1,7 +1,7 @@
 version: '2'
 services:
   plugin:
-    image: buildkite/plugin-tester:latest@sha256:476a1024936901889147f53d2a3d8e71e99d76404972d583825514f5608083dc
+    image: buildkite/plugin-tester:v3.0.1
     volumes:
       - ".:/plugin"
     depends_on:

hooks/command

@@ -2,11 +2,14 @@
 
 set -euo pipefail
 
+if [[ -z "${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS:-}" ]]; then
+  echo "🚨 Missing artifacts configuration for the plugin"
+  exit 1
+fi
+
 PLUGIN_DIR="$(cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd)/.."
 MAX_SIZE=1024 # in KB
 
-echo "--- :junit: Download the junits"
-
 artifacts_dir="$(pwd)/$(mktemp -d "junit-annotate-plugin-artifacts-tmp.XXXXXXXXXX")"
 annotation_dir="$(pwd)/$(mktemp -d "junit-annotate-plugin-annotation-tmp.XXXXXXXXXX")"
 annotation_path="${annotation_dir}/annotation.md"
@@ -26,9 +29,11 @@ function check_size {
 
 trap cleanup EXIT
 
-buildkite-agent artifact download \
-  "${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS}" \
-  "$artifacts_dir"
+echo "--- :junit: Download the junits"
+if ! buildkite-agent artifact download "${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_ARTIFACTS}" "$artifacts_dir"; then
+  echo "--- :boom: Could not download artifacts"
+  exit 2
+fi
 
 echo "--- :junit: Processing the junits"
 
@@ -45,15 +50,19 @@ docker \
     ruby:2.7-alpine ruby /src/bin/annotate /junits \
       > "$annotation_path"
 
-if [[ $? -eq 64 ]]; then # special exit code to signal test failures
+exit_code=$?
+set -e
+
+if [[ $exit_code -eq 64 ]]; then # special exit code to signal test failures
   annotation_style="error"
   if [[ "${BUILDKITE_PLUGIN_JUNIT_ANNOTATE_FAIL_BUILD_ON_ERROR:-false}" =~ (true|on|1) ]]; then
     fail_build=1
   fi
+elif [[ $exit_code -ne 0 ]]; then
+  echo "--- :boom: Error when processing JUnit tests"
+  exit $exit_code
 fi
 
-set -e
-
 cat "$annotation_path"
 
 if grep -q "<details>" "$annotation_path"; then

renovate.json

@@ -1,6 +1,7 @@
 {
   "extends": [
-    "config:base"
+    "config:base",
+    ":disableDependencyDashboard"
   ],
   "bundler": {
     "enabled": true