Review feedback

Author: JanSF

hooks/command

@@ -202,18 +202,12 @@ download_binary_and_run() {
 }
 
 run_preinstalled_binary() {
-  local _executable="monorepo-diff-buildkite-plugin"
+  local _executable="${executable}"
 
-  # Check if BINARY_FOLDER is defined and use that path
-  if [[ -n "${BUILDKITE_PLUGIN_MONOREPO_DIFF_BINARY_FOLDER:-}" ]]; then
-    _executable="${BUILDKITE_PLUGIN_MONOREPO_DIFF_BINARY_FOLDER%/}/${_executable}"
-    if ! check_cmd "$_executable"; then
-      err "Binary not found or not executable in BINARY_FOLDER: $_executable"
-    fi
-  else
-    # Fall back to PATH lookup
-    if ! check_cmd "$_executable"; then
-      err "Binary '$_executable' not found in PATH. Please install it or set download: true"
+  if ! check_cmd "${_executable}"; then
+    _executable="$(basename "${executable}")"
+    if ! check_cmd "${_executable}"; then
+      err "Binary '$_executable' not found in PATH or binary_folder option. Please install it or set download: true"
     fi
   fi
 

tests/command.bats

@@ -9,7 +9,6 @@ setup() {
   export BUILDKITE_PLUGIN_MONOREPO_DIFF_BUILDKITE_PLUGIN_TEST_MODE=true
   # Set a minimal plugin config (only used by Go binary, not the bash hook's download logic)
   export BUILDKITE_PLUGINS='[{"monorepo-diff": {}}]'
-  export BUILDKITE_PLUGINS_PATH='/etc/buildkite-agent/plugins'
 
   # Create a mock binary in the current directory for download mode tests
   cat > "$PWD/monorepo-diff-buildkite-plugin" << 'MOCKBIN'
@@ -105,8 +104,8 @@ teardown() {
   export BUILDKITE_PLUGINS='[{"github.com/buildkite-plugins/monorepo-diff-buildkite-plugin#v1.0.0": {}}]'
 
   # Remove mock binary so it actually needs to download
-  rm -f "$BUILDKITE_PLUGINS_PATH/monorepo-diff-buildkite-plugin"
-  rm -f "$BUILDKITE_PLUGINS_PATH/monorepo-diff-buildkite-plugin.version"
+  rm -f "$PWD/monorepo-diff-buildkite-plugin"
+  rm -f "$PWD/monorepo-diff-buildkite-plugin.version"
 
   # Stub curl: fail twice on download, then succeed and create executable
   stub curl \
@@ -130,10 +129,9 @@ teardown() {
   export BUILDKITE_PLUGIN_MONOREPO_DIFF_BUILDKITE_PLUGIN_TEST_MODE=false
   # Use pinned version to skip get_latest_version API call
   export BUILDKITE_PLUGINS='[{"github.com/buildkite-plugins/monorepo-diff-buildkite-plugin#v1.0.0": {}}]'
-
+  
   # Remove mock binary so it actually needs to download
-  rm -f "$BUILDKITE_PLUGINS_PATH/monorepo-diff-buildkite-plugin"
-  rm -f "$BUILDKITE_PLUGINS_PATH/monorepo-diff-buildkite-plugin.version"
+  rm -f "$PWD/monorepo-diff-buildkite-plugin"
 
   # Stub curl to always fail on download
   stub curl \